From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=8Efu=EJ=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6FAFDC00A89
	for <linux-kernel@archiver.kernel.org>; Tue,  3 Nov 2020 03:23:02 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 3C83322275
	for <linux-kernel@archiver.kernel.org>; Tue,  3 Nov 2020 03:23:02 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726913AbgKCDXB (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 2 Nov 2020 22:23:01 -0500
Received: from smtprelay0087.hostedemail.com ([216.40.44.87]:50634 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1725913AbgKCDXA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Nov 2020 22:23:00 -0500
Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
        by smtprelay01.hostedemail.com (Postfix) with ESMTP id 96961100E7B43;
        Tue,  3 Nov 2020 03:22:59 +0000 (UTC)
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-HE-Tag: glove14_5108839272b5
X-Filterd-Recvd-Size: 2071
Received: from XPS-9350.home (unknown [47.151.133.149])
        (Authenticated sender: joe@perches.com)
        by omf19.hostedemail.com (Postfix) with ESMTPA;
        Tue,  3 Nov 2020 03:22:58 +0000 (UTC)
Message-ID: <35625559ea6fa7827e840905a4a03e624fdeb43f.camel@perches.com>
Subject: Re: [PATCH v2] fs/aio.c: Cosmetic
From:   Joe Perches <joe@perches.com>
To:     Andreas Dilger <adilger@dilger.ca>,
        Alejandro Colomar <colomar.6.4.3@gmail.com>
Cc:     Benjamin LaHaise <bcrl@kvack.org>, linux-aio@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 02 Nov 2020 19:22:57 -0800
In-Reply-To: <7CCB9FA6-DE85-4E3F-B3F1-7144F01589D4@dilger.ca>
References: <20201102152439.315640-1-colomar.6.4.3@gmail.com>
         <20201102215809.17312-1-colomar.6.4.3@gmail.com>
         <7CCB9FA6-DE85-4E3F-B3F1-7144F01589D4@dilger.ca>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2020-11-02 at 17:50 -0700, Andreas Dilger wrote:
> On Nov 2, 2020, at 2:58 PM, Alejandro Colomar <colomar.6.4.3@gmail.com> wrote:
> > Changes:
> > - Consistently use 'unsigned int', instead of 'unsigned'.
> > - Add a blank line after variable declarations.
> > - Move variable declarations to the top of functions.
> > - Add a blank line at the top of functions if there are no declarations.
> 
> I'd agree that the other changes are following kernel coding style, but
> I've never heard of leaving a blank line at the start of functions without
> any local variables.

I think that is odd as well.

> I don't see anything in process/coding-style.rst to
> support this change, nor are the majority of variable-less functions
> formatted this way, and it seems to just be a waste of vertical space.

checkpatch emits a --strict CHECK for those blank lines after
open braces


CHECK: Blank lines aren't necessary after an open brace '{'
#200: FILE: fs/aio.c:256:
 {
+

CHECK: Blank lines aren't necessary after an open brace '{'
#246: FILE: fs/aio.c:370:
 {
+

etc...