From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v6 6/9] test: dynamic rss configuration
Date: Tue, 27 Oct 2015 18:34:11 +0100
Message-ID: <3564070.kbSGEXeQ4h@xps13>
References: <1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com>
 <1444989651-6236-1-git-send-email-tomaszx.kulasek@intel.com>
 <1444989651-6236-7-git-send-email-tomaszx.kulasek@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id CF4458D3D
 for <dev@dpdk.org>; Tue, 27 Oct 2015 18:35:21 +0100 (CET)
Received: by wijp11 with SMTP id p11so224957594wij.0
 for <dev@dpdk.org>; Tue, 27 Oct 2015 10:35:21 -0700 (PDT)
In-Reply-To: <1444989651-6236-7-git-send-email-tomaszx.kulasek@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

This new test depends on null PMD.
The dependency should be checked gracefully, see below.

2015-10-16 12:00, Tomasz Kulasek:
> --- a/app/test/Makefile
> +++ b/app/test/Makefile
> @@ -138,6 +138,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c
>  ifeq ($(CONFIG_RTE_LIBRTE_PMD_RING),y)
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding.c
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding_mode4.c

Why not enclose in ifeq ($(CONFIG_RTE_LIBRTE_PMD_NULL),y)?

> +SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding_rssconf.c
>  endif
>  
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) += test_pmd_ring.c
> @@ -168,6 +169,13 @@ ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
>  LDLIBS += -lrte_pmd_ring
>  endif
>  endif
> +ifneq ($(CONFIG_RTE_LIBRTE_PMD_NULL),y)
> +$(error Link bonding rssconf tests require CONFIG_RTE_LIBRTE_PMD_NULL=y)

Not needed if handled as suggested above.
The build should not fail because a module is disabled.

> +else
> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
> +LDLIBS += -lrte_pmd_null
> +endif
> +endif