From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D955EC04A68 for ; Wed, 27 Jul 2022 14:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232891AbiG0Ot1 (ORCPT ); Wed, 27 Jul 2022 10:49:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234228AbiG0OtX (ORCPT ); Wed, 27 Jul 2022 10:49:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 95A113FA16 for ; Wed, 27 Jul 2022 07:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658933361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pr0XffMgM0PbydBzrF3k1K/HGVzJTnmqlVyn8cjx5NE=; b=ionklLY5QytHWpZhS7yScowiEdahQc9nd42oKZCYxMWlmrmiC5XiX1MO6KR79OdnJVGcHq m1D0n79T2/hhC/GzK44BcsKl9a90in8QYsgdc76t2yUEJan5BGMoQsO6uwb+frNcq1FQuY ufFV05iWfSscBdRaJ1yPmPKKSnGgXY4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-220-4S3EawaGOK6EetPWgEohYw-1; Wed, 27 Jul 2022 10:49:18 -0400 X-MC-Unique: 4S3EawaGOK6EetPWgEohYw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A2FA285A581; Wed, 27 Jul 2022 14:49:17 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7CF9AC33AE6; Wed, 27 Jul 2022 14:49:16 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220724071958.2557-1-hdanton@sina.com> References: <20220724071958.2557-1-hdanton@sina.com> <20220724052426.2504-1-hdanton@sina.com> To: Hillf Danton Cc: dhowells@redhat.com, Siddh Raman Pant , "Fabio M. De Francesco" , "linux-kernel" , "syzbot+c70d87ac1d001f29a058" , "linux-security-modules" , "linux-kernel-mentees" Subject: Re: [PATCH v2] kernel/watch_queue: Make pipe NULL while clearing watch_queue MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3565219.1658933355.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 27 Jul 2022 15:49:15 +0100 Message-ID: <3565221.1658933355@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hillf Danton wrote: > Yes, you are right. I missed 353f7988dd84 ("watchqueue: make sure to ser= ialize > 'wqueue->defunct' properly"). Sorry for my noise. > = > Given defunct serialized, still need to clear wqueue->pipe in the clear > path as proposed? In fact, with the locking, is wqueue->defunct even still needed, I wonder? David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5EC6C04A68 for ; Wed, 27 Jul 2022 14:49:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 45C90408C0; Wed, 27 Jul 2022 14:49:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 45C90408C0 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Fz0PgOY+ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JM_d6MPC3I_j; Wed, 27 Jul 2022 14:49:24 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 3447C405AA; Wed, 27 Jul 2022 14:49:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3447C405AA Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E770DC0033; Wed, 27 Jul 2022 14:49:23 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id DBC75C002D for ; Wed, 27 Jul 2022 14:49:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B741460C09 for ; Wed, 27 Jul 2022 14:49:21 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B741460C09 Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Fz0PgOY+ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XQ0uqpDTjBjH for ; Wed, 27 Jul 2022 14:49:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 158ED60A88 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 158ED60A88 for ; Wed, 27 Jul 2022 14:49:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658933360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pr0XffMgM0PbydBzrF3k1K/HGVzJTnmqlVyn8cjx5NE=; b=Fz0PgOY+vTH1TKrLdv79X8XtDPEYwGzrIf/q+3hQuAIc6bTjskKzdOcdAXdIigEfUitiQu YT2wbWnv7yas5/V9/TtdCPuuDfiK//uio6gMezlnI/K5mTjigIDVCGtO+G3qlCLUFqGYH5 a+ZAnsyGAHlkRbeqgQtKaqZ6zmT+qwA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-220-4S3EawaGOK6EetPWgEohYw-1; Wed, 27 Jul 2022 10:49:18 -0400 X-MC-Unique: 4S3EawaGOK6EetPWgEohYw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A2FA285A581; Wed, 27 Jul 2022 14:49:17 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7CF9AC33AE6; Wed, 27 Jul 2022 14:49:16 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220724071958.2557-1-hdanton@sina.com> References: <20220724071958.2557-1-hdanton@sina.com> <20220724052426.2504-1-hdanton@sina.com> To: Hillf Danton Subject: Re: [PATCH v2] kernel/watch_queue: Make pipe NULL while clearing watch_queue MIME-Version: 1.0 Content-ID: <3565219.1658933355.1@warthog.procyon.org.uk> Date: Wed, 27 Jul 2022 15:49:15 +0100 Message-ID: <3565221.1658933355@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Cc: linux-kernel-mentees , linux-kernel , syzbot+c70d87ac1d001f29a058 , dhowells@redhat.com, linux-security-modules , "Fabio M. De Francesco" X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" Hillf Danton wrote: > Yes, you are right. I missed 353f7988dd84 ("watchqueue: make sure to serialize > 'wqueue->defunct' properly"). Sorry for my noise. > > Given defunct serialized, still need to clear wqueue->pipe in the clear > path as proposed? In fact, with the locking, is wqueue->defunct even still needed, I wonder? David _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees