From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A03C63777 for ; Mon, 30 Nov 2020 23:59:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66182208C3 for ; Mon, 30 Nov 2020 23:59:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="2cWjPGUa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730551AbgK3X6p (ORCPT ); Mon, 30 Nov 2020 18:58:45 -0500 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:40706 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgK3X6o (ORCPT ); Mon, 30 Nov 2020 18:58:44 -0500 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 018FF806AC; Tue, 1 Dec 2020 12:58:01 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1606780681; bh=ccfymgGeYZ3pdK9TTrpFGhZ4gbukmOE2n7TkhvLgHjo=; h=From:To:CC:Subject:Date:References:In-Reply-To; b=2cWjPGUaHOmsPJz+MC/B65eOGFi1HfWWmH+upD+rfNDQi43fulNWubsK/q3X/t4Hr 8iGjsIAMdntU/cBYl2DNsRKg6Ytr0UlV5jMCem9AyfY+3N5x3azBnd34HGBYqNB/PT 14XS3tXdVT2/39n1vHT+P0ZCwJoH0O1Cfq7v3Yyk6DkEaLi20U2rEvLKSF6lvJ7mUv LZ3N2LBnFKKYccNxDefZaMSV4Pwar4RHYTOKxf+JMSdteTcsoIuZf5nlMvMQYnyXZl tmaU7zFjD/JyCy7z3s+QrvnunvYyUX2eJ8YeBQ1U21XyvYrL4zLYWPQoaWe+YjPf+m BIcvtjgrT5RzQ== Received: from svr-chch-ex1.atlnz.lc (Not Verified[10.32.16.77]) by mmarshal3.atlnz.lc with Trustwave SEG (v7,5,8,10121) id ; Tue, 01 Dec 2020 12:57:59 +1300 Received: from svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8:409d:36f5:8899:92e8) by svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8:409d:36f5:8899:92e8) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 1 Dec 2020 12:58:00 +1300 Received: from svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8]) by svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8%12]) with mapi id 15.00.1497.008; Tue, 1 Dec 2020 12:58:00 +1300 From: Chris Packham To: Andrew Lunn , Aryan Srivastava CC: "robh+dt@kernel.org" , "gregory.clement@bootlin.com" , "sebastian.hesselbarth@gmail.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2] ARM: dts: mvebu: Add device tree for ATL-x530 Board Thread-Topic: [PATCH v2] ARM: dts: mvebu: Add device tree for ATL-x530 Board Thread-Index: AQHWx2kQGCxRd6BcVkCfnQc+UL0F2qngcWyAgAAPFoA= Date: Mon, 30 Nov 2020 23:57:59 +0000 Message-ID: <3570cb6d-44e0-3ab5-b464-a013ba1007b1@alliedtelesis.co.nz> References: <20201130223507.23571-1-aryan.srivastava@alliedtelesis.co.nz> <20201130230359.GH2073444@lunn.ch> In-Reply-To: <20201130230359.GH2073444@lunn.ch> Accept-Language: en-NZ, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.32.1.11] Content-Type: text/plain; charset="utf-8" Content-ID: <9A2F605EC80A4247AC07776013CA51C5@atlnz.lc> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DQpPbiAxLzEyLzIwIDEyOjAzIHBtLCBBbmRyZXcgTHVubiB3cm90ZToNCj4gT24gVHVlLCBEZWMg MDEsIDIwMjAgYXQgMTE6MzU6MDdBTSArMTMwMCwgQXJ5YW4gU3JpdmFzdGF2YSB3cm90ZToNCj4+ IEFkZCBkZXZpY2UgdHJlZSBmaWxlIGZvciB4NTMwIGJvYXJkLiBUaGlzIGhhcyBhbiBBcm1hZGEg Mzg1IFNvQy4gSGFzDQo+PiBOQU5ELWZsYXNoIGZvciB1c2VyIHN0b3JhZ2UgYW5kIFNQSSBmb3Ig Ym9vdGluZy4gQ292ZXJzIG1ham9yaXR5IG9mIHg1MzANCj4+IGFuZCBHUzk4ME1YIHZhcmlhbnRz Lg0KPiBIaSBBcnlhbg0KPg0KPiBXaGF0IGV4YWN0bHkgZG9lcyB0aGF0IG1lYW4sIGl0IGNvdmVy cyBtb3N0IHZhcmlhbnRzPw0KDQpXZSB3ZXJlIHRyeWluZyB0byBhdm9pZCB0aGUgcGF0Y2ggc3Vi bWlzc2lvbiBiZWNvbWluZyBtYXJrZXRpbmcgc3BhbSBhbmQgDQpoYXZlIHByb2JhYmx5IGJlZW4g YSBsaXR0bGUgdG9vIHZhZ3VlLg0KDQpCZXR3ZWVuIHRoZSB4NTMwLCB4NTMwTCBhbmQgR1M5ODBN WCB0aGVyZSBhcmUgMjQgZGlmZmVyZW50IG1vZGVscy4gVGhlIA0KZGlmZmVyZW5jZXMgYmV0d2Vl biB0aGVtIGFyZSBpbiB0aGUgdHlwZSBhbmQgbnVtYmVyIG9mIHN3aXRjaCBBU0lDcywgdGhlIA0K bnVtYmVyIG9mIFBTVXMgYW5kIHdoZXRoZXIgUG9FIGlzIHN1cHBvcnRlZC4gQnV0IHRoZSBDUFUg YmxvY2sgaXMgDQpsYXJnZWx5IHRoZSBzYW1lIGJldHdlZW4gbW9kZWxzLg0KDQo+IEknbSBqdXN0 IHdvbmRlcmluZyBpZiB0aGlzIHNob3VsZCBiZSBhIC5kdHNpIGZpbGUsIGFuZCB0aGVuIGVhY2gN Cj4gdmFyaWFudCBoYXMgYSAuZHRzIGZpbGUgc3BlY2lmaWMgdG8gaXQ/DQpUaGlzIGlzIHdoYXQg d2UndmUgZG9uZSBpbiBvdXIga2VybmVsIGZvcmsuIEJ1dCBmb3IgdXBzdHJlYW1pbmcgd2UgDQp3 YW50ZWQgdG8gc3RhcnQgc2xvdyBhbmQgbWF5YmUgbW92ZSB0aGluZ3MgaW50byBvbmUgb3IgbW9y ZSBjb21tb24gLmR0c2kgDQpmaWxlcyBpZi93aGVuIG5lZWRlZCAoaW4gcGFydGljdWxhciB0aGVy ZSBhcmUgc29tZSBtb2RlbHMgaW4gZGV2ZWxvcG1lbnQgDQpub3cgdGhhdCB1c2UgZGlmZmVyZW50 IGkyYyBtdXggYW5kIGh3bW9uIGNoaXBzKS4NCj4gT3IgaXMgdGhlIGhhcmR3YXJlIGl0c2VsZiB0 aGUNCj4gc2FtZSwgYW5kIG9ubHkgdGhlIHNvZnR3YXJlIHZhcmllcyBiZXR3ZWVuIHRoZSB2YXJp YW50cz8NCktpbmQgb2YgYm90aC4gVGhpcyBwYXRjaCBzdWJtaXNzaW9uIGJhc2ljYWxseSByZXBy ZXNlbnRzIHRoZSBjb21tb24gDQppdGVtcyBhbW9uZyBhbGwgdGhlIChjdXJyZW50bHkgc2hpcHBp bmcpIHZhcmlhbnRzLg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB197C63777 for ; Mon, 30 Nov 2020 23:59:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1074D206E9 for ; Mon, 30 Nov 2020 23:59:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UJlX5N0E"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="nEYNr2me" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1074D206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alliedtelesis.co.nz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4H9Vur+QV0naaDmIOQxMajCNR2fjH96G/QHg7BzTKM8=; b=UJlX5N0E0HdwryLv8BzkVXgaw Y8bKaET7On/oag4o+EMBDtrGLXV6xKRFeLGp6kz+wvbxTmQyowYOZ10dJ5Irf7oYbeQumoxaHzLtz VrXumKTB2JfgZERFHt3R3F+3e3T/iiUlkJ/J+/3fn01+L2Ry+GX6TSjXADRJc/Dm3SiM/r1pCICuK awM/jNAFuN+e4A42qdXFteM+d3FaMygM9BP9qNG5KVhODxOZc0r5fE8l5TF6OyWchAkXopPlx7KEo HjdlPkZM+1aXcBdSu/1oc8eYFRAONyxCIgj8RtLaYOqWpRpqfZo4j+6nbTM5Yq1clFA9fdq10Umu4 dQ1P2cFeg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjt3g-0004Qk-Lx; Mon, 30 Nov 2020 23:58:16 +0000 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjt3e-0004QK-1Z for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 23:58:15 +0000 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id F261A806A8; Tue, 1 Dec 2020 12:58:00 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1606780680; bh=ccfymgGeYZ3pdK9TTrpFGhZ4gbukmOE2n7TkhvLgHjo=; h=From:To:CC:Subject:Date:References:In-Reply-To; b=nEYNr2mesa598OosmZ4ufaumqiGX3X999KnUoWNTELvVzr8F6bbWedH43dPfn4ZKO AewX2t3ORvLZBLoQajoBNmKh3xNheEuvBx4AMz8dm+2Xr8VzK1Mz7ejkfnfSFqkemq 95hpxm11sBDO89SBOlLKMtmObwOkuj3SxoDHZGAdvEhNTPu8gfcQ211OVXpxY6tUEP GpbiP7j30dEF+nyNslbo7zT47TTG9y1XumIe6ZopT6Rz+953u0+pdsSTVYwtPyf1UK dVXKhzzXJcGrgug5k10aZ+JCIBxZXG0yGDlkWILDa5Dw3tG89XwDEEy0jAZJ5Bh1Yx FsnMg06nep0Kg== Received: from svr-chch-ex1.atlnz.lc (Not Verified[10.32.16.77]) by mmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 8, 10121) id ; Tue, 01 Dec 2020 12:57:59 +1300 Received: from svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8:409d:36f5:8899:92e8) by svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8:409d:36f5:8899:92e8) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 1 Dec 2020 12:58:00 +1300 Received: from svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8]) by svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8%12]) with mapi id 15.00.1497.008; Tue, 1 Dec 2020 12:58:00 +1300 From: Chris Packham To: Andrew Lunn , Aryan Srivastava Subject: Re: [PATCH v2] ARM: dts: mvebu: Add device tree for ATL-x530 Board Thread-Topic: [PATCH v2] ARM: dts: mvebu: Add device tree for ATL-x530 Board Thread-Index: AQHWx2kQGCxRd6BcVkCfnQc+UL0F2qngcWyAgAAPFoA= Date: Mon, 30 Nov 2020 23:57:59 +0000 Message-ID: <3570cb6d-44e0-3ab5-b464-a013ba1007b1@alliedtelesis.co.nz> References: <20201130223507.23571-1-aryan.srivastava@alliedtelesis.co.nz> <20201130230359.GH2073444@lunn.ch> In-Reply-To: <20201130230359.GH2073444@lunn.ch> Accept-Language: en-NZ, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.32.1.11] Content-ID: <9A2F605EC80A4247AC07776013CA51C5@atlnz.lc> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_185814_779807_69630D00 X-CRM114-Status: GOOD ( 33.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "gregory.clement@bootlin.com" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "sebastian.hesselbarth@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/12/20 12:03 pm, Andrew Lunn wrote: > On Tue, Dec 01, 2020 at 11:35:07AM +1300, Aryan Srivastava wrote: >> Add device tree file for x530 board. This has an Armada 385 SoC. Has >> NAND-flash for user storage and SPI for booting. Covers majority of x530 >> and GS980MX variants. > Hi Aryan > > What exactly does that mean, it covers most variants? We were trying to avoid the patch submission becoming marketing spam and have probably been a little too vague. Between the x530, x530L and GS980MX there are 24 different models. The differences between them are in the type and number of switch ASICs, the number of PSUs and whether PoE is supported. But the CPU block is largely the same between models. > I'm just wondering if this should be a .dtsi file, and then each > variant has a .dts file specific to it? This is what we've done in our kernel fork. But for upstreaming we wanted to start slow and maybe move things into one or more common .dtsi files if/when needed (in particular there are some models in development now that use different i2c mux and hwmon chips). > Or is the hardware itself the > same, and only the software varies between the variants? Kind of both. This patch submission basically represents the common items among all the (currently shipping) variants. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel