From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGLUj-0008Of-Hh for qemu-devel@nongnu.org; Thu, 01 Jun 2017 04:30:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGLUf-0001NG-G4 for qemu-devel@nongnu.org; Thu, 01 Jun 2017 04:30:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42006) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dGLUf-0001LU-AS for qemu-devel@nongnu.org; Thu, 01 Jun 2017 04:30:09 -0400 References: <20170524220827.21154-1-rth@twiddle.net> <20170524220827.21154-2-rth@twiddle.net> From: David Hildenbrand Message-ID: <357e5120-7da0-283d-b2ec-4619550a473a@redhat.com> Date: Thu, 1 Jun 2017 10:30:05 +0200 MIME-Version: 1.0 In-Reply-To: <20170524220827.21154-2-rth@twiddle.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] target/s390x: Save current ilen during translation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: thuth@redhat.com, aurelien@aurel32.net On 25.05.2017 00:08, Richard Henderson wrote: > Use this saved value instead of recomputing from next_pc difference. > > Signed-off-by: Richard Henderson > --- > target/s390x/translate.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/target/s390x/translate.c b/target/s390x/translate.c > index 4bd16d9..5b8333f 100644 > --- a/target/s390x/translate.c > +++ b/target/s390x/translate.c > @@ -58,6 +58,7 @@ struct DisasContext { > const DisasInsn *insn; > DisasFields *fields; > uint64_t pc, next_pc; > + uint32_t ilen; > enum cc_op cc_op; > bool singlestep_enabled; > }; > @@ -349,7 +350,7 @@ static void gen_program_exception(DisasContext *s, int code) > tcg_gen_st_i32(tmp, cpu_env, offsetof(CPUS390XState, int_pgm_code)); > tcg_temp_free_i32(tmp); > > - tmp = tcg_const_i32(s->next_pc - s->pc); > + tmp = tcg_const_i32(s->ilen); > tcg_gen_st_i32(tmp, cpu_env, offsetof(CPUS390XState, int_pgm_ilen)); > tcg_temp_free_i32(tmp); > > @@ -2207,7 +2208,7 @@ static ExitStatus op_ex(DisasContext *s, DisasOps *o) > v1 = regs[r1]; > } > > - ilen = tcg_const_i32(s->next_pc - s->pc); > + ilen = tcg_const_i32(s->ilen); > gen_helper_ex(cpu_env, ilen, v1, o->in2); > tcg_temp_free_i32(ilen); > > @@ -4052,7 +4053,7 @@ static ExitStatus op_svc(DisasContext *s, DisasOps *o) > tcg_gen_st_i32(t, cpu_env, offsetof(CPUS390XState, int_svc_code)); > tcg_temp_free_i32(t); > > - t = tcg_const_i32(s->next_pc - s->pc); > + t = tcg_const_i32(s->ilen); > tcg_gen_st_i32(t, cpu_env, offsetof(CPUS390XState, int_svc_ilen)); > tcg_temp_free_i32(t); > > @@ -5191,6 +5192,7 @@ static const DisasInsn *extract_insn(CPUS390XState *env, DisasContext *s, > op = (insn >> 8) & 0xff; > ilen = get_ilen(op); > s->next_pc = s->pc + ilen; > + s->ilen = ilen; > > switch (ilen) { > case 2: > Reviewed-by: David Hildenbrand -- Thanks, David