From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751365AbdAOP2U (ORCPT ); Sun, 15 Jan 2017 10:28:20 -0500 Received: from mout.web.de ([212.227.15.4]:58557 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751129AbdAOP2S (ORCPT ); Sun, 15 Jan 2017 10:28:18 -0500 Subject: [PATCH 28/46] selinux: Return directly after a failed kzalloc() in user_read() To: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , Paul Moore , "Serge E. Hallyn" , Stephen Smalley , William Roberts References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <3582dff5-b96a-dde7-2d1c-bca7ab4aeb0e@users.sourceforge.net> Date: Sun, 15 Jan 2017 16:28:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:wTmuqJEi/tmbIoJ01W1f0A0kNpHgyLb3zsic4qWeX8hXOmQYeAe 8yNMRCXUlBvsDJt5a3KiCUpDCXSxOTzDKvTUfkr0xtHVyBedvMbyEJmK0JvtjzBUDTzfuls PDSWLDdXdn9yUo8qb25aBFXPT30cO1jOPJM+ULThzF4E3KQJYQLWp77UjcXPDq/Y9cdsek+ DEC5iAuh1GnYLhiPPfUEw== X-UI-Out-Filterresults: notjunk:1;V01:K0:w4mEGAgYef8=:lS7ov1QO+rbB9GOqAePWri Oxfw1RSiB8wOOdu3PY3m2fV2rTJGi2imb3+ZOmpFODGK7UhrzaSv2JTUjRh/DfhF7Epm3qrtL 3kc1XUUiJE+j6LK2bF56yOO674Ou5huBYznoz2gk4vUgFw1h0P+rb3DqfdyhfWYWurVw/Ka8Q m+1DJOd7WHGPkbrWuNnkwo3CUPv+MkDIq+1RBAvqgoOl9WUlqSEq30Ks1vPP4zBr09tNLAhC5 n/l2r+VytAfAiijH6w+IIzIBK0soSc+J3zqIVFRPYgNgMEpG4fLgv3/0jc/OyJvi1H39oGYkB 5QDX9HjqXfYRY5AEJEpBmf/C0jop1l/JPUP0B0v1BvwkPt0kmwh/Naa3AGZwTndBuITtX8xrH kQJMuBJcj1x4ImHDlE17yyc5sjVkB1ngTejUybMvfaN2qg59P/ctoMa7jbf1nzPAEcHvaJN5B R2wKCdU9q9I6/dygKO/7m1eHVK4rDBRakky0bXWJz1AcITOavT6E/8egzjmV/+j/FGKCGkwNe G8qdTyfDdcB7yvXnEKwUCCP1/iVsl63I8aV+WEgHvGohzkt0EYwSPNTs5tblNeX4RHdaRK7A2 dD4nUmBhIzPpGBZnwM8z2OGrmM4YP5f4W6J70ncIw8hGvNalfkY/pPwjOTacd/y7/2iwaOB+f DjIqEgGKoAxyiz7v0tkxHyY4+gBlx4srRyLB/lRQYFW55wCNdJtynwxmv+o1oGmiqubKArGG5 u2ldHiFWUe7+pZOn2hxijMlSgC4AaYFnEkZMr/xx0I+FtdwyWv1/D67/6VHY2UZeQzaDf3ZQv ZjguXFf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 14 Jan 2017 22:08:22 +0100 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- security/selinux/ss/policydb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c index 3e43556e67b8..1c046d39e2a7 100644 --- a/security/selinux/ss/policydb.c +++ b/security/selinux/ss/policydb.c @@ -1542,10 +1542,9 @@ static int user_read(struct policydb *p, struct hashtab *h, void *fp) __le32 buf[3]; u32 len; - rc = -ENOMEM; usrdatum = kzalloc(sizeof(*usrdatum), GFP_KERNEL); if (!usrdatum) - goto bad; + return -ENOMEM; if (p->policyvers >= POLICYDB_VERSION_BOUNDARY) to_read = 3; -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 15 Jan 2017 15:28:03 +0000 Subject: [PATCH 28/46] selinux: Return directly after a failed kzalloc() in user_read() Message-Id: <3582dff5-b96a-dde7-2d1c-bca7ab4aeb0e@users.sourceforge.net> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , Paul Moore , "Serge E. Hallyn" , Stephen Smalley , William Roberts Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Sat, 14 Jan 2017 22:08:22 +0100 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- security/selinux/ss/policydb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c index 3e43556e67b8..1c046d39e2a7 100644 --- a/security/selinux/ss/policydb.c +++ b/security/selinux/ss/policydb.c @@ -1542,10 +1542,9 @@ static int user_read(struct policydb *p, struct hashtab *h, void *fp) __le32 buf[3]; u32 len; - rc = -ENOMEM; usrdatum = kzalloc(sizeof(*usrdatum), GFP_KERNEL); if (!usrdatum) - goto bad; + return -ENOMEM; if (p->policyvers >= POLICYDB_VERSION_BOUNDARY) to_read = 3; -- 2.11.0