All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: dev@dpdk.org, rasland@nvidia.com, matan@nvidia.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx queues creation type check for scheduling
Date: Thu, 29 Jul 2021 19:39:22 +0200	[thread overview]
Message-ID: <3586973.7bhWBlh76Z@thomas> (raw)
In-Reply-To: <20210729122643.24865-1-viacheslavo@nvidia.com>

29/07/2021 14:26, Viacheslav Ovsiienko:
> +	if (config->tx_pp &&
> +	    (priv->config.dv_esw_en ||
> +	     priv->obj_ops.txq_obj_new != mlx5_os_txq_obj_new)) {
> +		/*
> +		 * HAVE_MLX5DV_DEVX_UAR_OFFSET is required to support
> +		 * packet pacing and already checked above. Hence, we should
> +		 * only make sure the SQs will be created with DevX, not with
> +		 * Verbs. Verbs allocates the SQ UAR on its own and it can't
> +		 * be shared with Clock Queue UAR as it required for the
> +		 * Tx scheduling feature.
> +		 */
> +		DRV_LOG(ERR, "Verbs SQs, UAR can't be shared"
> +			     " as required for packet pacing");

Don't split logs.

> +			err = ENODEV;
> +			goto error;
> +		err = ENODEV;
> +		goto error;

I assume only the last 2 lines should be kept.




      parent reply	other threads:[~2021-07-29 17:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 12:26 [dpdk-dev] [PATCH] net/mlx5: fix Tx queues creation type check for scheduling Viacheslav Ovsiienko
2021-07-29 15:16 ` Raslan Darawsheh
2021-07-29 17:39 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3586973.7bhWBlh76Z@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.