From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] mk: fix make defconfig on FreeBSD Date: Mon, 23 Apr 2018 22:56:27 +0200 Message-ID: <3587843.k4HvfGJhFO@xps> References: <20180410150804.8774-1-david.hunt@intel.com> <20180423130902.183473-1-david.hunt@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, anatoly.burakov@intel.com To: David Hunt Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 378F7255 for ; Mon, 23 Apr 2018 22:56:30 +0200 (CEST) In-Reply-To: <20180423130902.183473-1-david.hunt@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/04/2018 15:09, David Hunt: > On FreeBSD, make defconfig generates the config as > "defconfig_x86_64-bsdapp-", which does not resolve to any known > config file. > > On FreeBSD, we get amd64 out of "uname -m", which was not handled by > the list of checks, but which now resolves to x86_64-native. > > Then we run '$CC --version', and use grep -o with the list of known > compilers, and set to either gcc, icc or clang. Grep's '-o' option > returns the matched word rather than the whole line, making the > result easier to use. > > The remaining code in the patch then takes ${compiler}, the "uname -m" > output and assembles them all together into a valid freebsd config name, > i.e. "defconfig_x86_64-native-bsdapp-clang". > > v3 fixes: > Removed the call to $CC outside of the defconfig rule. > No longer breaks the 'make -R showversion'. > Simplified working out the compiler name using grep -o. > > Fixes: bce6c42c4ad5 ("mk: add sensible default target with defconfig") > > Tested-by: Anatoly Burakov > Signed-off-by: David Hunt Applied, thanks