* [PATCH] cpufreq: Don't update new_policy on failures
@ 2019-01-07 6:58 Viresh Kumar
2019-01-16 11:57 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Viresh Kumar @ 2019-01-07 6:58 UTC (permalink / raw)
To: Rafael Wysocki; +Cc: Viresh Kumar, linux-pm, Vincent Guittot, linux-kernel
The local variable "new_policy" isn't getting used in the error path
since the commit f9f41e3ef99a ("cpufreq: Remove policy create/remove
notifiers"). Don't update it in error path.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/cpufreq.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 7aa3dcad2175..9a5f82ef40e8 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1305,8 +1305,6 @@ static int cpufreq_online(unsigned int cpu)
if (ret) {
pr_err("%s: Failed to initialize policy for cpu: %d (%d)\n",
__func__, cpu, ret);
- /* cpufreq_policy_free() will notify based on this */
- new_policy = false;
goto out_destroy_policy;
}
--
2.19.1.568.g152ad8e3369a
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq: Don't update new_policy on failures
2019-01-07 6:58 [PATCH] cpufreq: Don't update new_policy on failures Viresh Kumar
@ 2019-01-16 11:57 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2019-01-16 11:57 UTC (permalink / raw)
To: Viresh Kumar; +Cc: linux-pm, Vincent Guittot, linux-kernel
On Monday, January 7, 2019 7:58:54 AM CET Viresh Kumar wrote:
> The local variable "new_policy" isn't getting used in the error path
> since the commit f9f41e3ef99a ("cpufreq: Remove policy create/remove
> notifiers"). Don't update it in error path.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/cpufreq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 7aa3dcad2175..9a5f82ef40e8 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1305,8 +1305,6 @@ static int cpufreq_online(unsigned int cpu)
> if (ret) {
> pr_err("%s: Failed to initialize policy for cpu: %d (%d)\n",
> __func__, cpu, ret);
> - /* cpufreq_policy_free() will notify based on this */
> - new_policy = false;
> goto out_destroy_policy;
> }
>
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-16 11:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-07 6:58 [PATCH] cpufreq: Don't update new_policy on failures Viresh Kumar
2019-01-16 11:57 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.