All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tedd Ho-Jeong An <tedd.an@linux.intel.com>
To: Inga Stotland <inga.stotland@intel.com>, linux-bluetooth@vger.kernel.org
Cc: luiz.dentz@gmail.com
Subject: Re: [PATCH BlueZ 1/2] tools/mgmt-tester: Adjust test setup complete check
Date: Thu, 03 Jun 2021 12:38:42 -0700	[thread overview]
Message-ID: <358e08e9ef4c4e9a0cf21dcf02dda74755384b76.camel@linux.intel.com> (raw)
In-Reply-To: <20210603000416.171392-1-inga.stotland@intel.com>

Hi Inga,

On Wed, 2021-06-02 at 17:04 -0700, Inga Stotland wrote:
> This changes check for setup complete in client_cmd_complete() callback
> from tester_setup_complete() to test_setup_condition_complete(). This
> allows for combining setup conditions when setup_bthost() is called.

Reviewed-by: Tedd Ho-Jeong An <tedd.an@intel.com>

> ---
>  tools/mgmt-tester.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
> index 4dd3490c2..657b7aaa0 100644
> --- a/tools/mgmt-tester.c
> +++ b/tools/mgmt-tester.c
> @@ -5831,7 +5831,7 @@ static void client_cmd_complete(uint16_t opcode, uint8_t status,
>  	if (status)
>  		tester_setup_failed();
>  	else
> -		tester_setup_complete();
> +		test_setup_condition_complete(data);
>  }
>  
>  static void setup_bthost(void)
> @@ -5842,6 +5842,7 @@ static void setup_bthost(void)
>  
>  	bthost = hciemu_client_get_host(data->hciemu);
>  	bthost_set_cmd_complete_cb(bthost, client_cmd_complete, data);
> +	test_add_setup_condition(data);
>  
>  	if (data->hciemu_type == HCIEMU_TYPE_LE ||
>  		test->client_enable_adv) {

Regards,
Tedd


  parent reply	other threads:[~2021-06-03 19:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  0:04 [PATCH BlueZ 1/2] tools/mgmt-tester: Adjust test setup complete check Inga Stotland
2021-06-03  0:04 ` [PATCH BlueZ 2/2] tools/mgmt-tester: Add setup condition to resolve list Inga Stotland
2021-06-03  0:50 ` [BlueZ,1/2] tools/mgmt-tester: Adjust test setup complete check bluez.test.bot
2021-06-03 19:38 ` Tedd Ho-Jeong An [this message]
2021-06-03 20:18   ` [PATCH BlueZ 1/2] " Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=358e08e9ef4c4e9a0cf21dcf02dda74755384b76.camel@linux.intel.com \
    --to=tedd.an@linux.intel.com \
    --cc=inga.stotland@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.