From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934241AbeBURyB (ORCPT ); Wed, 21 Feb 2018 12:54:01 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:41141 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938322AbeBURx5 (ORCPT ); Wed, 21 Feb 2018 12:53:57 -0500 X-Google-Smtp-Source: AH8x2260YtlrUKSqMky1CTDw9964tcFN260sgZlB6Ij0QLAq4FP4VO5uaGhac5AdNxyz+ivRrIKgiw== Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node From: Sergei Shtylyov To: Simon Horman Cc: jacopo mondi , Jacopo Mondi , geert@linux-m68k.org, magnus.damm@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1519139541-18783-1-git-send-email-jacopo+renesas@jmondi.org> <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> <20180221100716.GF7203@w540> <20180221173106.vgyshbz3kkc4p3cu@verge.net.au> <321c6c8c-8853-ac00-7567-c0be82b510f4@cogentembedded.com> Organization: Cogent Embedded Message-ID: <35959135-cb3b-040a-1944-26845e0c07b0@cogentembedded.com> Date: Wed, 21 Feb 2018 20:53:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <321c6c8c-8853-ac00-7567-c0be82b510f4@cogentembedded.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/2018 08:38 PM, Sergei Shtylyov wrote: >>>>>> Populate the ethernet@e6800000 device node to enable Ethernet interface >>>>>> for R-Car M3-N (r8a77965) SoC. >>>>>> >>>>>> Signed-off-by: Jacopo Mondi >>>>>> Reviewed-by: Geert Uytterhoeven >>>>>> >>>>>> --- >>>>>> v1 -> v2: >>>>>> - Replace ALWAYS_ON power area identifier with numeric constant >>>>>> --- >>>>>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 ++++++++++++++++++++++++++++++- >>>>>> 1 file changed, 42 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>>> index 55f05f7..c249895 100644 >>>>>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>>> @@ -520,7 +520,48 @@ >>>>>> }; >>>>>> >>>>>> avb: ethernet@e6800000 { >>>>>> - /* placeholder */ >>>>>> + compatible = "renesas,etheravb-r8a77965", >>>>>> + "renesas,etheravb-rcar-gen3"; >>>>>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; >>>>>> + interrupts = , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + ; >>>>>> + interrupt-names = "ch0", "ch1", "ch2", "ch3", >>>>>> + "ch4", "ch5", "ch6", "ch7", >>>>>> + "ch8", "ch9", "ch10", "ch11", >>>>>> + "ch12", "ch13", "ch14", "ch15", >>>>>> + "ch16", "ch17", "ch18", "ch19", >>>>>> + "ch20", "ch21", "ch22", "ch23", >>>>>> + "ch24"; >>>>>> + clocks = <&cpg CPG_MOD 812>; >>>>>> + power-domains = <&sysc 32>; >>>>>> + resets = <&cpg 812>; >>>>>> + phy-mode = "rgmii-txid"; >>>>> >>>>> Why not just "rgmii"? TX delay is a board specific detail, no? >>>>> >>>> I admit I took this one straight from r8a7796 dtsi. >>>> Would you like to me resend and change this? >>> >>> Yes, unless Simon would fix it while merging... >> >> Can I confirm the desired change is s/rgmii-txid/rgmii/ ? > > Yes. Apparently that means that this prop should be overridden in the board file (which may not be an easy task given the board is Salvator-XS again). [...] MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node Date: Wed, 21 Feb 2018 20:53:53 +0300 Message-ID: <35959135-cb3b-040a-1944-26845e0c07b0@cogentembedded.com> References: <1519139541-18783-1-git-send-email-jacopo+renesas@jmondi.org> <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> <20180221100716.GF7203@w540> <20180221173106.vgyshbz3kkc4p3cu@verge.net.au> <321c6c8c-8853-ac00-7567-c0be82b510f4@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <321c6c8c-8853-ac00-7567-c0be82b510f4@cogentembedded.com> Content-Language: en-MW List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Simon Horman Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, jacopo mondi , magnus.damm@gmail.com, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, geert@linux-m68k.org, Jacopo Mondi , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 02/21/2018 08:38 PM, Sergei Shtylyov wrote: >>>>>> Populate the ethernet@e6800000 device node to enable Ethernet interface >>>>>> for R-Car M3-N (r8a77965) SoC. >>>>>> >>>>>> Signed-off-by: Jacopo Mondi >>>>>> Reviewed-by: Geert Uytterhoeven >>>>>> >>>>>> --- >>>>>> v1 -> v2: >>>>>> - Replace ALWAYS_ON power area identifier with numeric constant >>>>>> --- >>>>>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 ++++++++++++++++++++++++++++++- >>>>>> 1 file changed, 42 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>>> index 55f05f7..c249895 100644 >>>>>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>>> @@ -520,7 +520,48 @@ >>>>>> }; >>>>>> >>>>>> avb: ethernet@e6800000 { >>>>>> - /* placeholder */ >>>>>> + compatible = "renesas,etheravb-r8a77965", >>>>>> + "renesas,etheravb-rcar-gen3"; >>>>>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; >>>>>> + interrupts = , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + ; >>>>>> + interrupt-names = "ch0", "ch1", "ch2", "ch3", >>>>>> + "ch4", "ch5", "ch6", "ch7", >>>>>> + "ch8", "ch9", "ch10", "ch11", >>>>>> + "ch12", "ch13", "ch14", "ch15", >>>>>> + "ch16", "ch17", "ch18", "ch19", >>>>>> + "ch20", "ch21", "ch22", "ch23", >>>>>> + "ch24"; >>>>>> + clocks = <&cpg CPG_MOD 812>; >>>>>> + power-domains = <&sysc 32>; >>>>>> + resets = <&cpg 812>; >>>>>> + phy-mode = "rgmii-txid"; >>>>> >>>>> Why not just "rgmii"? TX delay is a board specific detail, no? >>>>> >>>> I admit I took this one straight from r8a7796 dtsi. >>>> Would you like to me resend and change this? >>> >>> Yes, unless Simon would fix it while merging... >> >> Can I confirm the desired change is s/rgmii-txid/rgmii/ ? > > Yes. Apparently that means that this prop should be overridden in the board file (which may not be an easy task given the board is Salvator-XS again). [...] MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Wed, 21 Feb 2018 20:53:53 +0300 Subject: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node In-Reply-To: <321c6c8c-8853-ac00-7567-c0be82b510f4@cogentembedded.com> References: <1519139541-18783-1-git-send-email-jacopo+renesas@jmondi.org> <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> <20180221100716.GF7203@w540> <20180221173106.vgyshbz3kkc4p3cu@verge.net.au> <321c6c8c-8853-ac00-7567-c0be82b510f4@cogentembedded.com> Message-ID: <35959135-cb3b-040a-1944-26845e0c07b0@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/21/2018 08:38 PM, Sergei Shtylyov wrote: >>>>>> Populate the ethernet at e6800000 device node to enable Ethernet interface >>>>>> for R-Car M3-N (r8a77965) SoC. >>>>>> >>>>>> Signed-off-by: Jacopo Mondi >>>>>> Reviewed-by: Geert Uytterhoeven >>>>>> >>>>>> --- >>>>>> v1 -> v2: >>>>>> - Replace ALWAYS_ON power area identifier with numeric constant >>>>>> --- >>>>>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 ++++++++++++++++++++++++++++++- >>>>>> 1 file changed, 42 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>>> index 55f05f7..c249895 100644 >>>>>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>>> @@ -520,7 +520,48 @@ >>>>>> }; >>>>>> >>>>>> avb: ethernet at e6800000 { >>>>>> - /* placeholder */ >>>>>> + compatible = "renesas,etheravb-r8a77965", >>>>>> + "renesas,etheravb-rcar-gen3"; >>>>>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; >>>>>> + interrupts = , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + , >>>>>> + ; >>>>>> + interrupt-names = "ch0", "ch1", "ch2", "ch3", >>>>>> + "ch4", "ch5", "ch6", "ch7", >>>>>> + "ch8", "ch9", "ch10", "ch11", >>>>>> + "ch12", "ch13", "ch14", "ch15", >>>>>> + "ch16", "ch17", "ch18", "ch19", >>>>>> + "ch20", "ch21", "ch22", "ch23", >>>>>> + "ch24"; >>>>>> + clocks = <&cpg CPG_MOD 812>; >>>>>> + power-domains = <&sysc 32>; >>>>>> + resets = <&cpg 812>; >>>>>> + phy-mode = "rgmii-txid"; >>>>> >>>>> Why not just "rgmii"? TX delay is a board specific detail, no? >>>>> >>>> I admit I took this one straight from r8a7796 dtsi. >>>> Would you like to me resend and change this? >>> >>> Yes, unless Simon would fix it while merging... >> >> Can I confirm the desired change is s/rgmii-txid/rgmii/ ? > > Yes. Apparently that means that this prop should be overridden in the board file (which may not be an easy task given the board is Salvator-XS again). [...] MBR, Sergei