From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933094AbcIULcj (ORCPT ); Wed, 21 Sep 2016 07:32:39 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:49876 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932289AbcIULch (ORCPT ); Wed, 21 Sep 2016 07:32:37 -0400 From: Arnd Bergmann To: Sriram Dash Cc: Felipe Balbi , Peter Chen , Leo Li , Grygorii Strashko , Russell King - ARM Linux , Catalin Marinas , Yoshihiro Shimoda , "linux-usb@vger.kernel.org" , Sekhar Nori , lkml , Stuart Yoder , Scott Wood , David Fisher , "Thang Q. Nguyen" , Alan Stern , Greg Kroah-Hartman , "linux-arm-kernel@lists.infradead.org" , Suresh Gupta Subject: Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Date: Wed, 21 Sep 2016 13:31:38 +0200 Message-ID: <3596831.dckG5peiyF@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <3189648.KnWLgq0lTY@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:PTLHLt5YAGG/jtuhe+Np1uWvzOtfpZjry9WlJgUTFf2Kvu/DIM9 KKMszZHdFG5intrVgC973ZDSJNdhg5h0A4cFCxr6xtPSmudtI7QXZaQ4Ul17G5XbCZ2MlCW ZYkgviNKZyjLPaH99mEW2dTw6xq8Ajxhkg4bnB6QiclBraDPS8t2Lqstb7Pb8h9jFfFFsix tYXIG0LqzgaI6K5MBdGvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:NgUGwLVew/o=:Fy4kBfUPDVWBzTeJ5Mh8bj j+FbqxsQ49L3TGqqeIVlxJanbH/39ykxLEnNQOXm91/elY24KDfY6tMiuL2TS2uO+e3YEx34R 1Vpe2NX8M7CqkYK0khy+9BWAcb4wk1llChV6U4iNz9FUr6kolTnwJJEb7EqIaCw0c6hq6JQdK sT2trfC4zKdpwxZ8AA3qkmttTKpnga7YxCSw+QHgMVFEJrIU+vOz2vHBr+u3zouGPd/v9VlFm V4qXFbf0AHzttJPoB6MHGSYDMGdttFDG1ZPZwPpE8uIW6auYfprmXCtsKBc1jDGGV+TCT5jsH LwX2mJAXbITljVrEarPIkRiqYVfRkj/WjxXXaaVlqv2Bn+4n8MwSYyBWWvVA5xbIzOcXNpoVW e7VTAReu7spqjNASIRY44cJ4RCT6xSm5X4+Fp+9uqrGsHv5oBj2lR6fK5LZHqnUuIp14cB2EB 27X6YiQagqFxVQpId7h9kptuRqH4Dto7ZiUJtbZ48YNUb1Ewc/peoQku4grSGu0R8amVejp5v Q/W4gARxTGXRTB6Fs9PI1pNGwUt+zJiFPX3Ema5/rQSiLAjdqvB10UxjOYpoAr0yyvcCFz+WT nVdsAkAq8IMU6p1SMUZcw03TBJ+0XFdSaPsXKvun2Vy4pRWPNlgpQ81wKqmMuC2dv+KKE016j ThKNjrR4HUYdr/ESOAHRzoZbmNkFyu7VCjVu9jb7z8D/9O8H+cATWPIGV+05LA0jPqzXMnRb4 ZqgqnDvU3PzfhW+B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 21, 2016 11:06:47 AM CEST Sriram Dash wrote: > > Hello Arnd, > > We tried this patch on NXP platforms (ls2085 and ls1043) which use dwc3 > controller without any glue layer. On first go, this did not work. But after > minimal reworks mention snippet below, we are able to verify that the USB > was working OK. > > drivers/usb/host/xhci-mem.c | 12 ++++++------ > drivers/usb/host/xhci.c | 20 ++++++++++---------- > > - struct device *dev = xhci_to_hcd(xhci)->self.controller; > + struct device *dev = xhci_to_hcd(xhci)->self.sysdev; > > We believe the patch needs little modification to work or there might be chances > we may have missed something. Any idea? I had not tried the patch, it was just sent for clarification what I meant, so I'm glad you got it working with just minimal changes. Unfortunately, I can't tell from your lines above what exactly you changed, can you send that again as a proper patch? I think I also had some minimal changes that I did myself in order to fix a build regression I introduced. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 21 Sep 2016 13:31:38 +0200 Subject: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev In-Reply-To: References: <3189648.KnWLgq0lTY@wuerfel> Message-ID: <3596831.dckG5peiyF@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday, September 21, 2016 11:06:47 AM CEST Sriram Dash wrote: > > Hello Arnd, > > We tried this patch on NXP platforms (ls2085 and ls1043) which use dwc3 > controller without any glue layer. On first go, this did not work. But after > minimal reworks mention snippet below, we are able to verify that the USB > was working OK. > > drivers/usb/host/xhci-mem.c | 12 ++++++------ > drivers/usb/host/xhci.c | 20 ++++++++++---------- > > - struct device *dev = xhci_to_hcd(xhci)->self.controller; > + struct device *dev = xhci_to_hcd(xhci)->self.sysdev; > > We believe the patch needs little modification to work or there might be chances > we may have missed something. Any idea? I had not tried the patch, it was just sent for clarification what I meant, so I'm glad you got it working with just minimal changes. Unfortunately, I can't tell from your lines above what exactly you changed, can you send that again as a proper patch? I think I also had some minimal changes that I did myself in order to fix a build regression I introduced. Arnd