From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E0CC433E2 for ; Wed, 27 May 2020 08:42:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFE932089D for ; Wed, 27 May 2020 08:42:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oJxUyzIV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388179AbgE0Im0 (ORCPT ); Wed, 27 May 2020 04:42:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388161AbgE0ImZ (ORCPT ); Wed, 27 May 2020 04:42:25 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6411BC03E97C for ; Wed, 27 May 2020 01:42:25 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id 82so13987339lfh.2 for ; Wed, 27 May 2020 01:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0cVbaBKHPFRHFgLj7eTRo1bAadVyagSGQGQWcN/OrRE=; b=oJxUyzIVgZq7u4vhV2WTxYtWXGyQmwh7FnwZ8aW0G3ACHvkdtdA5Vg8o7/V1sOarON yNJdUef2IB0O73wQevzC4PCIMlKH3IWiY6zcax+lX2CmWdkv8j2+pjwlJkLtYIpsWFgp SuQ5IhYNHlfCZxc8AijCOMtBvTka3/7rbhfY3Nc6zRHthYsIW9Ia5YXmDFUO15q7K9hn gv0TJ0vBP1RCF2fErFoKvNPuVJOLNxLkd0zU42psapjDni5JhYPlHuSrQgTT1TsaksnW bLzX4DiKNHL6Hr18kFZRWSRt4TTWKotEOD6xkTw9O+WJMFFWo3KHfgwwU34C3KRgL8N2 oZ1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0cVbaBKHPFRHFgLj7eTRo1bAadVyagSGQGQWcN/OrRE=; b=hk1j+r/qnQKmfKORuyPHtFycbIkNAhIOQRB7LJ/Sh3IJNdgE8WmC9sSjfEkv2wjv3W pDoJJwdxrHaBXApaAkkGvK5EE2v2twOQyprkYC/Nv6fpoq/hq+jfw1MwS08CZ4wFrcFT 3sZhtuB21+WvSNfqHuj+TlmhpYj6u+HodGDX6xOIZ8wPfxmd/0grOIziy6wDkNhsHVHD I1wbFMMl2Bz/KsUmcsG8vYG9UZF8rbaRZ/+dYvSuATum30DTv8Y3xEhSVK8odwDPc8lz 6AHBMXObKH3W9KVwPQwDTWEL0himl5ebDYvec5Q1ZGMKYDRJpVNllHhMbFZY4SQXaGP6 IR5w== X-Gm-Message-State: AOAM530vGQ3Itkw2aazuPDPFnkdqvZVDTyRECTU7ulnLesnR5LakCYqH iIHkWgp5JyI4CvPgsHViCW9z+nAF5QZM0w== X-Google-Smtp-Source: ABdhPJyNlPGUsdKFIc4nPUUBfYBG9iP9HgT7+hNyJKOoA+mEZpSqes4qfc2yvtAB8gm2VZvscTPBfw== X-Received: by 2002:a19:550e:: with SMTP id n14mr2628879lfe.81.1590568943796; Wed, 27 May 2020 01:42:23 -0700 (PDT) Received: from [192.168.118.216] (37-144-159-139.broadband.corbina.ru. [37.144.159.139]) by smtp.gmail.com with ESMTPSA id f2sm543541ljf.113.2020.05.27.01.42.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2020 01:42:23 -0700 (PDT) Subject: Re: [PATCH v3 07/10] media: i2c: imx290: Add RAW12 mode support To: Dave Stevenson Cc: Mauro Carvalho Chehab , Sakari Ailus , manivannan.sadhasivam@linaro.org, Linux Media Mailing List , LKML , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com, Peter Griffin References: <20200524192505.20682-1-andrey.konovalov@linaro.org> <20200524192505.20682-8-andrey.konovalov@linaro.org> From: Andrey Konovalov Message-ID: <3597b850-5ce6-0e88-8f1f-e16bad5f75ef@linaro.org> Date: Wed, 27 May 2020 11:42:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave, On 26.05.2020 19:05, Dave Stevenson wrote: > Hi Andrey > > Thanks for the patch. > > On Sun, 24 May 2020 at 20:26, Andrey Konovalov > wrote: >> >> From: Manivannan Sadhasivam >> >> IMX290 is capable of outputting frames in both Raw Bayer (packed) 10 and >> 12 bit formats. Since the driver already supports RAW10 mode, let's add >> the missing RAW12 mode as well. >> >> Signed-off-by: Manivannan Sadhasivam >> Signed-off-by: Andrey Konovalov >> --- >> drivers/media/i2c/imx290.c | 36 +++++++++++++++++++++++++++++++++--- >> 1 file changed, 33 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c >> index 162c345fffac..6e70ff22bc5f 100644 >> --- a/drivers/media/i2c/imx290.c >> +++ b/drivers/media/i2c/imx290.c >> @@ -71,6 +71,7 @@ struct imx290 { >> struct clk *xclk; >> struct regmap *regmap; >> u8 nlanes; >> + u8 bpp; >> >> struct v4l2_subdev sd; >> struct v4l2_fwnode_endpoint ep; >> @@ -90,10 +91,12 @@ struct imx290 { >> >> struct imx290_pixfmt { >> u32 code; >> + u8 bpp; >> }; >> >> static const struct imx290_pixfmt imx290_formats[] = { >> - { MEDIA_BUS_FMT_SRGGB10_1X10 }, >> + { MEDIA_BUS_FMT_SRGGB10_1X10, 10 }, >> + { MEDIA_BUS_FMT_SRGGB12_1X12, 12 }, >> }; >> >> static const struct regmap_config imx290_regmap_config = { >> @@ -261,6 +264,18 @@ static const struct imx290_regval imx290_10bit_settings[] = { >> { 0x300b, 0x00}, >> }; >> >> +static const struct imx290_regval imx290_12bit_settings[] = { >> + { 0x3005, 0x01 }, >> + { 0x3046, 0x01 }, >> + { 0x3129, 0x00 }, >> + { 0x317c, 0x00 }, >> + { 0x31ec, 0x0e }, >> + { 0x3441, 0x0c }, >> + { 0x3442, 0x0c }, >> + { 0x300a, 0xf0 }, >> + { 0x300b, 0x00 }, >> +}; >> + >> /* supported link frequencies */ >> static const s64 imx290_link_freq_2lanes[] = { >> 891000000, /* 1920x1080 - 2 lane */ >> @@ -421,7 +436,12 @@ static int imx290_set_ctrl(struct v4l2_ctrl *ctrl) >> } else { >> imx290_write_reg(imx290, IMX290_PGCTRL, 0x00); >> msleep(10); >> - imx290_write_reg(imx290, IMX290_BLKLEVEL_LOW, 0x3c); >> + if (imx290->bpp == 10) >> + imx290_write_reg(imx290, IMX290_BLKLEVEL_LOW, >> + 0x3c); >> + else /* 12 bits per pixel */ >> + imx290_write_reg(imx290, IMX290_BLKLEVEL_LOW, >> + 0xf0); >> imx290_write_reg(imx290, IMX290_BLKLEVEL_HIGH, 0x00); >> } >> break; >> @@ -496,7 +516,7 @@ static u64 imx290_calc_pixel_rate(struct imx290 *imx290) >> u8 nlanes = imx290->nlanes; >> >> /* pixel rate = link_freq * 2 * nr_of_lanes / bits_per_sample */ >> - return (link_freq * 2 * nlanes / 10); >> + return (link_freq * 2 * nlanes / imx290->bpp); > > This doesn't link on a 32bit system as it's a 64bit divide: > ERROR: "__aeabi_ldivmod" [drivers/media/i2c/imx290.ko] undefined! > It ought to be using do_div(). Nice catch, thanks! I'll fix this in the next version of the patchset. Thanks, Andrey > Admittedly it didn't compile before as you still had a s64 divide by > 10, but I hadn't tried that :-) > > Dave > >> } >> >> static int imx290_set_fmt(struct v4l2_subdev *sd, >> @@ -533,6 +553,7 @@ static int imx290_set_fmt(struct v4l2_subdev *sd, >> } else { >> format = &imx290->current_format; >> imx290->current_mode = mode; >> + imx290->bpp = imx290_formats[i].bpp; >> >> if (imx290->link_freq) >> __v4l2_ctrl_s_ctrl(imx290->link_freq, >> @@ -577,6 +598,15 @@ static int imx290_write_current_format(struct imx290 *imx290) >> return ret; >> } >> break; >> + case MEDIA_BUS_FMT_SRGGB12_1X12: >> + ret = imx290_set_register_array(imx290, imx290_12bit_settings, >> + ARRAY_SIZE( >> + imx290_12bit_settings)); >> + if (ret < 0) { >> + dev_err(imx290->dev, "Could not set format registers\n"); >> + return ret; >> + } >> + break; >> default: >> dev_err(imx290->dev, "Unknown pixel format\n"); >> return -EINVAL; >> -- >> 2.17.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0122C433E0 for ; Wed, 27 May 2020 08:43:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6759420723 for ; Wed, 27 May 2020 08:43:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ne22445F"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oJxUyzIV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6759420723 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lZax0hvZXEhVUR1NhNZBuyHyLwX2fH53qru8jMvedAY=; b=ne22445F/D6H6Ynv5zubHVlZB Js+wLHlKkPzQa1xaCS9BiJEhV4wuN4+Ra5QGp9rYrDw2s62C8szTWKW12rreqbgHLm111Nu+TSl8N QMoEcVUxTVRJHt3nJC1Yfgxl98x5O1gDkTXw5qQ/AVw+MYxckG8dSETtRfJ3fvuQJ8SgnK7n8Uk3y XBl6Qez1bK17UAQWzPYUZqUHUGIlpRoA44uEAKU+urYWjH3l1AXQZLBN0QciaAik/3IoODNKqF58A f1SyG0CWG15PfZpOva19NKZlAHVcKYaga3I1mNw2v682u/kaO+MY6N+xQHepHUmU216HPMU0sHYen M0zIWWqPg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdreo-0007pn-Pg; Wed, 27 May 2020 08:43:26 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdrdq-0006y0-Ia for linux-arm-kernel@lists.infradead.org; Wed, 27 May 2020 08:42:30 +0000 Received: by mail-lf1-x144.google.com with SMTP id c21so13986572lfb.3 for ; Wed, 27 May 2020 01:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0cVbaBKHPFRHFgLj7eTRo1bAadVyagSGQGQWcN/OrRE=; b=oJxUyzIVgZq7u4vhV2WTxYtWXGyQmwh7FnwZ8aW0G3ACHvkdtdA5Vg8o7/V1sOarON yNJdUef2IB0O73wQevzC4PCIMlKH3IWiY6zcax+lX2CmWdkv8j2+pjwlJkLtYIpsWFgp SuQ5IhYNHlfCZxc8AijCOMtBvTka3/7rbhfY3Nc6zRHthYsIW9Ia5YXmDFUO15q7K9hn gv0TJ0vBP1RCF2fErFoKvNPuVJOLNxLkd0zU42psapjDni5JhYPlHuSrQgTT1TsaksnW bLzX4DiKNHL6Hr18kFZRWSRt4TTWKotEOD6xkTw9O+WJMFFWo3KHfgwwU34C3KRgL8N2 oZ1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0cVbaBKHPFRHFgLj7eTRo1bAadVyagSGQGQWcN/OrRE=; b=l9iYBsgIpE95UWbAM3+mzNztGJYFu96OsgpFw7kR+XsDxyl229IAj2T5wX4rQvBNfG l+lCbY8UM6+QsuoLv9PicYQ+273GHY7PJSK3HdW7P2VXSaLvRhX51859sPo2yb041CSW wz7wGUpj2sYqq8U7JIuK+eT/2SG+SYMDadfVbArE4FdT1IY6R0J9T5EdsySE1ruWI19/ ivX8evMQVHyFSFsuscb/bB4Zt0lsLQ6BuyfauEi6Mj2zC9rLmdCvSbOdpZ1ymi16kisS dbzF3kA/rynoT5/3zDxjcBrsCFA04tj/SfluF4HeTJmvcg9py4cNwKTJfv5wHSyBPd+4 etGQ== X-Gm-Message-State: AOAM530ua8lptrGj6PZROaypREcwM2oLmYFnBLdly8bguNDRRePpMgx1 IEV16dyPwyklLpsuHAKAxSWQOw== X-Google-Smtp-Source: ABdhPJyNlPGUsdKFIc4nPUUBfYBG9iP9HgT7+hNyJKOoA+mEZpSqes4qfc2yvtAB8gm2VZvscTPBfw== X-Received: by 2002:a19:550e:: with SMTP id n14mr2628879lfe.81.1590568943796; Wed, 27 May 2020 01:42:23 -0700 (PDT) Received: from [192.168.118.216] (37-144-159-139.broadband.corbina.ru. [37.144.159.139]) by smtp.gmail.com with ESMTPSA id f2sm543541ljf.113.2020.05.27.01.42.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2020 01:42:23 -0700 (PDT) Subject: Re: [PATCH v3 07/10] media: i2c: imx290: Add RAW12 mode support To: Dave Stevenson References: <20200524192505.20682-1-andrey.konovalov@linaro.org> <20200524192505.20682-8-andrey.konovalov@linaro.org> From: Andrey Konovalov Message-ID: <3597b850-5ce6-0e88-8f1f-e16bad5f75ef@linaro.org> Date: Wed, 27 May 2020 11:42:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200527_014226_628811_97DAD432 X-CRM114-Status: GOOD ( 22.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, c.barrett@framos.com, LKML , a.brela@framos.com, Peter Griffin , Sakari Ailus , manivannan.sadhasivam@linaro.org, Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dave, On 26.05.2020 19:05, Dave Stevenson wrote: > Hi Andrey > > Thanks for the patch. > > On Sun, 24 May 2020 at 20:26, Andrey Konovalov > wrote: >> >> From: Manivannan Sadhasivam >> >> IMX290 is capable of outputting frames in both Raw Bayer (packed) 10 and >> 12 bit formats. Since the driver already supports RAW10 mode, let's add >> the missing RAW12 mode as well. >> >> Signed-off-by: Manivannan Sadhasivam >> Signed-off-by: Andrey Konovalov >> --- >> drivers/media/i2c/imx290.c | 36 +++++++++++++++++++++++++++++++++--- >> 1 file changed, 33 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c >> index 162c345fffac..6e70ff22bc5f 100644 >> --- a/drivers/media/i2c/imx290.c >> +++ b/drivers/media/i2c/imx290.c >> @@ -71,6 +71,7 @@ struct imx290 { >> struct clk *xclk; >> struct regmap *regmap; >> u8 nlanes; >> + u8 bpp; >> >> struct v4l2_subdev sd; >> struct v4l2_fwnode_endpoint ep; >> @@ -90,10 +91,12 @@ struct imx290 { >> >> struct imx290_pixfmt { >> u32 code; >> + u8 bpp; >> }; >> >> static const struct imx290_pixfmt imx290_formats[] = { >> - { MEDIA_BUS_FMT_SRGGB10_1X10 }, >> + { MEDIA_BUS_FMT_SRGGB10_1X10, 10 }, >> + { MEDIA_BUS_FMT_SRGGB12_1X12, 12 }, >> }; >> >> static const struct regmap_config imx290_regmap_config = { >> @@ -261,6 +264,18 @@ static const struct imx290_regval imx290_10bit_settings[] = { >> { 0x300b, 0x00}, >> }; >> >> +static const struct imx290_regval imx290_12bit_settings[] = { >> + { 0x3005, 0x01 }, >> + { 0x3046, 0x01 }, >> + { 0x3129, 0x00 }, >> + { 0x317c, 0x00 }, >> + { 0x31ec, 0x0e }, >> + { 0x3441, 0x0c }, >> + { 0x3442, 0x0c }, >> + { 0x300a, 0xf0 }, >> + { 0x300b, 0x00 }, >> +}; >> + >> /* supported link frequencies */ >> static const s64 imx290_link_freq_2lanes[] = { >> 891000000, /* 1920x1080 - 2 lane */ >> @@ -421,7 +436,12 @@ static int imx290_set_ctrl(struct v4l2_ctrl *ctrl) >> } else { >> imx290_write_reg(imx290, IMX290_PGCTRL, 0x00); >> msleep(10); >> - imx290_write_reg(imx290, IMX290_BLKLEVEL_LOW, 0x3c); >> + if (imx290->bpp == 10) >> + imx290_write_reg(imx290, IMX290_BLKLEVEL_LOW, >> + 0x3c); >> + else /* 12 bits per pixel */ >> + imx290_write_reg(imx290, IMX290_BLKLEVEL_LOW, >> + 0xf0); >> imx290_write_reg(imx290, IMX290_BLKLEVEL_HIGH, 0x00); >> } >> break; >> @@ -496,7 +516,7 @@ static u64 imx290_calc_pixel_rate(struct imx290 *imx290) >> u8 nlanes = imx290->nlanes; >> >> /* pixel rate = link_freq * 2 * nr_of_lanes / bits_per_sample */ >> - return (link_freq * 2 * nlanes / 10); >> + return (link_freq * 2 * nlanes / imx290->bpp); > > This doesn't link on a 32bit system as it's a 64bit divide: > ERROR: "__aeabi_ldivmod" [drivers/media/i2c/imx290.ko] undefined! > It ought to be using do_div(). Nice catch, thanks! I'll fix this in the next version of the patchset. Thanks, Andrey > Admittedly it didn't compile before as you still had a s64 divide by > 10, but I hadn't tried that :-) > > Dave > >> } >> >> static int imx290_set_fmt(struct v4l2_subdev *sd, >> @@ -533,6 +553,7 @@ static int imx290_set_fmt(struct v4l2_subdev *sd, >> } else { >> format = &imx290->current_format; >> imx290->current_mode = mode; >> + imx290->bpp = imx290_formats[i].bpp; >> >> if (imx290->link_freq) >> __v4l2_ctrl_s_ctrl(imx290->link_freq, >> @@ -577,6 +598,15 @@ static int imx290_write_current_format(struct imx290 *imx290) >> return ret; >> } >> break; >> + case MEDIA_BUS_FMT_SRGGB12_1X12: >> + ret = imx290_set_register_array(imx290, imx290_12bit_settings, >> + ARRAY_SIZE( >> + imx290_12bit_settings)); >> + if (ret < 0) { >> + dev_err(imx290->dev, "Could not set format registers\n"); >> + return ret; >> + } >> + break; >> default: >> dev_err(imx290->dev, "Unknown pixel format\n"); >> return -EINVAL; >> -- >> 2.17.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel