From: David Hildenbrand <david@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH RFC 2/6] qapi: use qemu_strtod() in string-input-visitor
Date: Thu, 15 Nov 2018 12:09:19 +0100 [thread overview]
Message-ID: <359e518d-ffdc-e062-c9c7-20034155051e@redhat.com> (raw)
In-Reply-To: <87r2fnod2p.fsf@dusky.pond.sub.org>
On 14.11.18 17:09, Markus Armbruster wrote:
> David Hildenbrand <david@redhat.com> writes:
>
>> Let's use the new function.
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>> qapi/string-input-visitor.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
>> index b3fdd0827d..dee708d384 100644
>> --- a/qapi/string-input-visitor.c
>> +++ b/qapi/string-input-visitor.c
>> @@ -20,6 +20,7 @@
>> #include "qemu/option.h"
>> #include "qemu/queue.h"
>> #include "qemu/range.h"
>> +#include "qemu/cutils.h"
>>
>>
>> struct StringInputVisitor
>> @@ -313,12 +314,9 @@ static void parse_type_number(Visitor *v, const char *name, double *obj,
>> Error **errp)
>> {
>> StringInputVisitor *siv = to_siv(v);
>> - char *endp = (char *) siv->string;
>> double val;
>>
>> - errno = 0;
>> - val = strtod(siv->string, &endp);
>> - if (errno || endp == siv->string || *endp) {
>> + if (qemu_strtod(siv->string, NULL, &val)) {
>> error_setg(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : "null",
>> "number");
>> return;
>
> Three more: in qobject-input-visitor.c's
> qobject_input_type_number_keyval(),
This one is interesting, as it properly bails out when parsing "inf"
(via isFinite()). - should we do the same for the string input visitor?
Especially, should we forbid "inf" and "NaN" in both scenarios?
cutil.c's do_strtosz(), and
> json-parser.c's parse_literal().
>
> The latter doesn't check for errors since the lexer ensures the input is
> sane. Overflow can still happen, and is silently ignored. Feel free
> not to convert this one.
>
I'll do the conversion of all (allowing -ERANGE where it used to be
allow), we can then discuss with the patches at hand if it makes sense.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-11-15 11:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 11:02 [Qemu-devel] [PATCH RFC 0/6] qapi: rewrite string-input-visitor David Hildenbrand
2018-11-09 11:02 ` [Qemu-devel] [PATCH RFC 1/6] cutils: add qemu_strtod() David Hildenbrand
2018-11-09 11:02 ` [Qemu-devel] [PATCH RFC 2/6] qapi: use qemu_strtod() in string-input-visitor David Hildenbrand
2018-11-14 16:09 ` Markus Armbruster
2018-11-15 11:09 ` David Hildenbrand [this message]
2018-11-15 13:17 ` Eric Blake
2018-11-15 13:54 ` David Hildenbrand
2018-11-15 14:43 ` Markus Armbruster
2018-11-09 11:02 ` [Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor David Hildenbrand
2018-11-14 17:38 ` Markus Armbruster
2018-11-14 19:56 ` David Hildenbrand
2018-11-15 9:48 ` Markus Armbruster
2018-11-15 10:16 ` David Hildenbrand
2018-11-15 14:57 ` Markus Armbruster
2018-11-09 11:02 ` [Qemu-devel] [PATCH RFC 4/6] test-string-input-visitor: use virtual walk David Hildenbrand
2018-11-09 11:02 ` [Qemu-devel] [PATCH RFC 5/6] test-string-input-visitor: split off uint64 list tests David Hildenbrand
2018-11-14 16:21 ` Markus Armbruster
2018-11-14 20:03 ` David Hildenbrand
2018-11-15 9:59 ` Markus Armbruster
2018-11-09 11:02 ` [Qemu-devel] [PATCH RFC 6/6] test-string-input-visitor: add range overflow tests David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=359e518d-ffdc-e062-c9c7-20034155051e@redhat.com \
--to=david@redhat.com \
--cc=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.