From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hemant Agrawal Subject: Re: [PATCH 13/32] net/dpaa2: add debug log macros Date: Mon, 19 Dec 2016 20:54:47 +0530 Message-ID: <35a66e1b-877d-c071-ef6f-5a9344b16e7f@nxp.com> References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1480875447-23680-14-git-send-email-hemant.agrawal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , To: Ferruh Yigit , Return-path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0067.outbound.protection.outlook.com [104.47.33.67]) by dpdk.org (Postfix) with ESMTP id A29B8FA64 for ; Mon, 19 Dec 2016 16:24:55 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/7/2016 1:19 AM, Ferruh Yigit wrote: > On 12/4/2016 6:17 PM, Hemant Agrawal wrote: >> Signed-off-by: Hemant Agrawal >> --- >> config/defconfig_arm64-dpaa2-linuxapp-gcc | 2 + >> drivers/net/dpaa2/Makefile | 5 ++ >> drivers/net/dpaa2/dpaa2_logs.h | 77 +++++++++++++++++++++++++++++++ >> 3 files changed, 84 insertions(+) >> create mode 100644 drivers/net/dpaa2/dpaa2_logs.h >> >> diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc >> index 00f207e..5ff884b 100644 >> --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc >> +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc >> @@ -45,3 +45,5 @@ CONFIG_RTE_MAX_NUMA_NODES=1 >> # Compile software PMD backed by NXP DPAA2 files >> # >> CONFIG_RTE_LIBRTE_DPAA2_PMD=y >> +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n >> +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n >> diff --git a/drivers/net/dpaa2/Makefile b/drivers/net/dpaa2/Makefile >> index ab17143..3032708 100644 >> --- a/drivers/net/dpaa2/Makefile >> +++ b/drivers/net/dpaa2/Makefile >> @@ -35,8 +35,13 @@ include $(RTE_SDK)/mk/rte.vars.mk >> # >> LIB = librte_pmd_dpaa2.a >> >> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT),y) >> +CFLAGS += -O0 -g >> +CFLAGS += "-Wno-error" >> +else >> CFLAGS += -O3 >> CFLAGS += $(WERROR_FLAGS) >> +endif >> >> CFLAGS += -I$(RTE_SDK)/drivers/net/dpaa2 >> CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/ >> diff --git a/drivers/net/dpaa2/dpaa2_logs.h b/drivers/net/dpaa2/dpaa2_logs.h >> new file mode 100644 >> index 0000000..956a940 >> --- /dev/null >> +++ b/drivers/net/dpaa2/dpaa2_logs.h >> @@ -0,0 +1,77 @@ >> +/*- >> + * BSD LICENSE >> + * >> + * Copyright (c) 2015-2016 Freescale Semiconductor, Inc. All rights reserved. >> + * Copyright (c) 2016 NXP. All rights reserved. >> + * >> + * Redistribution and use in source and binary forms, with or without >> + * modification, are permitted provided that the following conditions >> + * are met: >> + * >> + * * Redistributions of source code must retain the above copyright >> + * notice, this list of conditions and the following disclaimer. >> + * * Redistributions in binary form must reproduce the above copyright >> + * notice, this list of conditions and the following disclaimer in >> + * the documentation and/or other materials provided with the >> + * distribution. >> + * * Neither the name of Freescale Semiconductor, Inc nor the names of its >> + * contributors may be used to endorse or promote products derived >> + * from this software without specific prior written permission. >> + * >> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS >> + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT >> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR >> + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT >> + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, >> + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT >> + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, >> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY >> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT >> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE >> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> + */ >> + >> +#ifndef _DPAA2_LOGS_H_ >> +#define _DPAA2_LOGS_H_ >> + >> +#define PMD_INIT_LOG(level, fmt, args...) \ >> + RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ##args) >> + >> +#ifdef RTE_LIBRTE_DPAA2_DEBUG_INIT >> +#define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>") >> +#else >> +#define PMD_INIT_FUNC_TRACE() do { } while (0) >> +#endif >> + >> +#ifdef RTE_LIBRTE_DPAA2_DEBUG_RX > > What do you think adding these config option to the config file in this > patch? > I have added them in config file in v2. >> +#define PMD_RX_LOG(level, fmt, args...) \ >> + RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) >> +#else >> +#define PMD_RX_LOG(level, fmt, args...) do { } while (0) >> +#endif >> + >> +#ifdef RTE_LIBRTE_DPAA2_DEBUG_TX >> +#define PMD_TX_LOG(level, fmt, args...) \ >> + RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) >> +#else >> +#define PMD_TX_LOG(level, fmt, args...) do { } while (0) >> +#endif >> + >> +#ifdef RTE_LIBRTE_DPAA2_DEBUG_TX_FREE > > This config option was not documented? > It is fixed in v2. >> +#define PMD_TX_FREE_LOG(level, fmt, args...) \ >> + RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) >> +#else >> +#define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0) >> +#endif >> + >> +#ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER >> +#define PMD_DRV_LOG_RAW(level, fmt, args...) \ >> + RTE_LOG(level, PMD, "%s(): " fmt, __func__, ## args) >> +#else >> +#define PMD_DRV_LOG_RAW(level, fmt, args...) do { } while (0) >> +#endif >> + >> +#define PMD_DRV_LOG(level, fmt, args...) \ >> + PMD_DRV_LOG_RAW(level, fmt "\n", ## args) >> + >> +#endif /* _DPAA2_LOGS_H_ */ >> > >