From: Marek Vasut <marex@denx.de>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: u-boot@lists.denx.de, "Heiko Schocher" <hs@denx.de>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Pali Rohár" <pali@kernel.org>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Patrick Delaunay" <patrick.delaunay@st.com>,
"Priyanka Jain" <priyanka.jain@nxp.com>,
"Simon Glass" <sjg@chromium.org>
Subject: Re: [PATCH] mtd: spi-nor: Fix SF MTDIDS when registering multiple MTDs with DM enabled
Date: Thu, 16 Sep 2021 19:40:12 +0200 [thread overview]
Message-ID: <35b2d40d-2d74-57f7-c0e0-f66cdc5aa151@denx.de> (raw)
In-Reply-To: <20210916171636.5fc8cf61@thinkpad>
On 9/16/21 5:16 PM, Marek Behún wrote:
> On Wed, 15 Sep 2021 01:06:22 +0200
> Marek Vasut <marex@denx.de> wrote:
>
>> The flash->mtd.name used to be nor%d before, now it is the type of the
>> SPI NOR like e.g. mt25ql02g. It is possible to find plenty of examples
>> of the former in U-Boot configs by searching for MTDIDS.*nor.*spi, while
>> the later is ambiguous if there are multiple flashes of the same type in
>> the system and breaks existing environments.
>>
>> This does no longer get recognized when running 'mtdparts' for example:
>> CONFIG_MTDIDS_DEFAULT="nor0=47040000.spi.0"
>>
>> Fix this by setting the correct mtd.name to nor%d.
>
> CONFIG_MTDIDS_DEFAULT="nor0=47040000.spi.0" is defined for
> configs/am65x_evm_a53_defconfig and
> configs/am65x_hs_evm_a53_defconfig
>
> both using device tree arch/arm/dts/k3-am654-base-board.dts
>
> where you have defined DT node flash@0.
>
> Just add partition subnodes, and then you won't need mtdparts.
>
> This can be done for most users of mtdparts, and we won't to convert
> mtdpart to OF and get rid of it.
You are assuming that every system is capable of updating either DT or
env, that is not always the case.
prev parent reply other threads:[~2021-09-16 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 23:06 [PATCH] mtd: spi-nor: Fix SF MTDIDS when registering multiple MTDs with DM enabled Marek Vasut
2021-09-15 4:23 ` Heiko Schocher
2021-09-15 5:59 ` Marek Vasut
2021-09-15 8:53 ` Patrice CHOTARD
2021-09-15 8:57 ` Marek Vasut
2021-09-15 9:17 ` Patrice CHOTARD
2021-09-15 9:21 ` Marek Vasut
2021-09-15 12:00 ` Patrick DELAUNAY
2021-09-15 12:10 ` Marek Vasut
2021-09-16 7:50 ` Patrick DELAUNAY
2021-09-16 14:06 ` Patrick DELAUNAY
2021-09-16 15:16 ` Marek Behún
2021-09-16 17:40 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35b2d40d-2d74-57f7-c0e0-f66cdc5aa151@denx.de \
--to=marex@denx.de \
--cc=hs@denx.de \
--cc=jagan@amarulasolutions.com \
--cc=marek.behun@nic.cz \
--cc=miquel.raynal@bootlin.com \
--cc=pali@kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@st.com \
--cc=priyanka.jain@nxp.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.