From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D918AC433E0 for ; Sun, 28 Mar 2021 18:02:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFC866197C for ; Sun, 28 Mar 2021 18:02:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230411AbhC1SC0 (ORCPT ); Sun, 28 Mar 2021 14:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbhC1SB6 (ORCPT ); Sun, 28 Mar 2021 14:01:58 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D33DEC061756 for ; Sun, 28 Mar 2021 11:01:57 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id j4-20020a05600c4104b029010c62bc1e20so5521044wmi.3 for ; Sun, 28 Mar 2021 11:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FSV6rta3hJrwpk1P4mXDAcDYdRJg95MvBSYZceCodik=; b=oSOYYdNRkdQVtznXgt78DhiwTWTyzGZF3oJMe8w4KEtcPyBLXe+SMFYvGd+1oj9LQU r+3uWqxIghxhPFZU6Wuc3lTsr1obuN/1XT+oueshAk+gbGImzMAYJdf85a6crcqhy0e1 +wZlhI6QwSVp9fLFMCSC4+ilP5ANqr7SeCPSHFAjZvo4GtktRLFRtw0ftjbX+D8y7QhE kOKivr+Xaqy/9hlXYLyfK3URX9DHSdP8BlWHVxIGKPZyn5bMqhtXBFITvpGaI+/xd/rM sFNiokpGBV5ArT1Z24VLOrvllQ0LUemSArwJLtk2pUBXbSKIRoROtHU9pA39vqDdmQwk xaSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FSV6rta3hJrwpk1P4mXDAcDYdRJg95MvBSYZceCodik=; b=ja1c+fYsdXfsfy0whIsBU48E0r2DXFV6Ufw0bZzE8mX9kB24N0qSt3BkJBlJmMPkmz sCSA7vb+pzoDdnHvoYWlHTWlgtdq5FXqbvY6WA25TWzvnW/z2i1oBfafJgm0X/5i8u6h INJgnEhi9EkjuCEk21S47ccUS6ZmB9wfMyyieJl92mngggmae5MUIEzpIs90x9fWMSvq zJnAN+KxSOyDBuQ6NdQK/JLYiuawII2SW+z8hiQ1wuNRt5Cn9ZsI9V5IcDp4Y5D03mNQ yD/dOH0CSJ67qIu1ugSs/tlHHeKUwOY1ZpEut8ROJFP5hW6h+PHFr8ldvLBVOLK51Nut DdbQ== X-Gm-Message-State: AOAM530YddZMDn2QwhiWd62IHGFC2NQsJsqaljoJc7vMjkjsYHW+SZ9U nsc+u9N0V844UFiPepCst4U5iQ== X-Google-Smtp-Source: ABdhPJy+gVLRWMbs9MBvQ5wgzJ1R9N4zHUB5GvTCe8IVgfnknokeggtcfnLxxlZFMTEPF9ziKiZFcw== X-Received: by 2002:a05:600c:1992:: with SMTP id t18mr21563797wmq.125.1616954516332; Sun, 28 Mar 2021 11:01:56 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:1945:696f:a453:cac9? ([2a01:e34:ed2f:f020:1945:696f:a453:cac9]) by smtp.googlemail.com with ESMTPSA id g11sm25154394wrw.89.2021.03.28.11.01.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Mar 2021 11:01:55 -0700 (PDT) Subject: Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system To: Greg KH Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, lukasz.luba@arm.com References: <20210312130411.29833-1-daniel.lezcano@linaro.org> <20210312130411.29833-2-daniel.lezcano@linaro.org> <433ec4ac-a7a9-ecf9-f1c1-f658d279a2df@linaro.org> <7df276d1-abea-622c-2c7e-2c5e412aa4a9@linaro.org> <7ba5094b-7fac-72ff-0e52-6f60eb86f253@linaro.org> From: Daniel Lezcano Message-ID: <35b543d1-5559-b814-11b0-8a53c1218750@linaro.org> Date: Sun, 28 Mar 2021 20:01:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/03/2021 19:26, Greg KH wrote: [ ... ] >>> So why are you trying to add a kref here as the structure already has >>> support for proper lifetimes? >> >> Right, I'll revisit that part. Thanks for the review. >> >> I've a branch which is pulled by Rafael [1]. These parts are already >> merged in the dtpm/next branch but not yet in Rafael's tree. > > I would recommend fixing that up if you can rebase it. If not, you need > to revert it and start over. I'll be glad to review it if you cc: me on > the patches. > >> I think a rebase is possible but I would like to avoid that. Would be a >> patch on top of the dtpm/next acceptable given your flow with Android ? > > This has nothing to do with the Android kernel workflow, sorry. I am > concerned about proper kernel development and keeping bugs out of it. Fair enough, I will fix it up and send a v5. Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog