From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25487C433DF for ; Fri, 7 Aug 2020 08:01:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08969221E5 for ; Fri, 7 Aug 2020 08:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596787272; bh=xUgnM0/zA2UWr+I99OfNrHfnZYFJtBUMEUvz2VyQjUY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=KulhyVGLuMxjoEQFUzVoW0PzAkdv6j0651pLwmVghdljOuFIC1IG7ziOXhgL+Et53 uZmv5UQOOL6L1angsiyaDgPqSzeTA+QCMSg/t5v9qhCoy/jM76vy+msYVlxRJjvUSs HX4+nWy/d2ZBd0tuUP9+OFowwCodlmDixBh0Rj1Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726910AbgHGIBK (ORCPT ); Fri, 7 Aug 2020 04:01:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:53846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgHGIBG (ORCPT ); Fri, 7 Aug 2020 04:01:06 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A25C20866; Fri, 7 Aug 2020 08:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596787265; bh=xUgnM0/zA2UWr+I99OfNrHfnZYFJtBUMEUvz2VyQjUY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J0N3GNdGbqKbNGf7d1vTseLpvgl8Bw+85/lL4NHPbp+Aqw7bcaIYnkzLTGDbgFoCK yej6ElsbfSHdTCIC2sWmalZH8PJifSbKWW5xVlUdSfMf8WHXeU3BWxEDjrvmAAGzo1 3Z6DITpk1GAAiyzLdUJwNMXnXyTE8aXS9LdgBRw8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3xJI-000SA0-37; Fri, 07 Aug 2020 09:01:04 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 07 Aug 2020 09:01:03 +0100 From: Marc Zyngier To: Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Russell King , Thomas Gleixner , Jason Cooper , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 21/41] ARM: s3c24xx: move irqchip driver back into platform In-Reply-To: <20200806182059.2431-21-krzk@kernel.org> References: <20200806181932.2253-1-krzk@kernel.org> <20200806182059.2431-21-krzk@kernel.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: <35c4ebb133e6b885abe1a0c07988599f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: krzk@kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linux@armlinux.org.uk, tglx@linutronix.de, jason@lakedaemon.net, kgene@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-08-06 19:20, Krzysztof Kozlowski wrote: > From: Arnd Bergmann > > It was a good idea to move it out at first, but the irqchip code > is still tightly connected to the s3c24xx platform code and uses > multiple internal header files, so just move it back for the > time being to avoid those dependencies. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/mach-s3c24xx/Makefile | 1 + > {drivers/irqchip => arch/arm/mach-s3c24xx}/irq-s3c24xx.c | 0 > drivers/irqchip/Makefile | 1 - > 3 files changed, 1 insertion(+), 1 deletion(-) > rename {drivers/irqchip => arch/arm/mach-s3c24xx}/irq-s3c24xx.c (100%) > > diff --git a/arch/arm/mach-s3c24xx/Makefile > b/arch/arm/mach-s3c24xx/Makefile > index 6692f2de71b2..8c31f84f8c97 100644 > --- a/arch/arm/mach-s3c24xx/Makefile > +++ b/arch/arm/mach-s3c24xx/Makefile > @@ -8,6 +8,7 @@ > # core > > obj-y += common.o > +obj-y += irq-s3c24xx.o > > obj-$(CONFIG_CPU_S3C2410) += s3c2410.o > obj-$(CONFIG_S3C2410_PLL) += pll-s3c2410.o > diff --git a/drivers/irqchip/irq-s3c24xx.c > b/arch/arm/mach-s3c24xx/irq-s3c24xx.c > similarity index 100% > rename from drivers/irqchip/irq-s3c24xx.c > rename to arch/arm/mach-s3c24xx/irq-s3c24xx.c > diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile > index 133f9c45744a..8c983ad774f6 100644 > --- a/drivers/irqchip/Makefile > +++ b/drivers/irqchip/Makefile > @@ -16,7 +16,6 @@ obj-$(CONFIG_ARCH_LPC32XX) += irq-lpc32xx.o > obj-$(CONFIG_ARCH_MMP) += irq-mmp.o > obj-$(CONFIG_IRQ_MXS) += irq-mxs.o > obj-$(CONFIG_ARCH_TEGRA) += irq-tegra.o > -obj-$(CONFIG_ARCH_S3C24XX) += irq-s3c24xx.o > obj-$(CONFIG_DW_APB_ICTL) += irq-dw-apb-ictl.o > obj-$(CONFIG_CLPS711X_IRQCHIP) += irq-clps711x.o > obj-$(CONFIG_OMPIC) += irq-ompic.o Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D635FC433E0 for ; Fri, 7 Aug 2020 08:02:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A366D20866 for ; Fri, 7 Aug 2020 08:02:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b5nQXJHg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="J0N3GNdG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A366D20866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ILh49Dk3lnUNuXOwEmrPjjm26OXffARZBCILHHrS3D8=; b=b5nQXJHgO/34I/sXzPiHaJbc0 W1Gd4qljZCvbtbbRqLTKHqRqY6JWiJzu8EqnUEFiSQ8ssscAWukQR6B040mcQ8Ky2dJxYti9k+YDU p+z4uX5VCrJhEtTxA9Hm1m1jgFc5/LSIN74uokFmTKXBEEccklutUeY4IekFWSNDee5nAJ1zHr8vd a5sk4K0hCTvm8lYvoQnvXIMtM/xZGRcxBj/EFW519b6S4FgEQpUC625yPT8Dn7v4esx2dRIGDpAV4 Sl/Ue8+qshdnvxZ5cicSTlyq3JIOmaANd64oreRGTDK3Ts2F4dRZEZZSueiikuYjRM3f7tAg8rvwS Hyk/EnuhQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3xJN-0002au-7i; Fri, 07 Aug 2020 08:01:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3xJK-0002aO-ND for linux-arm-kernel@lists.infradead.org; Fri, 07 Aug 2020 08:01:07 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A25C20866; Fri, 7 Aug 2020 08:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596787265; bh=xUgnM0/zA2UWr+I99OfNrHfnZYFJtBUMEUvz2VyQjUY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J0N3GNdGbqKbNGf7d1vTseLpvgl8Bw+85/lL4NHPbp+Aqw7bcaIYnkzLTGDbgFoCK yej6ElsbfSHdTCIC2sWmalZH8PJifSbKWW5xVlUdSfMf8WHXeU3BWxEDjrvmAAGzo1 3Z6DITpk1GAAiyzLdUJwNMXnXyTE8aXS9LdgBRw8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k3xJI-000SA0-37; Fri, 07 Aug 2020 09:01:04 +0100 MIME-Version: 1.0 Date: Fri, 07 Aug 2020 09:01:03 +0100 From: Marc Zyngier To: Krzysztof Kozlowski Subject: Re: [PATCH v2 21/41] ARM: s3c24xx: move irqchip driver back into platform In-Reply-To: <20200806182059.2431-21-krzk@kernel.org> References: <20200806181932.2253-1-krzk@kernel.org> <20200806182059.2431-21-krzk@kernel.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: <35c4ebb133e6b885abe1a0c07988599f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: krzk@kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linux@armlinux.org.uk, tglx@linutronix.de, jason@lakedaemon.net, kgene@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200807_040106_883960_D720E60E X-CRM114-Status: GOOD ( 19.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Jason Cooper , Arnd Bergmann , linux-kernel@vger.kernel.org, Russell King , Kukjin Kim , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-08-06 19:20, Krzysztof Kozlowski wrote: > From: Arnd Bergmann > > It was a good idea to move it out at first, but the irqchip code > is still tightly connected to the s3c24xx platform code and uses > multiple internal header files, so just move it back for the > time being to avoid those dependencies. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/mach-s3c24xx/Makefile | 1 + > {drivers/irqchip => arch/arm/mach-s3c24xx}/irq-s3c24xx.c | 0 > drivers/irqchip/Makefile | 1 - > 3 files changed, 1 insertion(+), 1 deletion(-) > rename {drivers/irqchip => arch/arm/mach-s3c24xx}/irq-s3c24xx.c (100%) > > diff --git a/arch/arm/mach-s3c24xx/Makefile > b/arch/arm/mach-s3c24xx/Makefile > index 6692f2de71b2..8c31f84f8c97 100644 > --- a/arch/arm/mach-s3c24xx/Makefile > +++ b/arch/arm/mach-s3c24xx/Makefile > @@ -8,6 +8,7 @@ > # core > > obj-y += common.o > +obj-y += irq-s3c24xx.o > > obj-$(CONFIG_CPU_S3C2410) += s3c2410.o > obj-$(CONFIG_S3C2410_PLL) += pll-s3c2410.o > diff --git a/drivers/irqchip/irq-s3c24xx.c > b/arch/arm/mach-s3c24xx/irq-s3c24xx.c > similarity index 100% > rename from drivers/irqchip/irq-s3c24xx.c > rename to arch/arm/mach-s3c24xx/irq-s3c24xx.c > diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile > index 133f9c45744a..8c983ad774f6 100644 > --- a/drivers/irqchip/Makefile > +++ b/drivers/irqchip/Makefile > @@ -16,7 +16,6 @@ obj-$(CONFIG_ARCH_LPC32XX) += irq-lpc32xx.o > obj-$(CONFIG_ARCH_MMP) += irq-mmp.o > obj-$(CONFIG_IRQ_MXS) += irq-mxs.o > obj-$(CONFIG_ARCH_TEGRA) += irq-tegra.o > -obj-$(CONFIG_ARCH_S3C24XX) += irq-s3c24xx.o > obj-$(CONFIG_DW_APB_ICTL) += irq-dw-apb-ictl.o > obj-$(CONFIG_CLPS711X_IRQCHIP) += irq-clps711x.o > obj-$(CONFIG_OMPIC) += irq-ompic.o Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel