From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v3,1/7] dmaengine: Add Synopsys eDMA IP core driver From: Gustavo Pimentel Message-Id: <35c5c304-356d-1796-33e5-11f48cce704f@synopsys.com> Date: Mon, 21 Jan 2019 09:14:36 +0000 To: Andy Shevchenko , Gustavo Pimentel Cc: Jose Abreu , "linux-pci@vger.kernel.org" , "dmaengine@vger.kernel.org" , Vinod Koul , Dan Williams , Eugeniy Paltsev , Russell King , Niklas Cassel , Joao Pinto , Luis de Oliveira , Vitor Soares , Nelson Costa , Pedro Sousa List-ID: T24gMTkvMDEvMjAxOSAxNjoyMSwgQW5keSBTaGV2Y2hlbmtvIHdyb3RlOgo+IE9uIFdlZCwgSmFu IDE2LCAyMDE5IGF0IDExOjUzOjAwQU0gKzAwMDAsIEd1c3Rhdm8gUGltZW50ZWwgd3JvdGU6Cj4+ IE9uIDE2LzAxLzIwMTkgMTA6MjEsIEpvc2UgQWJyZXUgd3JvdGU6Cj4+PiBPbiAxLzExLzIwMTkg NjozMyBQTSwgR3VzdGF2byBQaW1lbnRlbCB3cm90ZToKPiAKPj4+PiArCS8qIEZyZWUgaXJxcyAq Lwo+Pj4KPj4+IEJ1dCBkZXZtIHdpbGwgYXV0b21hdGljYWxseSBmcmVlIGl0LCBubyA/Cj4+Cj4+ IFllcywgaXQgc2hvdWxkbid0IGJlIHRoZXJlLiBJJ2xsIHJlbW92ZSBpdC4KPiAKPiBJdCBkZXBl bmRzLiBJZiB0aGUgZHJpdmVyIGlzIHVzaW5nIHRhc2tsZXRzIGl0IG11c3QgZnJlZSBpdCBleHBs aWNpdGx5IGxpa2UgdGhpcy4KCkluIHRoaXMgZHJpdmVyIEknbSBub3QgdXNpbmcgdGFza2xldHMu Cgo+IAo+IFAuUy4gZGV2bV8qX2lycSgpIGlzIHF1aXRlIGRvdWJ0ZnVsIHRvIGhhdmUgaW4gdGhl IGZpcnN0IHBsYWNlLgoKRm9yIGN1cmlvc2l0eSwgd2h5PwoKPiAJCj4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A1C9C282F6 for ; Mon, 21 Jan 2019 09:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC6D92084A for ; Mon, 21 Jan 2019 09:19:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="fBAMGhL9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726566AbfAUJTZ (ORCPT ); Mon, 21 Jan 2019 04:19:25 -0500 Received: from smtprelay.synopsys.com ([198.182.47.9]:52890 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbfAUJTZ (ORCPT ); Mon, 21 Jan 2019 04:19:25 -0500 Received: from mailhost.synopsys.com (unknown [10.13.135.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtprelay.synopsys.com (Postfix) with ESMTPS id 9861424E22F7; Mon, 21 Jan 2019 01:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1548062364; bh=s+MFA0gmbKpIZgk5L8Ci30hZHWObtu9PQfgUY9RK5lA=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=fBAMGhL94UkVEqti71fIDjG/LR2xFu3e6FRZVi4nU/O8/CdN+ER/6r4xvqipkCw3x w4VuOl8LGgpP16OR8qpRYRJsUNfQrjqcdzppdM3e1KPJoQZIjubZLZWcxQ3Ma/ImMS H/jTcRFHpJWXCFJzXEVC2YtYbmwLcTQMlwl/MmGb2mZ05vMCux4Il+pQUFf1A9/FWz 1cwfDuQJbKbwCqPqzDrbJsS0E60IB+dziHf+O3EMRS+aE6eyttK67yHmVzQDM3jaAy taVCzNiHLDZ6GrDXtenqvpg59GKQi0RddDd6HtLe8OGVL3glweuqffCyVIqCnFTxYq ksD7rWjxN97aA== Received: from US01WEHTC2.internal.synopsys.com (us01wehtc2.internal.synopsys.com [10.12.239.237]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 35932A00E4; Mon, 21 Jan 2019 09:19:22 +0000 (UTC) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by US01WEHTC2.internal.synopsys.com (10.12.239.237) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 21 Jan 2019 01:19:22 -0800 Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by DE02WEHTCB.internal.synopsys.com (10.225.19.94) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 21 Jan 2019 10:19:20 +0100 Received: from [10.107.25.131] (10.107.25.131) by DE02WEHTCA.internal.synopsys.com (10.225.19.80) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 21 Jan 2019 10:19:20 +0100 Subject: Re: [RFC v3 1/7] dmaengine: Add Synopsys eDMA IP core driver To: Andy Shevchenko , Gustavo Pimentel CC: Jose Abreu , "linux-pci@vger.kernel.org" , "dmaengine@vger.kernel.org" , Vinod Koul , Dan Williams , Eugeniy Paltsev , Russell King , Niklas Cassel , Joao Pinto , "Luis de Oliveira" , Vitor Soares , Nelson Costa , Pedro Sousa References: <20190119162152.GE9170@smile.fi.intel.com> From: Gustavo Pimentel Message-ID: <35c5c304-356d-1796-33e5-11f48cce704f@synopsys.com> Date: Mon, 21 Jan 2019 09:14:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190119162152.GE9170@smile.fi.intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.25.131] Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 19/01/2019 16:21, Andy Shevchenko wrote: > On Wed, Jan 16, 2019 at 11:53:00AM +0000, Gustavo Pimentel wrote: >> On 16/01/2019 10:21, Jose Abreu wrote: >>> On 1/11/2019 6:33 PM, Gustavo Pimentel wrote: > >>>> + /* Free irqs */ >>> >>> But devm will automatically free it, no ? >> >> Yes, it shouldn't be there. I'll remove it. > > It depends. If the driver is using tasklets it must free it explicitly like this. In this driver I'm not using tasklets. > > P.S. devm_*_irq() is quite doubtful to have in the first place. For curiosity, why? > >