All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Josef Bacik <josef@toxicpanda.com>, linux-btrfs@vger.kernel.org
Cc: dsterba@suse.com
Subject: Re: [PATCH 3/4] btrfs: introduce new read_policy device
Date: Thu, 29 Oct 2020 09:56:17 +0800	[thread overview]
Message-ID: <35d39972-4ad7-8723-7408-4d5aca422742@oracle.com> (raw)
In-Reply-To: <a467a511-e2e4-f79b-d316-cf7f9ddb3e12@toxicpanda.com>




>> +static int btrfs_find_read_preferred(struct map_lookup *map, int 
>> first, int num_stripe)
>> +{
>> +    int stripe_index;
>> +    int last = first + num_stripe;
>> +
>> +    /*
>> +     * If there are more than one read preferred devices, then just 
>> pick the
>> +     * first found read preferred device as of now.
>> +     */
>> +    for (stripe_index = first; stripe_index < last; stripe_index++) {
>> +        if (test_bit(BTRFS_DEV_STATE_READ_PREFERRED,
>> +                 &map->stripes[stripe_index].dev->dev_state))
>> +            return stripe_index;
>> +        }
> 
> b4 isn't working for me because these patches didn't make it to 
> linux-btrfs proper for some reason, 

  Yep. Since yday I am getting email delivery failure.

-----
for recipient address <linux-block@vger.kernel.org> the policy analysis 
reported: zpostgrey: connect: Connection refused
-----

> so I could be wrong here, but it 
> looks like this } is off?  There's spaces here instead of a tab maybe?

> If not then just ignore me. Thanks,
Yeah tab is ok. Its just in the email.

Thanks, Anand

> Josef

  reply	other threads:[~2020-10-29  2:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 13:25 [PATCH v1 0/4] btrfs: read_policy types latency, device and round-robin Anand Jain
2020-10-28 13:26 ` [PATCH 1/4] btrfs: add read_policy latency Anand Jain
2020-10-28 14:30   ` Josef Bacik
2020-10-29  1:06     ` Anand Jain
2020-10-28 13:26 ` [PATCH 2/4] btrfs: introduce new device-state read_preferred Anand Jain
2020-10-28 14:37   ` Josef Bacik
2020-10-29  1:12     ` Anand Jain
2020-10-28 13:26 ` [PATCH 3/4] btrfs: introduce new read_policy device Anand Jain
2020-10-28 14:40   ` Josef Bacik
2020-10-29  1:56     ` Anand Jain [this message]
2020-10-28 13:26 ` [PATCH RFC 4/4] btrfs: introduce new read_policy round-robin Anand Jain
2020-10-28 14:44   ` Josef Bacik
2020-10-29  2:06     ` Anand Jain
2020-10-28 14:32 ` [PATCH v1 0/4] btrfs: read_policy types latency, device and round-robin Josef Bacik
2020-10-29  1:08   ` Anand Jain
2020-10-29  7:44     ` Anand Jain
2020-10-29  7:54 [PATCH v2 " Anand Jain
2020-10-29  7:54 ` [PATCH 3/4] btrfs: introduce new read_policy device Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35d39972-4ad7-8723-7408-4d5aca422742@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.