From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2098925-1517322483-2-5911106919620129728 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='net', MailFrom='org' X-Spam-charsets: plain='utf-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517322482; b=F0c4KyqmGoL2vtaoLsR1toVfDK4qEHBWpT+dsC7RZtcyQbZ wM39SatPz3ubSmC4wiDM5Tc2Ftk+X7ec3Cg2X+7B7vrKeVsG2LL0xqzgGgpi80qU G6riDE2iC9FtKd9v6Swvj69ODqxmL9vfABwVxNbzD5N3DVeOOkoSq401KzFBPGMC 3BUNxFLNlN1vxePUH7vVE9bc0k0PA/TVdCqHpFAriZXQb3wMsBeCkhFjbyLeqyKg H4T+l71B/tVhR+O5hS1LsHyB2Yke4dhKFuN/dqTMv+mK7OlbX99Q1dXfhtKv5yJE EUzs6BZ8jRZ3tK/lmGyAalkFYTOUU11PkQwG/dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:cc:references:from:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1517322482; bh=7u9iVQAbEeSa9Cwr7pCIXauCNYfaJy7G0d1Zc4t05uI=; b=n X48msa6+IoYoL82z9AA0QytnWiVMeiKKHS9qeEJFWHMwlMTh1MT5Ae1fBrBjd9h+ uUEUWCoLUN9BCv2OBlI01K13RTOzXuKD7+bhwBi8UF6LWejvY5Dt4+H7qg/He27F d+DnZu4Rbt6FYrfr1aQwFQ0z8/Fuq7Z+dQFhGi3UQVq/DQZpdCKEKHoVAZLSh+X5 c1bhxooSsuOKKodfv0QsERNDzOQFTBOUnGWtl7HXPp5ngMGzCsbBbf7T6Ftq+G64 WkmaAIrgXCpl1OqjWDI+/JhWlq4h8QwoODn7Em4sOTbDx8DBBD6jTM9cSndlRnAn YVWtweaXwZHBfIPrnjgbA== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=mgPJQH+8 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=roeck-us.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=khIcHBI3; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=roeck-us.net header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=mgPJQH+8 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=roeck-us.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=khIcHBI3; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=roeck-us.net header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752270AbeA3O1s (ORCPT ); Tue, 30 Jan 2018 09:27:48 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:42494 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbeA3O1q (ORCPT ); Tue, 30 Jan 2018 09:27:46 -0500 X-Google-Smtp-Source: AH8x227tlrQ9d/Db5e9OWp2KolYZjk47vl4aVcEJFiaUZ2Cng8rYqZxR6KMfw5wpxa8qTXB+ATtWBQ== Subject: Re: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS To: Heikki Krogerus , Adam Thomson Cc: Greg Kroah-Hartman , Sebastian Reichel , Hans de Goede , Yueyao Zhu , Rui Miguel Silva , linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, support.opensource@diasemi.com References: <20180130132504.GH14922@kuha.fi.intel.com> From: Guenter Roeck Message-ID: <3611b3dd-2512-441f-9239-17af2dab0929@roeck-us.net> Date: Tue, 30 Jan 2018 06:27:44 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180130132504.GH14922@kuha.fi.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 01/30/2018 05:25 AM, Heikki Krogerus wrote: > On Tue, Jan 02, 2018 at 03:50:48PM +0000, Adam Thomson wrote: >> This patch set adds sink side support for the PPS feature introduced in the >> USB PD 3.0 specification. >> >> The source PPS supply is represented using the Power Supply framework to provide >> access and control APIs for dealing with it's operating voltage and current, >> and switching between a standard PDO and PPS APDO operation. During standard PDO >> operation the voltage and current is read-only, but for APDO PPS these are >> writable as well to allow for control. >> >> It should be noted that the keepalive for PPS is not handled within TCPM. The >> expectation is that the external user will be required to ensure re-requests >> occur regularly to ensure PPS remains and the source does not hard reset. > > Sorry for the late reply. I don't have any major problems with these > other than with 6/7. The documentation should be for the psy class, > not tcpm. I'm also not comfortable with the "select POWER_SUPPLY", but > if Guenter does not think it's a problem, I'm fine with it. I guess we "select POWER_SUPPLY" seems to be quite widely used, so I don't have problems with it as long as it is ok for PS maintainers. > can always, for example, introduce stubs for the power_supply* > functions, and drop the dependency later. > That doesn't sound like a good idea unless generic stubs are already available. > But as usual with tcpm.c, Guenter needs to give his ACK. > I'll try to get to it this week. Guenter > Oh yes, and Sebastian needs to ACK the power_supply changes or course. > > > Thanks, >