From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E496C433ED for ; Fri, 16 Apr 2021 13:40:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4525E610FA for ; Fri, 16 Apr 2021 13:40:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235603AbhDPNk0 (ORCPT ); Fri, 16 Apr 2021 09:40:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235329AbhDPNkZ (ORCPT ); Fri, 16 Apr 2021 09:40:25 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D59EC061574 for ; Fri, 16 Apr 2021 06:40:00 -0700 (PDT) Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 1C1AD80040; Fri, 16 Apr 2021 15:39:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1618580395; bh=DN06i9gmQHIuoZz210y9kvpT4840BC3hd/m62B1VvN4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TajBG8AI4SLYPrzCwKsT9w5k5ZfUP7vUfNeyfML+GHI4gifEehnvEYV6QSDze/0s8 s3TG+HINLPIUP4gk+vEl1ay/3aDDak9fIicnzEZEn3sUd6u+TSquKaRDzX5Qh+bxfI Lyynlu+JZtUpf0iDNGvd7rUYLJnInG2DMjsui9X3ltNwm6Mm3Xw/FlBdcHIiAE2RwK Ka46HdHB3uUFQrur1kG02lB6UBIKpr08Ezwz/gN2PTGBATHbQNk4LPv6D7D1T5erzN E88SnY85kaDmkwfu3s4fOeU+uPOfWuCv/NoEbZabDcifnDbq/AO3VwDDLrsHIdamGD +8EsmuqBZ0XlA== Subject: Re: [PATCH 2/7] clk: stm32mp1: The dev is always NULL, replace it with np To: "gabriel.fernandez@foss.st.com" , linux-arm-kernel@lists.infradead.org Cc: Alexandre Torgue , Christophe Roullier , Patrice Chotard , Patrick Delaunay , Stephen Boyd , linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20210408185731.135511-1-marex@denx.de> <20210408185731.135511-3-marex@denx.de> From: Marek Vasut Message-ID: <362315e2-1398-4d11-e179-0ab7ca64e591@denx.de> Date: Fri, 16 Apr 2021 15:39:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 4/16/21 8:44 AM, gabriel.fernandez@foss.st.com wrote: > Hi Marek, Hello Gabriel, > I have a patch-set in progress using $dev (convertion into module driver). > > https://patchwork.kernel.org/project/linux-clk/list/?series=421767 > > Then rebase of your patch, [PATCH 4/7] clk: stm32mp1: Add parent_data to > ETHRX clock, can be done easily. I suspect the aforementioned patchset will have to be reworked, since the current approach to push SCMI onto every system and renumerate the clock has been rejected, because it caused DT ABI break and boot problems on many systems. btw please don't top-post. > Best regards > Gabriel > > On 4/8/21 8:57 PM, Marek Vasut wrote: >> Instead of passing around $dev to all the registration functions, which >> is always NULL, pass around struct device_node pointer $np. This way it >> is possible to use of_clk_hw_register*() functions and/or register clock >> with associated $np pointer. [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC2ECC433B4 for ; Fri, 16 Apr 2021 13:42:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A2DD611AC for ; Fri, 16 Apr 2021 13:42:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A2DD611AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1BRIfUvp4CDS7NIDpt39PMDUGfAV0nuvvXxaq0fn+68=; b=KfFJR5Uit1DXbeDYaTSWOnGb1 yH27+ug7+k8Qa6d4FzWsXrLoBaNnx4k6fb4Ye/2eFkZylSEidymPa3Xzj0NZdFEy9e7/ejCeZwYsD M89w12vE5UwyJDgLUt/MbuaKwk91/dMc1+2ozkMaE50/607Q2paoCf6GoVCbUTFMbEORBQoAuXanC SY2g2JYodXGdHcjtuqLpiUkzAG26okzqaVeVfas94T7qB0DJdBtMB6JEbZxj07fPAPw6lnfbB0krs VYPxVTspeQ/C8FkpW5WMkHuGD1cjkIWqjp3vQQ6KU/GYhnnjLt4MT3dB8jb3+k2EG89LTNP8IcaUP yRtYz7HTg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXOi2-002H7G-T4; Fri, 16 Apr 2021 13:40:35 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXOhd-002GwE-0v for linux-arm-kernel@desiato.infradead.org; Fri, 16 Apr 2021 13:40:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=DN06i9gmQHIuoZz210y9kvpT4840BC3hd/m62B1VvN4=; b=TxZmSAof/ms7nvBuyKYqm1DD93 CcDs5E3Vis8/lJKrWaNtonxjobvuECoRGIrByjxbugq81CdHG8ZY2X4+pT3a+NCg6UW3rP6LJNbTa eUaZXtPo6lI0VRWFYFi1CqMq/W5SmwEQ2JzXsvwR8IWeDjAQruiue+TRYL/UoFSnUF6nsGyqH7zVW hWOJtMH10eFi0zsEkLL3BtRXWPTepo8pbS18aa5UajMa5vl/k+GeqT0T3hG7Hgrg3+mzBrqcdQduE xU2S6pC9zgvYEkhdip7F3axoD5ZaGdNyhL90vh0hQfaCL8FJbEPgSF1ACSudmO40ZupoSxmaLDCjV k0GgX1Ig==; Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXOhV-009PKt-I0 for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 13:40:07 +0000 Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 1C1AD80040; Fri, 16 Apr 2021 15:39:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1618580395; bh=DN06i9gmQHIuoZz210y9kvpT4840BC3hd/m62B1VvN4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TajBG8AI4SLYPrzCwKsT9w5k5ZfUP7vUfNeyfML+GHI4gifEehnvEYV6QSDze/0s8 s3TG+HINLPIUP4gk+vEl1ay/3aDDak9fIicnzEZEn3sUd6u+TSquKaRDzX5Qh+bxfI Lyynlu+JZtUpf0iDNGvd7rUYLJnInG2DMjsui9X3ltNwm6Mm3Xw/FlBdcHIiAE2RwK Ka46HdHB3uUFQrur1kG02lB6UBIKpr08Ezwz/gN2PTGBATHbQNk4LPv6D7D1T5erzN E88SnY85kaDmkwfu3s4fOeU+uPOfWuCv/NoEbZabDcifnDbq/AO3VwDDLrsHIdamGD +8EsmuqBZ0XlA== Subject: Re: [PATCH 2/7] clk: stm32mp1: The dev is always NULL, replace it with np To: "gabriel.fernandez@foss.st.com" , linux-arm-kernel@lists.infradead.org Cc: Alexandre Torgue , Christophe Roullier , Patrice Chotard , Patrick Delaunay , Stephen Boyd , linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20210408185731.135511-1-marex@denx.de> <20210408185731.135511-3-marex@denx.de> From: Marek Vasut Message-ID: <362315e2-1398-4d11-e179-0ab7ca64e591@denx.de> Date: Fri, 16 Apr 2021 15:39:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_064001_785542_5D6D97AF X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/16/21 8:44 AM, gabriel.fernandez@foss.st.com wrote: > Hi Marek, Hello Gabriel, > I have a patch-set in progress using $dev (convertion into module driver). > > https://patchwork.kernel.org/project/linux-clk/list/?series=421767 > > Then rebase of your patch, [PATCH 4/7] clk: stm32mp1: Add parent_data to > ETHRX clock, can be done easily. I suspect the aforementioned patchset will have to be reworked, since the current approach to push SCMI onto every system and renumerate the clock has been rejected, because it caused DT ABI break and boot problems on many systems. btw please don't top-post. > Best regards > Gabriel > > On 4/8/21 8:57 PM, Marek Vasut wrote: >> Instead of passing around $dev to all the registration functions, which >> is always NULL, pass around struct device_node pointer $np. This way it >> is possible to use of_clk_hw_register*() functions and/or register clock >> with associated $np pointer. [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel