From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
techboard@dpdk.org, dev@dpdk.org,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
David Marchand <david.marchand@redhat.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister
Date: Thu, 02 Dec 2021 08:18:52 +0100 [thread overview]
Message-ID: <3625450.hdfAi7Kttb@thomas> (raw)
In-Reply-To: <20211201213749.GA5097@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
01/12/2021 22:37, Tyler Retzlaff:
> On Wed, Nov 24, 2021 at 06:04:56PM +0000, Bruce Richardson wrote:
> > if (ret < 0 && rte_errno == EAGAIN)
>
> i only urge that this be explicit as opposed to a range i.e. ret == -1
> preferred over ret < 0
I don't understand why you think it is important to limit return value to -1.
Why "if (ret == -1)" is better than "if (ret < 0)" ?
next prev parent reply other threads:[~2021-12-02 7:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 19:28 [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister eagostini
2021-11-18 16:20 ` Stephen Hemminger
2021-11-18 16:22 ` Elena Agostini
2021-11-18 20:19 ` Tyler Retzlaff
2021-11-19 9:34 ` Ferruh Yigit
2021-11-19 9:56 ` Thomas Monjalon
2021-11-24 17:24 ` Tyler Retzlaff
2021-11-24 18:04 ` Bruce Richardson
2021-12-01 21:37 ` Tyler Retzlaff
2021-12-02 7:18 ` Thomas Monjalon [this message]
2021-12-02 12:33 ` Morten Brørup
2021-12-02 13:01 ` Ananyev, Konstantin
2021-12-02 13:56 ` Morten Brørup
2021-12-03 10:37 ` Morten Brørup
2021-12-08 17:34 ` Tyler Retzlaff
2021-12-08 18:40 ` Morten Brørup
2021-12-09 19:43 ` Tyler Retzlaff
2021-12-08 17:27 ` Tyler Retzlaff
2021-11-19 10:15 ` Bruce Richardson
2021-11-18 20:33 ` [PATCH v2] gpudev: free and unregister return gracefully if input pointer is NULL eagostini
2021-11-22 18:24 ` [PATCH v3] gpudev: manage NULL pointer eagostini
2021-11-22 11:23 ` Thomas Monjalon
2021-11-22 11:34 ` Elena Agostini
2021-11-22 11:51 ` Thomas Monjalon
2021-11-22 23:52 ` [PATCH v4] " eagostini
2021-11-22 23:55 ` [PATCH v5] " eagostini
2021-11-22 16:01 ` Thomas Monjalon
2021-11-23 0:15 ` [PATCH v6] " eagostini
2021-11-23 0:42 ` [PATCH v7] " eagostini
2021-11-24 8:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3625450.hdfAi7Kttb@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=techboard@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.