From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v5 1/3] librte_ether: add API for VF
	management
Date: Thu, 29 Sep 2016 16:30:05 +0200
Message-ID: <3631809.sFy4WKcCTS@xps13>
References: <1474453204-31516-1-git-send-email-bernard.iremonger@intel.com>
 <1475158591-2243-2-git-send-email-bernard.iremonger@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, rahul.r.shah@intel.com, wenzhuo.lu@intel.com, az5157@att.com,
 azelezniak <alexz@att.com>
To: Bernard Iremonger <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id DA46538EB
 for <dev@dpdk.org>; Thu, 29 Sep 2016 16:30:08 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id w84so301817055wmg.1
 for <dev@dpdk.org>; Thu, 29 Sep 2016 07:30:08 -0700 (PDT)
In-Reply-To: <1475158591-2243-2-git-send-email-bernard.iremonger@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-09-29 15:16, Bernard Iremonger:
> Add new API function to configure and manage VF's on a NIC.
> 
> add rte_eth_dev_set_vf_vlan_stripq function.
> 
> Signed-off-by: azelezniak <alexz@att.com>

We need the full name of azelezniak.

> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
[...]
> +int
> +rte_eth_dev_set_vf_vlan_stripq(uint8_t port, uint16_t vf, int on);

Why keeping this function in ethdev?

I think it would be more consistent to have also existing VF functions
moving from ethdev to rte_pmd_ixgbe.h.
You cannot remove them, but you can create their ixgbe-specific version
and announce that the ethdev ones are deprecated.