From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: Survey for final decision about per-port offload API
Date: Mon, 02 Apr 2018 22:10:14 +0200
Message-ID: <3635124.eX5m4pFW80@xps>
References: <2759953.P7QpFFSjiU@xps> <D6E7B50D.1BC853%Harish.Patil@cavium.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>, "Jacob,
 Jerin" <Jerin.JacobKollanukkaran@cavium.com>, "Thotton,
 Shijith" <Shijith.Thotton@cavium.com>, "Shukla,
 Santosh" <Santosh.Shukla@cavium.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 John Daley <johndale@cisco.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Beilei Xing <beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Yongseok Koh <yskoh@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>,
 Tomasz Duszynski <tdu@semihalf.com>, Jianbo Liu <jianbo.liu@arm.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>, "Mody,
 Ra
To: "Patil, Harish" <Harish.Patil@cavium.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 449821B3C6
 for <dev@dpdk.org>; Mon,  2 Apr 2018 22:10:34 +0200 (CEST)
In-Reply-To: <D6E7B50D.1BC853%Harish.Patil@cavium.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/04/2018 19:39, Patil, Harish:
> >It was also proposed to relax the API and allow "forgetting" port
> >offloads in queue offloads:
> >	http://dpdk.org/ml/archives/dev/2018-March/092978.html
> >
> >It would mean the offloads applied to a queue result of OR operation:
> >	rte_eth_conf.[rt]xmode.offloads | rte_eth_[rt]xconf.offloads
> >
> >1/ Do you agree with above API change?
>=20
> Yes. But pls confirm that this would still work properly if RX supports
> port-only based offloads and doesn=E2=80=99t support queue based offloads=
 at all,
> as advertised in dev_infos_get().
>=20
> dev_info->rx_queue_offload_capa =3D 0 and
> dev_info->rx_offload_capa =3D (DEV_RX_OFFLOAD_IPV4_CKSUM | ...);

Yes, of course, no queue offload at all is possible.