From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v6 2/4] meson: add infra to support machine
	specific flags
Date: Fri, 29 Mar 2019 14:57:19 +0100
Message-ID: <3635349.6jznIY6G22@xps>
References: <20190224181041.27127-1-jerinj@marvell.com>
 <20190318164949.2357-2-jerinj@marvell.com>
 <20190319094043.GA318652@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 "gavin.hu@arm.com" <gavin.hu@arm.com>,
 Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>, hemant.agrawal@nxp.com,
 honnappa.nagarahalli@arm.com, Yongseok Koh <yskoh@mellanox.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 955242BF4
 for <dev@dpdk.org>; Fri, 29 Mar 2019 14:57:23 +0100 (CET)
In-Reply-To: <20190319094043.GA318652@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

19/03/2019 10:40, Bruce Richardson:
> On Mon, Mar 18, 2019 at 04:50:16PM +0000, Jerin Jacob Kollanukkaran wrote:
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > 
> > Currently, RTE_* flags are set based on the implementer ID but there might
> > be some micro arch specific differences from the same vendor
> > eg. CACHE_LINESIZE. Add support to set micro arch specific flags.
> > 
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> >  config/arm/meson.build | 37 ++++++++++++++++++++++++++++++++-----
> >  1 file changed, 32 insertions(+), 5 deletions(-)
> > 
> This looks ok to me, but I think review and ack from another Arm vendor
> would be good to have.

Adding Cc's for more reviews