From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2605EC433ED for ; Tue, 18 May 2021 09:43:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD9F9610A8 for ; Tue, 18 May 2021 09:43:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD9F9610A8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liwGT-0007XE-NP for qemu-devel@archiver.kernel.org; Tue, 18 May 2021 05:43:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liw4t-0000Sd-3w for qemu-devel@nongnu.org; Tue, 18 May 2021 05:31:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liw4l-0001zO-16 for qemu-devel@nongnu.org; Tue, 18 May 2021 05:31:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621330302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RiXiKUvEhyWpdkHN+TevrZrT0lvnofWgwpRgLQNKYic=; b=Yx4vbhDNS+2RTyKqApQkC93sAxl9ohRmva2aLmGEw6lr716JbxhNzd4tcJ4zom7nGM3Wls Ipb31shoipW16OWnqHIv6TnVRL+E0mCNSFN//Un90/dOxBEVzevTSObkJ+blD1lRLYFJi+ G5ZjZBBPeR3x5sq6UvR+tUIsYbWLnkQ= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-odEek96TMvaob9vvStH5xA-1; Tue, 18 May 2021 05:31:40 -0400 X-MC-Unique: odEek96TMvaob9vvStH5xA-1 Received: by mail-ej1-f71.google.com with SMTP id sd18-20020a170906ce32b02903cedf584542so2144556ejb.9 for ; Tue, 18 May 2021 02:31:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RiXiKUvEhyWpdkHN+TevrZrT0lvnofWgwpRgLQNKYic=; b=mN6dNuztUurrbE0Au/uf6pXEWYa+rLdOsb2U0+6dsUMDJNqYFNmd3snct1j9woiGqL 9u5e3Dt4k1KdWXgqKEmmajwrt2C9Y0achlve/do+DPUHDoSH2h0SzTMLe0f3+l781Oac dvSx7Jchm+mduGZ8meJLg0Zy1x7pu8Ipeg0sZqYuv4uJByCmPBwqyPetoqtLofK5mAFJ 19GA0lgv7dMrhyGfS8tRkkg2r3wExCBbpyBsiPE1H1ayjAlsDSl53CgK/NbXavbDgCYc gCCKq6KWSn5tOv5psRSXKxG5w4jf5Z7A5nMZEEZwh254Bq4VbRa3jaAy93a1E9VHYg8t 1pNg== X-Gm-Message-State: AOAM532ipjZoX4tCCu+DbEQDsIYPImQfvfj850c+pXzu/DkjgxMTYleN dgx3iZHLp+ZWnAfW2rloDLyLGMHSKfWY0a5E8gZbgWb9xd9p/sVGGjSWYy0HcPerMSNP4RKKLuL fZ/zM5WH7XYcbJOg= X-Received: by 2002:a17:906:924a:: with SMTP id c10mr5093396ejx.415.1621330299784; Tue, 18 May 2021 02:31:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTTbXxwFkbwzJn0/XPvrZEot3t6AhdQ9zo7rfRWOai1EOjXTcoJn3zcnJUTGwBPoAl9Tgjuw== X-Received: by 2002:a17:906:924a:: with SMTP id c10mr5093381ejx.415.1621330299647; Tue, 18 May 2021 02:31:39 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id a7sm1288833edr.15.2021.05.18.02.31.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 May 2021 02:31:39 -0700 (PDT) Subject: Re: [PATCH v2 22/50] target/i386: Reduce DisasContext.prefix to uint8_t To: Richard Henderson , qemu-devel@nongnu.org References: <20210514151342.384376-1-richard.henderson@linaro.org> <20210514151342.384376-23-richard.henderson@linaro.org> From: Paolo Bonzini Message-ID: <3638a1c8-0431-d395-44ea-dc40fdeb51be@redhat.com> Date: Tue, 18 May 2021 11:31:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210514151342.384376-23-richard.henderson@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cfontana@suse.de, f4bug@amsat.org, ehabkost@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 14/05/21 17:13, Richard Henderson wrote: > The highest bit in this set is 0x40 (PREFIX_REX). > > Signed-off-by: Richard Henderson > --- > target/i386/tcg/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c > index 44a28858aa..61c0573c2f 100644 > --- a/target/i386/tcg/translate.c > +++ b/target/i386/tcg/translate.c > @@ -78,7 +78,7 @@ typedef struct DisasContext { > > /* current insn context */ > int8_t override; /* -1 if no override, else R_CS, R_DS, etc */ > - int prefix; > + uint8_t prefix; > MemOp aflag; > MemOp dflag; > target_ulong pc_start; > Reviewed-by: Paolo Bonzini