From: <Nicolas.Ferre@microchip.com>
To: <anssi.hannula@bitwise.fi>, <davem@davemloft.net>,
<Claudiu.Beznea@microchip.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH 0/3] net: macb: DMA race condition fixes
Date: Mon, 3 Dec 2018 08:26:52 +0000 [thread overview]
Message-ID: <363e3baa-ca57-87e9-0a74-c24d7654da4c@microchip.com> (raw)
In-Reply-To: <20181130182137.27974-1-anssi.hannula@bitwise.fi>
On 30/11/2018 at 19:21, Anssi Hannula wrote:
> Hi all,
>
> Here are a couple of race condition fixes for the macb driver. The first
> two are issues observed on real HW.
>
> Anssi Hannula (3):
> net: macb: fix random memory corruption on RX with 64-bit DMA
> net: macb: fix dropped RX frames due to a race
> net: macb: add missing barriers when reading buffers
>
> drivers/net/ethernet/cadence/macb_main.c | 34 +++++++++++++++++++++-----
> 1 file changed, 28 insertions(+), 6 deletions(-)
David,
Can you please delay a bit the acceptance of this series, I would like
that we assess these findings with tests on our hardware before applying
them.
Anssi,
Thanks a lot for this series. On our side, we have one pending patch
about fixing a race condition on our hardware. We would need to redo
some tests with our patch and yours so that we know better the behavior
of our hardware.
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2018-12-03 8:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 18:21 [PATCH 0/3] net: macb: DMA race condition fixes Anssi Hannula
2018-11-30 18:21 ` [PATCH 1/3] net: macb: fix random memory corruption on RX with 64-bit DMA Anssi Hannula
2018-12-03 4:44 ` Harini Katakam
2018-12-05 12:37 ` Claudiu.Beznea
2018-12-05 13:58 ` Anssi Hannula
2018-12-05 20:32 ` David Miller
2018-12-06 14:16 ` Claudiu.Beznea
2018-11-30 18:21 ` [PATCH 2/3] net: macb: fix dropped RX frames due to a race Anssi Hannula
2018-12-03 4:52 ` Harini Katakam
2018-12-03 10:31 ` Anssi Hannula
2018-12-03 10:36 ` Harini Katakam
2018-12-05 12:38 ` Claudiu.Beznea
2018-11-30 18:21 ` [PATCH 3/3] net: macb: add missing barriers when reading buffers Anssi Hannula
2018-12-05 12:37 ` Claudiu.Beznea
2018-12-05 14:00 ` Anssi Hannula
2018-12-06 14:14 ` Claudiu.Beznea
2018-12-07 12:00 ` Anssi Hannula
2018-12-10 10:34 ` Claudiu.Beznea
2018-12-11 13:21 ` Anssi Hannula
2018-12-12 10:58 ` Claudiu.Beznea
2018-12-12 11:27 ` Anssi Hannula
2018-12-13 10:48 ` Claudiu.Beznea
2018-12-12 10:59 ` [PATCH 3/3 v2] net: macb: add missing barriers when reading descriptors Anssi Hannula
2018-12-12 23:19 ` David Miller
2018-12-03 8:26 ` Nicolas.Ferre [this message]
2018-12-03 23:56 ` [PATCH 0/3] net: macb: DMA race condition fixes David Miller
2018-12-05 20:35 ` David Miller
2018-12-07 12:04 ` Anssi Hannula
2018-12-10 10:58 ` Nicolas.Ferre
2018-12-10 11:32 ` Claudiu.Beznea
2018-12-10 11:34 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=363e3baa-ca57-87e9-0a74-c24d7654da4c@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=anssi.hannula@bitwise.fi \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.