From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38F46C433F5 for ; Tue, 21 Dec 2021 15:24:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239295AbhLUPYe (ORCPT ); Tue, 21 Dec 2021 10:24:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239283AbhLUPYe (ORCPT ); Tue, 21 Dec 2021 10:24:34 -0500 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8234::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EE97C061574 for ; Tue, 21 Dec 2021 07:24:33 -0800 (PST) Received: from ip4d173d4a.dynamic.kabel-deutschland.de ([77.23.61.74] helo=[192.168.66.200]); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1mzh0B-0006BS-7P; Tue, 21 Dec 2021 16:24:31 +0100 Message-ID: <364b900a-a2a2-7363-a852-9368635e886c@leemhuis.info> Date: Tue, 21 Dec 2021 16:24:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2] usb: typec: ucsi: Only check the contract if there is a connection Content-Language: en-BS To: Greg Kroah-Hartman Cc: Heikki Krogerus , linux-usb@vger.kernel.org, Chris Hixon References: <20211221140352.45501-1-heikki.krogerus@linux.intel.com> <2723c9a3-a932-3634-422b-3fbd93550bf8@leemhuis.info> From: Thorsten Leemhuis In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1640100273;f52be9cd; X-HE-SMSGID: 1mzh0B-0006BS-7P Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 21.12.21 16:03, Greg Kroah-Hartman wrote: > On Tue, Dec 21, 2021 at 03:39:04PM +0100, Thorsten Leemhuis wrote: >> On 21.12.21 15:03, Heikki Krogerus wrote: >>> The driver must make sure there is an actual connection >>> before checking details about the USB Power Delivery >>> contract. Those details are not valid unless there is a >>> connection. >>> >>> This fixes NULL pointer dereference that is caused by an >>> attempt to register bogus partner alternate mode that the >>> firmware on some platform may report before the actual >>> connection. >>> >>> Reported-by: Chris Hixon >>> Fixes: 6cbe4b2d5a3f ("usb: typec: ucsi: Check the partner alt modes always if there is PD contract") >>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215117 >>> Signed-off-by: Heikki Krogerus >>> --- >>> >>> Hi, >>> >>> Instead of using the "BugLink" tag, I'm now using "Link" tag with the >>> link to the bug as requested. >> >> Thx! >> >>> There was a request to have also another Link tag pointing to some >>> other discussion on the mailing list, but I failed to understand what >>> was the point with that - I also didn't find any commits where >>> something like that had been used before. >> >> There are quite a few commits that use more that two "Link" tags, as >> they should point to "related discussions or any other background >> information behind the change" that "can be found on the web" (Quotes >> from Documentation/process/submitting-patches.rst) -- hence there is no >> limit. That being said: >> >>> I may be mistaken here, but I got the impression that you create the >>> mailing list discussion >> >> You are mistaken: I created it because the bugzilla ticket was ignored >> in bugzilla for weeks and might have forgotten otherwise -- no wonder, >> was bugzilla.kernel.org is not the official place to report USB bugs >> according to the MAINTAINERS file. >> >>> just so you can have the extra Link tag >>> pointing to it, and that Link tag you want only because you have made >>> your scripts rely on it. >> >> They rely on it as almost all subsystems expect bug to be reported by >> mail, as they are instructed by >> Documentation/admin-guide/reporting-issues.rst >> >>> The extra email thread in any case does not seem to contain any real >>> additional information that the bug report does not have, so the extra >>> Link tag pointing to it does not provide any real value on top of the >>> link to bug itself. >> >> In this case that's true, as I have to tell regzbot about the fix then >> manually (the plan it to make regzbot also detect links to >> bugzilla.kernel.org, but I fear I have no time to work on that in the >> next few weeks :-/ ). But in similar cases it's different, as there the >> developers continued discussing the issue by mail -- then it's >> definitely worth linking there as well. > > So for this case, what type of tag should I add here to get rezbot to > manually pick this up? Just commit it. Afterwards someone needs to send '#regzbot fixed-by: ' to the thread with the report, for example as a reply to this mail: https://lore.kernel.org/linux-usb/eb34f98f-00ef-3238-2daa-80481116035d@leemhuis.info/ But you can leave that to me, regzbot will alert me anyway once it sees a fix with "Fixes: 6cbe4b2d5a3f". That's the commit that introduced the regression. But making regzbot mark the entry as fixed solely on this afaics would be a bad idea, as one commit can cause different regressions :-/ Making regbzot detect "Link:" tags to bugzilla tickets it knowns about is pretty high on my todo list for regzbot. I would have worked on this already, but I have to focus on other things for now to fulfil the milestones I promised to deliver with regzbot. :-/ Ciao, Thorsten