From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Guo, Jia" <jia.guo@intel.com>
Subject: Re: [PATCH V4 8/9] app/testpmd: show example to handle
 hot unplug
Date: Wed, 4 Jul 2018 11:48:19 +0800
Message-ID: <365be70b-3896-6f5c-51cf-f1a5ce279063@intel.com>
References: <1498711073-42917-1-git-send-email-jia.guo@intel.com>
 <VI1PR0501MB2608C7B8D4803C287E02B0F9D24C0@VI1PR0501MB2608.eurprd05.prod.outlook.com>
 <07fb8f04-adee-fd0e-05b5-8d1bcca1338d@intel.com> <2612071.aGzFhBPpOt@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Matan Azrad <matan@mellanox.com>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
 "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
 "jingjing.wu@intel.com" <jingjing.wu@intel.com>,
 Mordechay Haimovsky <motih@mellanox.com>,
 "harry.van.haaren@intel.com" <harry.van.haaren@intel.com>,
 "qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
 "shaopeng.he@intel.com" <shaopeng.he@intel.com>,
 "bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
 "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>,
 "helin.zhang@intel.com" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 2EE3B1BE9B
 for <dev@dpdk.org>; Wed,  4 Jul 2018 05:48:32 +0200 (CEST)
In-Reply-To: <2612071.aGzFhBPpOt@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


hi, thomas


On 7/4/2018 6:44 AM, Thomas Monjalon wrote:
> 03/07/2018 11:35, Guo, Jia:
>> On 7/1/2018 3:46 PM, Matan Azrad wrote:
>>> From: Jeff Guo
>>>> --- a/app/test-pmd/testpmd.c
>>>> +++ b/app/test-pmd/testpmd.c
>>>> @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char *device_name, enum
>>>> rte_dev_event_type type,
>>>>    	case RTE_DEV_EVENT_REMOVE:
>>>>    		RTE_LOG(ERR, EAL, "The device: %s has been removed!\n",
>>>>    			device_name);
>>>> -		/* TODO: After finish failure handle, begin to stop
>>>> -		 * packet forward, stop port, close port, detach port.
>>>> -		 */
>>>> +		ret = rte_eth_dev_get_port_by_name(device_name, &port_id);
>>> As you probably know, 1 rte_device may be associated to more than one ethdev ports, so the ethdev port name can be different from rte_device name.
>>> Looks like we need a new ethdev API to get all the ports associated to one rte_device.
>> agree, seems that the the old ethdev API have some issue when got all
>> port by device name. we could check with ethdev maintainer and fix it by
>> specific ethdev patch later.
> This ethdev function could return an error if several ports match.
>
> Ideally, we should not use this function at all.
> If you want to manage an ethdev port, why are you using an EAL event?
> There is an ethdev callback mechanism for port removal.
>
>

i think the problem is that how to manage all ethdev port associated 
with one rte_device. So the easy way is let device event callback to 
check these ports. I will modify it in next version.