From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCH v8 09/21] omap3isp: Fix check for our own sub-devices Date: Wed, 6 Sep 2017 09:45:14 +0200 Message-ID: <36648f59-4ea1-8137-8e7a-5c8e497bc664@xs4all.nl> References: <20170905130553.1332-1-sakari.ailus@linux.intel.com> <20170905130553.1332-10-sakari.ailus@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170905130553.1332-10-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sakari Ailus , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: niklas.soderlund-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pavel-+ZI9xUNit7I@public.gmane.org, sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On 09/05/2017 03:05 PM, Sakari Ailus wrote: > We only want to link sub-devices that were bound to the async notifier the > isp driver registered but there may be other sub-devices in the > v4l2_device as well. Check for the correct async notifier. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Regards, Hans > --- > drivers/media/platform/omap3isp/isp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a546cf774d40..3b1a9cd0e591 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -2155,7 +2155,7 @@ static int isp_subdev_notifier_complete(struct v4l2_async_notifier *async) > return ret; > > list_for_each_entry(sd, &v4l2_dev->subdevs, list) { > - if (!sd->asd) > + if (sd->notifier != &isp->notifier) > continue; > > ret = isp_link_entity(isp, &sd->entity, > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb3-smtp-cloud7.xs4all.net ([194.109.24.31]:42504 "EHLO lb3-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbdIFHpS (ORCPT ); Wed, 6 Sep 2017 03:45:18 -0400 Subject: Re: [PATCH v8 09/21] omap3isp: Fix check for our own sub-devices To: Sakari Ailus , linux-media@vger.kernel.org Cc: niklas.soderlund@ragnatech.se, robh@kernel.org, laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org, pavel@ucw.cz, sre@kernel.org References: <20170905130553.1332-1-sakari.ailus@linux.intel.com> <20170905130553.1332-10-sakari.ailus@linux.intel.com> From: Hans Verkuil Message-ID: <36648f59-4ea1-8137-8e7a-5c8e497bc664@xs4all.nl> Date: Wed, 6 Sep 2017 09:45:14 +0200 MIME-Version: 1.0 In-Reply-To: <20170905130553.1332-10-sakari.ailus@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 09/05/2017 03:05 PM, Sakari Ailus wrote: > We only want to link sub-devices that were bound to the async notifier the > isp driver registered but there may be other sub-devices in the > v4l2_device as well. Check for the correct async notifier. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Regards, Hans > --- > drivers/media/platform/omap3isp/isp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a546cf774d40..3b1a9cd0e591 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -2155,7 +2155,7 @@ static int isp_subdev_notifier_complete(struct v4l2_async_notifier *async) > return ret; > > list_for_each_entry(sd, &v4l2_dev->subdevs, list) { > - if (!sd->asd) > + if (sd->notifier != &isp->notifier) > continue; > > ret = isp_link_entity(isp, &sd->entity, >