From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BF04C43334 for ; Mon, 13 Jun 2022 08:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7AySEsK52i+Wx83A7sQeWaMZyMLR6uzU9rxJQkjL8lk=; b=VlGAJmNl9wDb34 ow1lqF7GV2iN3uOJ1y9gkra4+QYdLjvT1R48e1BewBC9jSgqZMCB/Ssc00VOHmLXfdsCCAMGwWpMs stV+4nh08Q/zJrsvVj7owjiVsXYQwIHvJzuzGvYtx8s7KP0Fx4zY3wGXRNF2TSgqUhvsu9SU5Ickf oNcx7nQlFupDGWs7Z3Dda1k9ce/y80lcW8VPbLJcFx0QXfvY0zmSSd5n/0muzsrqUGNeXENZDXL+m Qenl9KfkKrTyvZuxqdkb66AIV8ZQy3ahFvqo55kE911HC6O0vrcin9dlywtR6MmmlBjHteo8np7RG yYomQ13HbHphqSdj8BNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0ftn-002Mfi-D7; Mon, 13 Jun 2022 08:58:15 +0000 Received: from smtpout2.mo529.mail-out.ovh.net ([79.137.123.220]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0ftk-002MeU-9A for linux-arm-kernel@lists.infradead.org; Mon, 13 Jun 2022 08:58:14 +0000 Received: from mxplan5.mail.ovh.net (unknown [10.108.16.33]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id C1C1D10B2A5BF; Mon, 13 Jun 2022 10:58:00 +0200 (CEST) Received: from kaod.org (37.59.142.103) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Mon, 13 Jun 2022 10:57:59 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-103G0056971c037-d388-4246-bc66-55455572b859, DD436A6F49FCC46F63A45CA4D245122A41FF8289) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <367135b2-e5c0-3ebb-9ad2-2a78b2c6af2f@kaod.org> Date: Mon, 13 Jun 2022 10:57:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] spi: aspeed: Fix division by zero Content-Language: en-US To: Pratyush Yadav CC: , Mark Brown , , , Joel Stanley , Andrew Jeffery , Chin-Ting Kuo , , , Ian Woloschin References: <20220611103929.1484062-1-clg@kaod.org> <20220613083952.4z45ulaxdy2okbho@ti.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20220613083952.4z45ulaxdy2okbho@ti.com> X-Originating-IP: [37.59.142.103] X-ClientProxiedBy: DAG6EX2.mxp5.local (172.16.2.52) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: e1c48708-fe1b-4eaa-9e99-a4a0e338ddee X-Ovh-Tracer-Id: 18165269099526065141 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedruddujedgtdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeekteejtdelkeejvdevffduhfetteelieefgeefffeugffhfeekheffueefledujeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehirghnrdifohhlohhstghhihhnsegrkhgrmhgrihdrtghomhdpoffvtefjohhsthepmhhohedvle X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_015812_509304_ABBCBF56 X-CRM114-Status: GOOD ( 14.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gNi8xMy8yMiAxMDozOSwgUHJhdHl1c2ggWWFkYXYgd3JvdGU6Cj4gT24gMTEvMDYvMjIgMTI6 MzlQTSwgQ8OpZHJpYyBMZSBHb2F0ZXIgd3JvdGU6Cj4+IFdoZW4gdXNpbmcgdGhlIG5vcm1hbCBy ZWFkIG9wZXJhdGlvbiBmb3IgZGF0YSB0cmFuc2ZlcnMsIHRoZSBkdW1teSBidXMKPj4gd2lkdGgg aXMgemVyby4gSW4gdGhhdCBjYXNlLCB0aGV5IGFyZSBubyBkdW1teSBieXRlcyB0byB0cmFuc2Zl ciBhbmQKPj4gc2V0dGluZyB0aGUgZHVtbXkgZmllbGQgaW4gdGhlIGNvbnRyb2xsZXIgcmVnaXN0 ZXIgYmVjb21lcyB1c2VsZXNzLgo+Pgo+PiBJc3N1ZSB3YXMgZm91bmQgb24gYSBjdXN0b20gIkJp ZnJvc3QiIGJvYXJkIHdpdGggYSBBU1QyNTAwIFNvQyBhbmQKPj4gdXNpbmcgYSBNWDI1TDUxMjQ1 R01JLTA4RyBTUEkgRmxhc2guCj4+Cj4+IENjOiBDaGluLVRpbmcgS3VvIDxjaGluLXRpbmdfa3Vv QGFzcGVlZHRlY2guY29tPgo+PiBSZXBvcnRlZC1ieTogSWFuIFdvbG9zY2hpbiA8aWFuLndvbG9z Y2hpbkBha2FtYWkuY29tPgo+PiBGaXhlczogNTQ2MTNmYzY2NTliICgic3BpOiBhc3BlZWQ6IEFk ZCBzdXBwb3J0IGZvciBkaXJlY3QgbWFwcGluZyIpCj4+IFNpZ25lZC1vZmYtYnk6IEPDqWRyaWMg TGUgR29hdGVyIDxjbGdAa2FvZC5vcmc+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvc3BpL3NwaS1hc3Bl ZWQtc21jLmMgfCAxMiArKysrKysrKysrKy0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zcGkvc3Bp LWFzcGVlZC1zbWMuYyBiL2RyaXZlcnMvc3BpL3NwaS1hc3BlZWQtc21jLmMKPj4gaW5kZXggNDk2 ZjNlMWU5MDc5Li4zZTg5MWJmMjI0NzAgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvc3BpL3NwaS1h c3BlZWQtc21jLmMKPj4gKysrIGIvZHJpdmVycy9zcGkvc3BpLWFzcGVlZC1zbWMuYwo+PiBAQCAt NTU4LDYgKzU1OCwxNCBAQCBzdGF0aWMgaW50IGFzcGVlZF9zcGlfZGlybWFwX2NyZWF0ZShzdHJ1 Y3Qgc3BpX21lbV9kaXJtYXBfZGVzYyAqZGVzYykKPj4gICAJdTMyIGN0bF92YWw7Cj4+ICAgCWlu dCByZXQgPSAwOwo+PiAgIAo+PiArCWRldl9kYmcoYXNwaS0+ZGV2LAo+PiArCQkiQ0UlZCAlcyBk aXJtYXAgWyAweCUuOGxseCAtIDB4JS44bGx4IF0gT1AgJSN4IG1vZGU6JWQuJWQuJWQuJWQgbmFk ZHI6JSN4IG5kdW1taWVzOiUjeFxuIiwKPj4gKwkJY2hpcC0+Y3MsIG9wLT5kYXRhLmRpciA9PSBT UElfTUVNX0RBVEFfSU4gPyAicmVhZCIgOiAid3JpdGUiLAo+PiArCQlkZXNjLT5pbmZvLm9mZnNl dCwgZGVzYy0+aW5mby5vZmZzZXQgKyBkZXNjLT5pbmZvLmxlbmd0aCwKPj4gKwkJb3AtPmNtZC5v cGNvZGUsIG9wLT5jbWQuYnVzd2lkdGgsIG9wLT5hZGRyLmJ1c3dpZHRoLAo+PiArCQlvcC0+ZHVt bXkuYnVzd2lkdGgsIG9wLT5kYXRhLmJ1c3dpZHRoLAo+PiArCQlvcC0+YWRkci5uYnl0ZXMsIG9w LT5kdW1teS5uYnl0ZXMpOwo+PiArCj4gCj4gVW5yZWxhdGVkIGNoYW5nZS4gUGxlYXNlIHNlbmQg YXMgYSBzZXBhcmF0ZSBwYXRjaC4KCk9LLgogIAo+PiAgIAljaGlwLT5jbGtfZnJlcSA9IGRlc2Mt Pm1lbS0+c3BpLT5tYXhfc3BlZWRfaHo7Cj4+ICAgCj4+ICAgCS8qIE9ubHkgZm9yIHJlYWRzICov Cj4+IEBAIC01NzQsOSArNTgyLDExIEBAIHN0YXRpYyBpbnQgYXNwZWVkX3NwaV9kaXJtYXBfY3Jl YXRlKHN0cnVjdCBzcGlfbWVtX2Rpcm1hcF9kZXNjICpkZXNjKQo+PiAgIAljdGxfdmFsID0gcmVh ZGwoY2hpcC0+Y3RsKSAmIH5DVFJMX0lPX0NNRF9NQVNLOwo+PiAgIAljdGxfdmFsIHw9IGFzcGVl ZF9zcGlfZ2V0X2lvX21vZGUob3ApIHwKPj4gICAJCW9wLT5jbWQub3Bjb2RlIDw8IENUUkxfQ09N TUFORF9TSElGVCB8Cj4+IC0JCUNUUkxfSU9fRFVNTVlfU0VUKG9wLT5kdW1teS5uYnl0ZXMgLyBv cC0+ZHVtbXkuYnVzd2lkdGgpIHwKPj4gICAJCUNUUkxfSU9fTU9ERV9SRUFEOwo+PiAgIAo+PiAr CWlmIChvcC0+ZHVtbXkubmJ5dGVzKQo+PiArCQljdGxfdmFsIHw9IENUUkxfSU9fRFVNTVlfU0VU KG9wLT5kdW1teS5uYnl0ZXMgLyBvcC0+ZHVtbXkuYnVzd2lkdGgpOwo+PiArCj4gCj4gTEdUTS4g V2l0aCB0aGUgYWJvdmUgZml4ZWQsCj4KPiBSZXZpZXdlZC1ieTogUHJhdHl1c2ggWWFkYXYgPHAu eWFkYXZAdGkuY29tPgoKVGhhbmtzLAoKQy4KCj4gCj4+ICAgCS8qIFR1bmUgNEJZVEUgYWRkcmVz cyBtb2RlICovCj4+ICAgCWlmIChvcC0+YWRkci5uYnl0ZXMpIHsKPj4gICAJCXUzMiBhZGRyX21v ZGUgPSByZWFkbChhc3BpLT5yZWdzICsgQ0VfQ1RSTF9SRUcpOwo+PiAtLSAKPj4gMi4zNS4zCj4+ Cj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D93C43334 for ; Mon, 13 Jun 2022 09:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240992AbiFMJtD (ORCPT ); Mon, 13 Jun 2022 05:49:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241139AbiFMJsz (ORCPT ); Mon, 13 Jun 2022 05:48:55 -0400 X-Greylist: delayed 1538 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 13 Jun 2022 02:48:50 PDT Received: from smtpout1.mo529.mail-out.ovh.net (smtpout1.mo529.mail-out.ovh.net [178.32.125.2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B75E18B3F for ; Mon, 13 Jun 2022 02:48:49 -0700 (PDT) Received: from mxplan5.mail.ovh.net (unknown [10.108.16.33]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id C1C1D10B2A5BF; Mon, 13 Jun 2022 10:58:00 +0200 (CEST) Received: from kaod.org (37.59.142.103) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Mon, 13 Jun 2022 10:57:59 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-103G0056971c037-d388-4246-bc66-55455572b859, DD436A6F49FCC46F63A45CA4D245122A41FF8289) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <367135b2-e5c0-3ebb-9ad2-2a78b2c6af2f@kaod.org> Date: Mon, 13 Jun 2022 10:57:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] spi: aspeed: Fix division by zero Content-Language: en-US To: Pratyush Yadav CC: , Mark Brown , , , Joel Stanley , Andrew Jeffery , Chin-Ting Kuo , , , Ian Woloschin References: <20220611103929.1484062-1-clg@kaod.org> <20220613083952.4z45ulaxdy2okbho@ti.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20220613083952.4z45ulaxdy2okbho@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.103] X-ClientProxiedBy: DAG6EX2.mxp5.local (172.16.2.52) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: e1c48708-fe1b-4eaa-9e99-a4a0e338ddee X-Ovh-Tracer-Id: 18165269099526065141 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedruddujedgtdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeekteejtdelkeejvdevffduhfetteelieefgeefffeugffhfeekheffueefledujeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehirghnrdifohhlohhstghhihhnsegrkhgrmhgrihdrtghomhdpoffvtefjohhsthepmhhohedvle Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/13/22 10:39, Pratyush Yadav wrote: > On 11/06/22 12:39PM, Cédric Le Goater wrote: >> When using the normal read operation for data transfers, the dummy bus >> width is zero. In that case, they are no dummy bytes to transfer and >> setting the dummy field in the controller register becomes useless. >> >> Issue was found on a custom "Bifrost" board with a AST2500 SoC and >> using a MX25L51245GMI-08G SPI Flash. >> >> Cc: Chin-Ting Kuo >> Reported-by: Ian Woloschin >> Fixes: 54613fc6659b ("spi: aspeed: Add support for direct mapping") >> Signed-off-by: Cédric Le Goater >> --- >> drivers/spi/spi-aspeed-smc.c | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c >> index 496f3e1e9079..3e891bf22470 100644 >> --- a/drivers/spi/spi-aspeed-smc.c >> +++ b/drivers/spi/spi-aspeed-smc.c >> @@ -558,6 +558,14 @@ static int aspeed_spi_dirmap_create(struct spi_mem_dirmap_desc *desc) >> u32 ctl_val; >> int ret = 0; >> >> + dev_dbg(aspi->dev, >> + "CE%d %s dirmap [ 0x%.8llx - 0x%.8llx ] OP %#x mode:%d.%d.%d.%d naddr:%#x ndummies:%#x\n", >> + chip->cs, op->data.dir == SPI_MEM_DATA_IN ? "read" : "write", >> + desc->info.offset, desc->info.offset + desc->info.length, >> + op->cmd.opcode, op->cmd.buswidth, op->addr.buswidth, >> + op->dummy.buswidth, op->data.buswidth, >> + op->addr.nbytes, op->dummy.nbytes); >> + > > Unrelated change. Please send as a separate patch. OK. >> chip->clk_freq = desc->mem->spi->max_speed_hz; >> >> /* Only for reads */ >> @@ -574,9 +582,11 @@ static int aspeed_spi_dirmap_create(struct spi_mem_dirmap_desc *desc) >> ctl_val = readl(chip->ctl) & ~CTRL_IO_CMD_MASK; >> ctl_val |= aspeed_spi_get_io_mode(op) | >> op->cmd.opcode << CTRL_COMMAND_SHIFT | >> - CTRL_IO_DUMMY_SET(op->dummy.nbytes / op->dummy.buswidth) | >> CTRL_IO_MODE_READ; >> >> + if (op->dummy.nbytes) >> + ctl_val |= CTRL_IO_DUMMY_SET(op->dummy.nbytes / op->dummy.buswidth); >> + > > LGTM. With the above fixed, > > Reviewed-by: Pratyush Yadav Thanks, C. > >> /* Tune 4BYTE address mode */ >> if (op->addr.nbytes) { >> u32 addr_mode = readl(aspi->regs + CE_CTRL_REG); >> -- >> 2.35.3 >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FDC3C433EF for ; Mon, 13 Jun 2022 09:23:41 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LM5j75M69z3c7b for ; Mon, 13 Jun 2022 19:23:39 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kaod.org (client-ip=79.137.123.220; helo=smtpout2.mo529.mail-out.ovh.net; envelope-from=clg@kaod.org; receiver=) X-Greylist: delayed 895 seconds by postgrey-1.36 at boromir; Mon, 13 Jun 2022 19:23:14 AEST Received: from smtpout2.mo529.mail-out.ovh.net (smtpout2.mo529.mail-out.ovh.net [79.137.123.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LM5hf3plyz3bdF for ; Mon, 13 Jun 2022 19:23:11 +1000 (AEST) Received: from mxplan5.mail.ovh.net (unknown [10.108.16.33]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id C1C1D10B2A5BF; Mon, 13 Jun 2022 10:58:00 +0200 (CEST) Received: from kaod.org (37.59.142.103) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Mon, 13 Jun 2022 10:57:59 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-103G0056971c037-d388-4246-bc66-55455572b859, DD436A6F49FCC46F63A45CA4D245122A41FF8289) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <367135b2-e5c0-3ebb-9ad2-2a78b2c6af2f@kaod.org> Date: Mon, 13 Jun 2022 10:57:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] spi: aspeed: Fix division by zero Content-Language: en-US To: Pratyush Yadav References: <20220611103929.1484062-1-clg@kaod.org> <20220613083952.4z45ulaxdy2okbho@ti.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20220613083952.4z45ulaxdy2okbho@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.103] X-ClientProxiedBy: DAG6EX2.mxp5.local (172.16.2.52) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: e1c48708-fe1b-4eaa-9e99-a4a0e338ddee X-Ovh-Tracer-Id: 18165269099526065141 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedruddujedgtdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeekteejtdelkeejvdevffduhfetteelieefgeefffeugffhfeekheffueefledujeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehirghnrdifohhlohhstghhihhnsegrkhgrmhgrihdrtghomhdpoffvtefjohhsthepmhhohedvle X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Andrew Jeffery , openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , Joel Stanley , Ian Woloschin , Chin-Ting Kuo , linux-arm-kernel@lists.infradead.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On 6/13/22 10:39, Pratyush Yadav wrote: > On 11/06/22 12:39PM, Cédric Le Goater wrote: >> When using the normal read operation for data transfers, the dummy bus >> width is zero. In that case, they are no dummy bytes to transfer and >> setting the dummy field in the controller register becomes useless. >> >> Issue was found on a custom "Bifrost" board with a AST2500 SoC and >> using a MX25L51245GMI-08G SPI Flash. >> >> Cc: Chin-Ting Kuo >> Reported-by: Ian Woloschin >> Fixes: 54613fc6659b ("spi: aspeed: Add support for direct mapping") >> Signed-off-by: Cédric Le Goater >> --- >> drivers/spi/spi-aspeed-smc.c | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c >> index 496f3e1e9079..3e891bf22470 100644 >> --- a/drivers/spi/spi-aspeed-smc.c >> +++ b/drivers/spi/spi-aspeed-smc.c >> @@ -558,6 +558,14 @@ static int aspeed_spi_dirmap_create(struct spi_mem_dirmap_desc *desc) >> u32 ctl_val; >> int ret = 0; >> >> + dev_dbg(aspi->dev, >> + "CE%d %s dirmap [ 0x%.8llx - 0x%.8llx ] OP %#x mode:%d.%d.%d.%d naddr:%#x ndummies:%#x\n", >> + chip->cs, op->data.dir == SPI_MEM_DATA_IN ? "read" : "write", >> + desc->info.offset, desc->info.offset + desc->info.length, >> + op->cmd.opcode, op->cmd.buswidth, op->addr.buswidth, >> + op->dummy.buswidth, op->data.buswidth, >> + op->addr.nbytes, op->dummy.nbytes); >> + > > Unrelated change. Please send as a separate patch. OK. >> chip->clk_freq = desc->mem->spi->max_speed_hz; >> >> /* Only for reads */ >> @@ -574,9 +582,11 @@ static int aspeed_spi_dirmap_create(struct spi_mem_dirmap_desc *desc) >> ctl_val = readl(chip->ctl) & ~CTRL_IO_CMD_MASK; >> ctl_val |= aspeed_spi_get_io_mode(op) | >> op->cmd.opcode << CTRL_COMMAND_SHIFT | >> - CTRL_IO_DUMMY_SET(op->dummy.nbytes / op->dummy.buswidth) | >> CTRL_IO_MODE_READ; >> >> + if (op->dummy.nbytes) >> + ctl_val |= CTRL_IO_DUMMY_SET(op->dummy.nbytes / op->dummy.buswidth); >> + > > LGTM. With the above fixed, > > Reviewed-by: Pratyush Yadav Thanks, C. > >> /* Tune 4BYTE address mode */ >> if (op->addr.nbytes) { >> u32 addr_mode = readl(aspi->regs + CE_CTRL_REG); >> -- >> 2.35.3 >> >