From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8054BC433F5 for ; Sat, 23 Apr 2022 08:02:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234151AbiDWIFG (ORCPT ); Sat, 23 Apr 2022 04:05:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231787AbiDWIFA (ORCPT ); Sat, 23 Apr 2022 04:05:00 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE28A1035 for ; Sat, 23 Apr 2022 01:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650700924; x=1682236924; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=oYSa9eG/ZLGjKfhpFORv9gMTTxmsCZoyxnq7RTpNwu0=; b=IRLMsWjBX6XtasNzPJMjx70D8b63WzmkSIRcZvWhbWuOl8azMD3sceU2 rsUJF9qYXgJVk8f1E+psAdmu7crzjG0YO2gFqkMoY7R3Ix1rLXJMcTvxm DBQ4fcfC0oDCW9bLquw+8AajFwJcOTx1XvJkJlBCw2hAzeljkBsF+36oa c2LVy2BinSAZ3R2CKqAkx4l9N6HV5R1G//Hh2s+OedgHH3BKQtUtYYBUP aYGFhfalfVHhmyRMw24BrinVDql/m3npO0lMcfHRpc0BtVejFh6FffSto +hPT3ImaqzhBVpRvqb5mqlF0E7EMLVBplhR3SABMFYQuskJaqButSLTO6 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="265034545" X-IronPort-AV: E=Sophos;i="5.90,284,1643702400"; d="scan'208";a="265034545" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2022 01:02:04 -0700 X-IronPort-AV: E=Sophos;i="5.90,284,1643702400"; d="scan'208";a="578312714" Received: from yjsun1-mobl.ccr.corp.intel.com (HELO [10.255.31.217]) ([10.255.31.217]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2022 01:02:00 -0700 Message-ID: <36764562-ad54-b192-4084-842fee8fca78@linux.intel.com> Date: Sat, 23 Apr 2022 16:01:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 02/13] iommu: Move bus setup to IOMMU device registration Content-Language: en-US To: Robin Murphy , joro@8bytes.org, will@kernel.org Cc: iommu@lists.linux-foundation.org, sven@svenpeter.dev, robdclark@gmail.com, m.szyprowski@samsung.com, yong.wu@mediatek.com, mjrosato@linux.ibm.com, gerald.schaefer@linux.ibm.com, zhang.lyra@gmail.com, thierry.reding@gmail.com, vdumpa@nvidia.com, jean-philippe@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1d9a2146-9e48-ba97-d049-5d2332ebbd3a@arm.com> <7f693a3a-bbab-237a-af9a-4395e501a5b2@arm.com> From: Lu Baolu In-Reply-To: <7f693a3a-bbab-237a-af9a-4395e501a5b2@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robin, On 2022/4/19 15:20, Robin Murphy wrote: > On 2022-04-19 00:37, Lu Baolu wrote: >> On 2022/4/19 6:09, Robin Murphy wrote: >>> On 2022-04-16 01:04, Lu Baolu wrote: >>>> On 2022/4/14 20:42, Robin Murphy wrote: >>>>> @@ -1883,27 +1900,12 @@ static int iommu_bus_init(struct bus_type >>>>> *bus) >>>>>    */ >>>>>   int bus_set_iommu(struct bus_type *bus, const struct iommu_ops *ops) >>>>>   { >>>>> -    int err; >>>>> - >>>>> -    if (ops == NULL) { >>>>> -        bus->iommu_ops = NULL; >>>>> -        return 0; >>>>> -    } >>>>> - >>>>> -    if (bus->iommu_ops != NULL) >>>>> +    if (bus->iommu_ops && ops && bus->iommu_ops != ops) >>>>>           return -EBUSY; >>>>>       bus->iommu_ops = ops; >>>> >>>> Do we still need to keep above lines in bus_set_iommu()? >>> >>> It preserves the existing behaviour until each callsite and its >>> associated error handling are removed later on, which seems like as >>> good a thing to do as any. Since I'm already relaxing >>> iommu_device_register() to a warn-but-continue behaviour while it >>> keeps the bus ops on life-support internally, I figured not changing >>> too much at once would make it easier to bisect any potential issues >>> arising from this first step. >> >> Fair enough. Thank you for the explanation. >> >> Do you have a public tree that I could pull these patches and try them >> on an Intel hardware? Or perhaps you have done this? I like the whole >> idea of this series, but it's better to try it with a real hardware. > > I haven't bothered with separate branches since there's so many > different pieces in-flight, but my complete (unstable) development > branch can be found here: > > https://gitlab.arm.com/linux-arm/linux-rm/-/commits/iommu/bus > > For now I'd recommend winding the head back to "iommu: Clean up > bus_set_iommu()" for testing - some of the patches above that have > already been posted and picked up by their respective subsystems, but > others are incomplete and barely compile-tested. I'll probably rearrange > it later this week to better reflect what's happened so far. I wound the head back to "iommu: Clean up bus_set_iommu" and tested it on an Intel machine. It got stuck during boot. This test was on a remote machine and I have no means to access it physically. So I can't get any kernel debugging messages. (I have to work from home these days. :-() I guess it's due to the fact that intel_iommu_probe_device() callback only works for the pci devices. The issue occurs when probing a device other than a PCI one. Best regards, baolu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80B7BC433F5 for ; Sat, 23 Apr 2022 08:02:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 16FF76058B; Sat, 23 Apr 2022 08:02:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jb5tQXETOWvz; Sat, 23 Apr 2022 08:02:10 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id CA72060615; Sat, 23 Apr 2022 08:02:09 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A4A4BC0039; Sat, 23 Apr 2022 08:02:09 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 823C9C002D for ; Sat, 23 Apr 2022 08:02:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 6FA82832A9 for ; Sat, 23 Apr 2022 08:02:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZgOI05HuJGQ0 for ; Sat, 23 Apr 2022 08:02:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4968483294 for ; Sat, 23 Apr 2022 08:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650700925; x=1682236925; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=oYSa9eG/ZLGjKfhpFORv9gMTTxmsCZoyxnq7RTpNwu0=; b=YwbPFJYI2FU8lWbYN26l2i0vYKw7dhzuOG8up5aDqKcwStJQ+deqJ3id eVfeFFHQv69DirekLq5N0FfuibT3EaPGqlWQACn7jYzXYfyBgYr1jeKHY 7tBUmZxrrE0Piv21Z3XUV11ZAczgCv9juC50T7qEe5p0pbLMV30vfMgKy fG1zM23M1q/ydZ1Xj/2Z03L1vSDd96H3uLqIH/pQpsuXchqae+MGLzpA8 qW5KahI6CONeXB8gWvbOeQkyTUJuCP2MZwncRV+Q48um8C2tSGxByk3Je kEDwMdEmzCWdCpb45RWigcF5+szr9TcyRQ02rJLGxcvajvpDK8XGfrd2b A==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="262459465" X-IronPort-AV: E=Sophos;i="5.90,284,1643702400"; d="scan'208";a="262459465" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2022 01:02:04 -0700 X-IronPort-AV: E=Sophos;i="5.90,284,1643702400"; d="scan'208";a="578312714" Received: from yjsun1-mobl.ccr.corp.intel.com (HELO [10.255.31.217]) ([10.255.31.217]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2022 01:02:00 -0700 Message-ID: <36764562-ad54-b192-4084-842fee8fca78@linux.intel.com> Date: Sat, 23 Apr 2022 16:01:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 02/13] iommu: Move bus setup to IOMMU device registration Content-Language: en-US To: Robin Murphy , joro@8bytes.org, will@kernel.org References: <1d9a2146-9e48-ba97-d049-5d2332ebbd3a@arm.com> <7f693a3a-bbab-237a-af9a-4395e501a5b2@arm.com> From: Lu Baolu In-Reply-To: <7f693a3a-bbab-237a-af9a-4395e501a5b2@arm.com> Cc: jean-philippe@linaro.org, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org, gerald.schaefer@linux.ibm.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" SGkgUm9iaW4sCgpPbiAyMDIyLzQvMTkgMTU6MjAsIFJvYmluIE11cnBoeSB3cm90ZToKPiBPbiAy MDIyLTA0LTE5IDAwOjM3LCBMdSBCYW9sdSB3cm90ZToKPj4gT24gMjAyMi80LzE5IDY6MDksIFJv YmluIE11cnBoeSB3cm90ZToKPj4+IE9uIDIwMjItMDQtMTYgMDE6MDQsIEx1IEJhb2x1IHdyb3Rl Ogo+Pj4+IE9uIDIwMjIvNC8xNCAyMDo0MiwgUm9iaW4gTXVycGh5IHdyb3RlOgo+Pj4+PiBAQCAt MTg4MywyNyArMTkwMCwxMiBAQCBzdGF0aWMgaW50IGlvbW11X2J1c19pbml0KHN0cnVjdCBidXNf dHlwZSAKPj4+Pj4gKmJ1cykKPj4+Pj4gwqDCoCAqLwo+Pj4+PiDCoCBpbnQgYnVzX3NldF9pb21t dShzdHJ1Y3QgYnVzX3R5cGUgKmJ1cywgY29uc3Qgc3RydWN0IGlvbW11X29wcyAqb3BzKQo+Pj4+ PiDCoCB7Cj4+Pj4+IC3CoMKgwqAgaW50IGVycjsKPj4+Pj4gLQo+Pj4+PiAtwqDCoMKgIGlmIChv cHMgPT0gTlVMTCkgewo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgYnVzLT5pb21tdV9vcHMgPSBOVUxM Owo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7Cj4+Pj4+IC3CoMKgwqAgfQo+Pj4+PiAt Cj4+Pj4+IC3CoMKgwqAgaWYgKGJ1cy0+aW9tbXVfb3BzICE9IE5VTEwpCj4+Pj4+ICvCoMKgwqAg aWYgKGJ1cy0+aW9tbXVfb3BzICYmIG9wcyAmJiBidXMtPmlvbW11X29wcyAhPSBvcHMpCj4+Pj4+ IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVCVVNZOwo+Pj4+PiDCoMKgwqDCoMKgIGJ1cy0+ aW9tbXVfb3BzID0gb3BzOwo+Pj4+Cj4+Pj4gRG8gd2Ugc3RpbGwgbmVlZCB0byBrZWVwIGFib3Zl IGxpbmVzIGluIGJ1c19zZXRfaW9tbXUoKT8KPj4+Cj4+PiBJdCBwcmVzZXJ2ZXMgdGhlIGV4aXN0 aW5nIGJlaGF2aW91ciB1bnRpbCBlYWNoIGNhbGxzaXRlIGFuZCBpdHMgCj4+PiBhc3NvY2lhdGVk IGVycm9yIGhhbmRsaW5nIGFyZSByZW1vdmVkIGxhdGVyIG9uLCB3aGljaCBzZWVtcyBsaWtlIGFz IAo+Pj4gZ29vZCBhIHRoaW5nIHRvIGRvIGFzIGFueS4gU2luY2UgSSdtIGFscmVhZHkgcmVsYXhp bmcgCj4+PiBpb21tdV9kZXZpY2VfcmVnaXN0ZXIoKSB0byBhIHdhcm4tYnV0LWNvbnRpbnVlIGJl aGF2aW91ciB3aGlsZSBpdCAKPj4+IGtlZXBzIHRoZSBidXMgb3BzIG9uIGxpZmUtc3VwcG9ydCBp bnRlcm5hbGx5LCBJIGZpZ3VyZWQgbm90IGNoYW5naW5nIAo+Pj4gdG9vIG11Y2ggYXQgb25jZSB3 b3VsZCBtYWtlIGl0IGVhc2llciB0byBiaXNlY3QgYW55IHBvdGVudGlhbCBpc3N1ZXMgCj4+PiBh cmlzaW5nIGZyb20gdGhpcyBmaXJzdCBzdGVwLgo+Pgo+PiBGYWlyIGVub3VnaC4gVGhhbmsgeW91 IGZvciB0aGUgZXhwbGFuYXRpb24uCj4+Cj4+IERvIHlvdSBoYXZlIGEgcHVibGljIHRyZWUgdGhh dCBJIGNvdWxkIHB1bGwgdGhlc2UgcGF0Y2hlcyBhbmQgdHJ5IHRoZW0KPj4gb24gYW4gSW50ZWwg aGFyZHdhcmU/IE9yIHBlcmhhcHMgeW91IGhhdmUgZG9uZSB0aGlzPyBJIGxpa2UgdGhlIHdob2xl Cj4+IGlkZWEgb2YgdGhpcyBzZXJpZXMsIGJ1dCBpdCdzIGJldHRlciB0byB0cnkgaXQgd2l0aCBh IHJlYWwgaGFyZHdhcmUuCj4gCj4gSSBoYXZlbid0IGJvdGhlcmVkIHdpdGggc2VwYXJhdGUgYnJh bmNoZXMgc2luY2UgdGhlcmUncyBzbyBtYW55IAo+IGRpZmZlcmVudCBwaWVjZXMgaW4tZmxpZ2h0 LCBidXQgbXkgY29tcGxldGUgKHVuc3RhYmxlKSBkZXZlbG9wbWVudCAKPiBicmFuY2ggY2FuIGJl IGZvdW5kIGhlcmU6Cj4gCj4gaHR0cHM6Ly9naXRsYWIuYXJtLmNvbS9saW51eC1hcm0vbGludXgt cm0vLS9jb21taXRzL2lvbW11L2J1cwo+IAo+IEZvciBub3cgSSdkIHJlY29tbWVuZCB3aW5kaW5n IHRoZSBoZWFkIGJhY2sgdG8gImlvbW11OiBDbGVhbiB1cCAKPiBidXNfc2V0X2lvbW11KCkiIGZv ciB0ZXN0aW5nIC0gc29tZSBvZiB0aGUgcGF0Y2hlcyBhYm92ZSB0aGF0IGhhdmUgCj4gYWxyZWFk eSBiZWVuIHBvc3RlZCBhbmQgcGlja2VkIHVwIGJ5IHRoZWlyIHJlc3BlY3RpdmUgc3Vic3lzdGVt cywgYnV0IAo+IG90aGVycyBhcmUgaW5jb21wbGV0ZSBhbmQgYmFyZWx5IGNvbXBpbGUtdGVzdGVk LiBJJ2xsIHByb2JhYmx5IHJlYXJyYW5nZSAKPiBpdCBsYXRlciB0aGlzIHdlZWsgdG8gYmV0dGVy IHJlZmxlY3Qgd2hhdCdzIGhhcHBlbmVkIHNvIGZhci4KCkkgd291bmQgdGhlIGhlYWQgYmFjayB0 byAiaW9tbXU6IENsZWFuIHVwIGJ1c19zZXRfaW9tbXUiIGFuZCB0ZXN0ZWQgaXQKb24gYW4gSW50 ZWwgbWFjaGluZS4gSXQgZ290IHN0dWNrIGR1cmluZyBib290LiBUaGlzIHRlc3Qgd2FzIG9uIGEg cmVtb3RlCm1hY2hpbmUgYW5kIEkgaGF2ZSBubyBtZWFucyB0byBhY2Nlc3MgaXQgcGh5c2ljYWxs eS4gU28gSSBjYW4ndCBnZXQgYW55Cmtlcm5lbCBkZWJ1Z2dpbmcgbWVzc2FnZXMuIChJIGhhdmUg dG8gd29yayBmcm9tIGhvbWUgdGhlc2UgZGF5cy4gOi0oKQoKSSBndWVzcyBpdCdzIGR1ZSB0byB0 aGUgZmFjdCB0aGF0IGludGVsX2lvbW11X3Byb2JlX2RldmljZSgpIGNhbGxiYWNrCm9ubHkgd29y a3MgZm9yIHRoZSBwY2kgZGV2aWNlcy4gVGhlIGlzc3VlIG9jY3VycyB3aGVuIHByb2JpbmcgYSBk ZXZpY2UKb3RoZXIgdGhhbiBhIFBDSSBvbmUuCgpCZXN0IHJlZ2FyZHMsCmJhb2x1Cl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcgbGlz dAppb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91 bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17446C433EF for ; Sat, 23 Apr 2022 08:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7sxiTAanUyz4hcCwUQEs/wNkdEqmyJWUnnm2LqHZknk=; b=FCVb73SNm9m89Kf9nErVgzXKAS 6/mN39fgniMq2tzBND9u5tdeJlcFGt2arcU9yADc2kkSztu3Oda/HnfahDZXuh1m83avydAVn5/93 1nfOcRRbyLpsEud595aXssUSdIv1apKMOaE5ZE0kF3q4rd0KL8FoDV/XN/XfPiE/iaJq6UPaIQFEy Pn5dI+ec7IO3P4p/9JD7ywi0VMsRwSMmK0YTRNvI6ZnjTH6MMye69Kdnvpq4ztrcANqFb31KybE2l cSvP04caVYMbMoMlrTA+Vms623gE+mLCIVZAacdgKLSRBR5u2naSumUsr4Q3Gj8JG8AcTvoFp4LT7 p3lDYL3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1niAiX-003o3k-0H; Sat, 23 Apr 2022 08:02:09 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1niAiT-003o2m-Qb for linux-arm-kernel@lists.infradead.org; Sat, 23 Apr 2022 08:02:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650700925; x=1682236925; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=oYSa9eG/ZLGjKfhpFORv9gMTTxmsCZoyxnq7RTpNwu0=; b=YwbPFJYI2FU8lWbYN26l2i0vYKw7dhzuOG8up5aDqKcwStJQ+deqJ3id eVfeFFHQv69DirekLq5N0FfuibT3EaPGqlWQACn7jYzXYfyBgYr1jeKHY 7tBUmZxrrE0Piv21Z3XUV11ZAczgCv9juC50T7qEe5p0pbLMV30vfMgKy fG1zM23M1q/ydZ1Xj/2Z03L1vSDd96H3uLqIH/pQpsuXchqae+MGLzpA8 qW5KahI6CONeXB8gWvbOeQkyTUJuCP2MZwncRV+Q48um8C2tSGxByk3Je kEDwMdEmzCWdCpb45RWigcF5+szr9TcyRQ02rJLGxcvajvpDK8XGfrd2b A==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="264644059" X-IronPort-AV: E=Sophos;i="5.90,284,1643702400"; d="scan'208";a="264644059" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2022 01:02:04 -0700 X-IronPort-AV: E=Sophos;i="5.90,284,1643702400"; d="scan'208";a="578312714" Received: from yjsun1-mobl.ccr.corp.intel.com (HELO [10.255.31.217]) ([10.255.31.217]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2022 01:02:00 -0700 Message-ID: <36764562-ad54-b192-4084-842fee8fca78@linux.intel.com> Date: Sat, 23 Apr 2022 16:01:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 02/13] iommu: Move bus setup to IOMMU device registration Content-Language: en-US To: Robin Murphy , joro@8bytes.org, will@kernel.org References: <1d9a2146-9e48-ba97-d049-5d2332ebbd3a@arm.com> <7f693a3a-bbab-237a-af9a-4395e501a5b2@arm.com> From: Lu Baolu In-Reply-To: <7f693a3a-bbab-237a-af9a-4395e501a5b2@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220423_010205_947426_91B6DE40 X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jean-philippe@linaro.org, mjrosato@linux.ibm.com, sven@svenpeter.dev, zhang.lyra@gmail.com, robdclark@gmail.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org, gerald.schaefer@linux.ibm.com, yong.wu@mediatek.com, m.szyprowski@samsung.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUm9iaW4sCgpPbiAyMDIyLzQvMTkgMTU6MjAsIFJvYmluIE11cnBoeSB3cm90ZToKPiBPbiAy MDIyLTA0LTE5IDAwOjM3LCBMdSBCYW9sdSB3cm90ZToKPj4gT24gMjAyMi80LzE5IDY6MDksIFJv YmluIE11cnBoeSB3cm90ZToKPj4+IE9uIDIwMjItMDQtMTYgMDE6MDQsIEx1IEJhb2x1IHdyb3Rl Ogo+Pj4+IE9uIDIwMjIvNC8xNCAyMDo0MiwgUm9iaW4gTXVycGh5IHdyb3RlOgo+Pj4+PiBAQCAt MTg4MywyNyArMTkwMCwxMiBAQCBzdGF0aWMgaW50IGlvbW11X2J1c19pbml0KHN0cnVjdCBidXNf dHlwZSAKPj4+Pj4gKmJ1cykKPj4+Pj4gwqDCoCAqLwo+Pj4+PiDCoCBpbnQgYnVzX3NldF9pb21t dShzdHJ1Y3QgYnVzX3R5cGUgKmJ1cywgY29uc3Qgc3RydWN0IGlvbW11X29wcyAqb3BzKQo+Pj4+ PiDCoCB7Cj4+Pj4+IC3CoMKgwqAgaW50IGVycjsKPj4+Pj4gLQo+Pj4+PiAtwqDCoMKgIGlmIChv cHMgPT0gTlVMTCkgewo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgYnVzLT5pb21tdV9vcHMgPSBOVUxM Owo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7Cj4+Pj4+IC3CoMKgwqAgfQo+Pj4+PiAt Cj4+Pj4+IC3CoMKgwqAgaWYgKGJ1cy0+aW9tbXVfb3BzICE9IE5VTEwpCj4+Pj4+ICvCoMKgwqAg aWYgKGJ1cy0+aW9tbXVfb3BzICYmIG9wcyAmJiBidXMtPmlvbW11X29wcyAhPSBvcHMpCj4+Pj4+ IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVCVVNZOwo+Pj4+PiDCoMKgwqDCoMKgIGJ1cy0+ aW9tbXVfb3BzID0gb3BzOwo+Pj4+Cj4+Pj4gRG8gd2Ugc3RpbGwgbmVlZCB0byBrZWVwIGFib3Zl IGxpbmVzIGluIGJ1c19zZXRfaW9tbXUoKT8KPj4+Cj4+PiBJdCBwcmVzZXJ2ZXMgdGhlIGV4aXN0 aW5nIGJlaGF2aW91ciB1bnRpbCBlYWNoIGNhbGxzaXRlIGFuZCBpdHMgCj4+PiBhc3NvY2lhdGVk IGVycm9yIGhhbmRsaW5nIGFyZSByZW1vdmVkIGxhdGVyIG9uLCB3aGljaCBzZWVtcyBsaWtlIGFz IAo+Pj4gZ29vZCBhIHRoaW5nIHRvIGRvIGFzIGFueS4gU2luY2UgSSdtIGFscmVhZHkgcmVsYXhp bmcgCj4+PiBpb21tdV9kZXZpY2VfcmVnaXN0ZXIoKSB0byBhIHdhcm4tYnV0LWNvbnRpbnVlIGJl aGF2aW91ciB3aGlsZSBpdCAKPj4+IGtlZXBzIHRoZSBidXMgb3BzIG9uIGxpZmUtc3VwcG9ydCBp bnRlcm5hbGx5LCBJIGZpZ3VyZWQgbm90IGNoYW5naW5nIAo+Pj4gdG9vIG11Y2ggYXQgb25jZSB3 b3VsZCBtYWtlIGl0IGVhc2llciB0byBiaXNlY3QgYW55IHBvdGVudGlhbCBpc3N1ZXMgCj4+PiBh cmlzaW5nIGZyb20gdGhpcyBmaXJzdCBzdGVwLgo+Pgo+PiBGYWlyIGVub3VnaC4gVGhhbmsgeW91 IGZvciB0aGUgZXhwbGFuYXRpb24uCj4+Cj4+IERvIHlvdSBoYXZlIGEgcHVibGljIHRyZWUgdGhh dCBJIGNvdWxkIHB1bGwgdGhlc2UgcGF0Y2hlcyBhbmQgdHJ5IHRoZW0KPj4gb24gYW4gSW50ZWwg aGFyZHdhcmU/IE9yIHBlcmhhcHMgeW91IGhhdmUgZG9uZSB0aGlzPyBJIGxpa2UgdGhlIHdob2xl Cj4+IGlkZWEgb2YgdGhpcyBzZXJpZXMsIGJ1dCBpdCdzIGJldHRlciB0byB0cnkgaXQgd2l0aCBh IHJlYWwgaGFyZHdhcmUuCj4gCj4gSSBoYXZlbid0IGJvdGhlcmVkIHdpdGggc2VwYXJhdGUgYnJh bmNoZXMgc2luY2UgdGhlcmUncyBzbyBtYW55IAo+IGRpZmZlcmVudCBwaWVjZXMgaW4tZmxpZ2h0 LCBidXQgbXkgY29tcGxldGUgKHVuc3RhYmxlKSBkZXZlbG9wbWVudCAKPiBicmFuY2ggY2FuIGJl IGZvdW5kIGhlcmU6Cj4gCj4gaHR0cHM6Ly9naXRsYWIuYXJtLmNvbS9saW51eC1hcm0vbGludXgt cm0vLS9jb21taXRzL2lvbW11L2J1cwo+IAo+IEZvciBub3cgSSdkIHJlY29tbWVuZCB3aW5kaW5n IHRoZSBoZWFkIGJhY2sgdG8gImlvbW11OiBDbGVhbiB1cCAKPiBidXNfc2V0X2lvbW11KCkiIGZv ciB0ZXN0aW5nIC0gc29tZSBvZiB0aGUgcGF0Y2hlcyBhYm92ZSB0aGF0IGhhdmUgCj4gYWxyZWFk eSBiZWVuIHBvc3RlZCBhbmQgcGlja2VkIHVwIGJ5IHRoZWlyIHJlc3BlY3RpdmUgc3Vic3lzdGVt cywgYnV0IAo+IG90aGVycyBhcmUgaW5jb21wbGV0ZSBhbmQgYmFyZWx5IGNvbXBpbGUtdGVzdGVk LiBJJ2xsIHByb2JhYmx5IHJlYXJyYW5nZSAKPiBpdCBsYXRlciB0aGlzIHdlZWsgdG8gYmV0dGVy IHJlZmxlY3Qgd2hhdCdzIGhhcHBlbmVkIHNvIGZhci4KCkkgd291bmQgdGhlIGhlYWQgYmFjayB0 byAiaW9tbXU6IENsZWFuIHVwIGJ1c19zZXRfaW9tbXUiIGFuZCB0ZXN0ZWQgaXQKb24gYW4gSW50 ZWwgbWFjaGluZS4gSXQgZ290IHN0dWNrIGR1cmluZyBib290LiBUaGlzIHRlc3Qgd2FzIG9uIGEg cmVtb3RlCm1hY2hpbmUgYW5kIEkgaGF2ZSBubyBtZWFucyB0byBhY2Nlc3MgaXQgcGh5c2ljYWxs eS4gU28gSSBjYW4ndCBnZXQgYW55Cmtlcm5lbCBkZWJ1Z2dpbmcgbWVzc2FnZXMuIChJIGhhdmUg dG8gd29yayBmcm9tIGhvbWUgdGhlc2UgZGF5cy4gOi0oKQoKSSBndWVzcyBpdCdzIGR1ZSB0byB0 aGUgZmFjdCB0aGF0IGludGVsX2lvbW11X3Byb2JlX2RldmljZSgpIGNhbGxiYWNrCm9ubHkgd29y a3MgZm9yIHRoZSBwY2kgZGV2aWNlcy4gVGhlIGlzc3VlIG9jY3VycyB3aGVuIHByb2JpbmcgYSBk ZXZpY2UKb3RoZXIgdGhhbiBhIFBDSSBvbmUuCgpCZXN0IHJlZ2FyZHMsCmJhb2x1CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==