From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758067AbcIHICs (ORCPT ); Thu, 8 Sep 2016 04:02:48 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:61367 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753776AbcIHICo (ORCPT ); Thu, 8 Sep 2016 04:02:44 -0400 From: Arnd Bergmann To: Peter Chen Cc: Felipe Balbi , Leo Li , Grygorii Strashko , Russell King - ARM Linux , Catalin Marinas , Yoshihiro Shimoda , "linux-usb@vger.kernel.org" , Sekhar Nori , lkml , Stuart Yoder , Scott Wood , David Fisher , "Thang Q. Nguyen" , Alan Stern , Greg Kroah-Hartman , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Date: Thu, 08 Sep 2016 10:02:25 +0200 Message-ID: <3677438.L3Nmh9fM1W@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160908011535.GE13903@b29397-desktop> References: <3189648.KnWLgq0lTY@wuerfel> <20160908011535.GE13903@b29397-desktop> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:0+tUQn3MA4dCqpXFXLngR7AxgTyXXanZWqFgyKO5abgcIFEuR5U AX42lZPhqv623kssSk3SxcIPIVWMP88IS+qhdBtTpbK2cgFfqZh5DWNIRXpEyncnoLUtew5 ZC06I4EGZouzKFmZFYn9/9a7wbxj6RZdiot0wnWyFBlqBlyIrJP3N/BVUdsSpEqxeuiB1yY OmL/ZFURPYTiS1duJN2ow== X-UI-Out-Filterresults: notjunk:1;V01:K0:eutT1KYOOFA=:odf4njNZ6ivKw/0OrmXrAV RAcbbgmwQeuzl5Dbx/ytkE4hgah9VdXE43pebmAdmKgVSPGs6YV13o7vh3HD5nz0d59YGqd0I qt6hJr/YeJFfM4z+TtZs0cpW/0a8C/Tjb29tL5r//u5oQw5VWqihiddtvBcfDPsifmrsYd2yU Ba4I/bOQe4/ogsEUm9YipKhoM1b6MfEh1xkkxAwrEhXVtewHj89vR2vH9NQr1CPYd6KtHq4pZ oifMOTxtPFaEv6qL7y4U1dhNgoMOs0gudC5jgIEcmZCaudo9/IJmycr21m65dhFjp8Up6StrL hNkJEn+wUfiF9fyC9s90cUBsd3E5QZ2LslfCbHuiXnp7rHN8aLqNiaHKGVHHblyfd7GNtOMhr axziTYd6N1yNuFzbam+45Fao/myNvyumlnV/0N7btKaZxfVInM85k2F0uKNpgnL1wDXkRA4gq A0C3o8EArBmt3QqbNeQN10nqqSVAvu9+LqHjfjvxb5XSmIT/P8BlZ1ggRdyncO9rBZ87W5+Yx Ob2tapk4BrDEdCnusOK7TjJxIuK6mJHLJYrUwx4PjcYVO3ylV9/sY/hAh9iCjE4DwJ2qNdCVs iDlYgLbC8KOihLRLgs5HBgskuU7D7MR2hOqAwsh0hpBnu66w+GMaCXPWvEoCbhWwGMvZ0qedR qbXjxdo8a3ju/47ZhDezoqMYLYV9ZzG61sAxx5WRb1uqn/oolkSiTkLx5eXghIBSXy2no62u2 MGN6V6xy7zoz8vtc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 8, 2016 9:15:36 AM CEST Peter Chen wrote: > > > > Right, I was specifically talking about the code in chipidea here, > > which I think is never used on the PCI bus, and how the current > > code is broken. We can probably do better than of_dma_configure() > > (see below), but it would be an improvement. > > Chipidea is also used at PCI bus too, see drivers/usb/chipidea/ci_hdrc_pci.c > Ok, I see. The experimental patch I posted should actually handle this just fine, as it simply assumes that dev->parent is the device used for the DMA API in chipidea, and I think this holds true for both the PCI and the DT based uses of this driver. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 08 Sep 2016 10:02:25 +0200 Subject: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev In-Reply-To: <20160908011535.GE13903@b29397-desktop> References: <3189648.KnWLgq0lTY@wuerfel> <20160908011535.GE13903@b29397-desktop> Message-ID: <3677438.L3Nmh9fM1W@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday, September 8, 2016 9:15:36 AM CEST Peter Chen wrote: > > > > Right, I was specifically talking about the code in chipidea here, > > which I think is never used on the PCI bus, and how the current > > code is broken. We can probably do better than of_dma_configure() > > (see below), but it would be an improvement. > > Chipidea is also used at PCI bus too, see drivers/usb/chipidea/ci_hdrc_pci.c > Ok, I see. The experimental patch I posted should actually handle this just fine, as it simply assumes that dev->parent is the device used for the DMA API in chipidea, and I think this holds true for both the PCI and the DT based uses of this driver. Arnd