From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755083AbcESPwN (ORCPT ); Thu, 19 May 2016 11:52:13 -0400 Received: from gloria.sntech.de ([95.129.55.99]:55923 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754422AbcESPwL (ORCPT ); Thu, 19 May 2016 11:52:11 -0400 From: Heiko Stuebner To: Caesar Wang Cc: Mark Brown , linux-rockchip@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, Xu Jianqun , Kumar Gala , linux-kernel@vger.kernel.org, Ian Campbell , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document Date: Thu, 19 May 2016 17:51:54 +0200 Message-ID: <3685935.dKdIbE8hXb@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> References: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 19. Mai 2016, 23:47:02 schrieb Caesar Wang: > We had supported the rk3036/rk3066/rk3188/rk3228/rk3288/rk3368/rk3399 > family SoCs in linux kernel. > > Let's add the other SoCs, in order to a better understanding from the > rockchip spi document. > > Signed-off-by: Caesar Wang > Cc: Rob Herring > Cc: Mark Brown > Cc: Heiko Stuebner > Cc: linux-rockchip@lists.infradead.org > --- > > Documentation/devicetree/bindings/spi/spi-rockchip.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > b/Documentation/devicetree/bindings/spi/spi-rockchip.txt index > 1b14d69..305b542 100644 > --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt > @@ -6,9 +6,12 @@ and display controllers using the SPI communication > interface. Required Properties: > > - compatible: should be one of the following. > + "rockchip,rk3036-spi" for rk3036. shouldn't the rk3036 also get the rk3066 fallback. Looking at the driver part (patch2) the rk3036 still is the same IP as for every other soc in here. > "rockchip,rk3066-spi" for rk3066. > "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. > + "rockchip,rk3228-spi", "rockchip,rk3066-spi" for rk3228. > "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288. > + "rockchip,rk3368-spi", "rockchip,rk3066-spi" for rk3368. > "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399. > - reg: physical base address of the controller and length of memory > mapped region. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document Date: Thu, 19 May 2016 17:51:54 +0200 Message-ID: <3685935.dKdIbE8hXb@phil> References: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1463672824-15367-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Caesar Wang Cc: Mark Brown , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Xu Jianqun , Kumar Gala , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ian Campbell , Pawel Moll , Mark Rutland , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Am Donnerstag, 19. Mai 2016, 23:47:02 schrieb Caesar Wang: > We had supported the rk3036/rk3066/rk3188/rk3228/rk3288/rk3368/rk3399 > family SoCs in linux kernel. > > Let's add the other SoCs, in order to a better understanding from the > rockchip spi document. > > Signed-off-by: Caesar Wang > Cc: Rob Herring > Cc: Mark Brown > Cc: Heiko Stuebner > Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > --- > > Documentation/devicetree/bindings/spi/spi-rockchip.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > b/Documentation/devicetree/bindings/spi/spi-rockchip.txt index > 1b14d69..305b542 100644 > --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt > @@ -6,9 +6,12 @@ and display controllers using the SPI communication > interface. Required Properties: > > - compatible: should be one of the following. > + "rockchip,rk3036-spi" for rk3036. shouldn't the rk3036 also get the rk3066 fallback. Looking at the driver part (patch2) the rk3036 still is the same IP as for every other soc in here. > "rockchip,rk3066-spi" for rk3066. > "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. > + "rockchip,rk3228-spi", "rockchip,rk3066-spi" for rk3228. > "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288. > + "rockchip,rk3368-spi", "rockchip,rk3066-spi" for rk3368. > "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399. > - reg: physical base address of the controller and length of memory > mapped region. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Thu, 19 May 2016 17:51:54 +0200 Subject: [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document In-Reply-To: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> References: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> Message-ID: <3685935.dKdIbE8hXb@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Donnerstag, 19. Mai 2016, 23:47:02 schrieb Caesar Wang: > We had supported the rk3036/rk3066/rk3188/rk3228/rk3288/rk3368/rk3399 > family SoCs in linux kernel. > > Let's add the other SoCs, in order to a better understanding from the > rockchip spi document. > > Signed-off-by: Caesar Wang > Cc: Rob Herring > Cc: Mark Brown > Cc: Heiko Stuebner > Cc: linux-rockchip at lists.infradead.org > --- > > Documentation/devicetree/bindings/spi/spi-rockchip.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > b/Documentation/devicetree/bindings/spi/spi-rockchip.txt index > 1b14d69..305b542 100644 > --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt > @@ -6,9 +6,12 @@ and display controllers using the SPI communication > interface. Required Properties: > > - compatible: should be one of the following. > + "rockchip,rk3036-spi" for rk3036. shouldn't the rk3036 also get the rk3066 fallback. Looking at the driver part (patch2) the rk3036 still is the same IP as for every other soc in here. > "rockchip,rk3066-spi" for rk3066. > "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. > + "rockchip,rk3228-spi", "rockchip,rk3066-spi" for rk3228. > "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288. > + "rockchip,rk3368-spi", "rockchip,rk3066-spi" for rk3368. > "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399. > - reg: physical base address of the controller and length of memory > mapped region.