From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752034AbdFJItq (ORCPT ); Sat, 10 Jun 2017 04:49:46 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:48924 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbdFJIto (ORCPT ); Sat, 10 Jun 2017 04:49:44 -0400 From: Laurent Pinchart To: Jose Abreu Cc: Mark Yao , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Kieran Bingham , Laurent Pinchart , Archit Taneja , Andrzej Hajda , Carlos Palminha Subject: Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY Date: Sat, 10 Jun 2017 11:50:07 +0300 Message-ID: <3690108.zYIGBGnVBz@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.16-gentoo; KDE/4.14.32; x86_64; ; ) In-Reply-To: <6071fd12-2cda-cd1f-2607-9a498f588040@synopsys.com> References: <6071fd12-2cda-cd1f-2607-9a498f588040@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jose, On Friday 09 Jun 2017 13:53:12 Jose Abreu wrote: > On 09-06-2017 12:04, Jose Abreu wrote: > > Currently HDMI 2.0 PHYs do not have a default configuration function. > > > > As these PHYs have the same register layout as the 3D PHYs we can > > safely use the default configuration function. > > I may have been a little to fast arriving at this conclusion. I > mean most of the registers match but in the configuration > function there are registers that do not match. Did you actually > test this configuration function with an HDMI 2.0 phy? And did > you test with different video modes? From my experience the phy > may be wrongly configured and sometimes work anyway. > > Do please retest with as many video modes as you can and give me > your phy ID (read from controller config reg HDMI_CONFIG2_ID). The Renesas R-Car Gen3 HDMI PHY reports an DWC HDMI 2.0 TX PHY ID, but has a configuration function (rcar_hdmi_phy_configure() in drivers/gpu/drm/rcar- du/rcar_dw_hdmi.c) that doesn't match hdmi_phy_configure_dwc_hdmi_3d_tx(). >>From the information I have been given the layout of the configuration registers haven't been changed by Renesas. I know we've briefly discussed this in the past, but I'd appreciate if you could have a second look and tell me what you think. > > If, for some reason, > > > > the PHY is custom this change will not make any impact because > > in configuration function we prefer the pdata provided configuration > > function over the internal one. > > > > This patch is based on today's drm-misc-next branch. > > > > Signed-off-by: Jose Abreu > > Cc: Kieran Bingham > > Cc: Laurent Pinchart > > Cc: Archit Taneja > > Cc: Andrzej Hajda > > Cc: Mark Yao > > Cc: Carlos Palminha > > --- > > > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index ead1124..10c8d8c 100644 > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > @@ -2170,6 +2170,7 @@ static irqreturn_t dw_hdmi_irq(int irq, void > > *dev_id) > > .name = "DWC HDMI 2.0 TX PHY", > > .gen = 2, > > .has_svsret = true, > > + .configure = hdmi_phy_configure_dwc_hdmi_3d_tx, > > }, { > > .type = DW_HDMI_PHY_VENDOR_PHY, > > .name = "Vendor PHY", -- Regards, Laurent Pinchart