From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPrlN-0002eT-Tl for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:51:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPrlK-0005FU-6Z for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:51:17 -0400 References: <20180417153945.20737-1-pbonzini@redhat.com> <20180417153945.20737-7-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <369237e8-a956-9e17-6f95-ff0e059f2591@redhat.com> Date: Mon, 4 Jun 2018 17:51:03 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] ide: introduce ide_transfer_start_norecurse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org On 02/06/2018 03:17, John Snow wrote: > > > On 04/17/2018 11:39 AM, Paolo Bonzini wrote: >> For the case where the end_transfer_func is also the caller of >> ide_transfer_start, the mutual recursion can lead to unlimited >> stack usage. Introduce a new version that can be used to change >> tail recursion into a loop, and use it in trace_ide_atapi_cmd_reply_end. > > probably you mean ide_atapi_cmd_reply_end Yeah. Cut-and-paste... Paolo >> >> Signed-off-by: Paolo Bonzini > > Reviewed-by: John Snow >