From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751595AbdJWK33 (ORCPT ); Mon, 23 Oct 2017 06:29:29 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:64300 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbdJWK31 (ORCPT ); Mon, 23 Oct 2017 06:29:27 -0400 Subject: Re: [PATCH v2] dwc: dra7xx: Print link state to console for debug To: Bjorn Helgaas CC: , , , , References: <1508417009-30869-1-git-send-email-faiz_abbas@ti.com> <20171020230952.GZ6332@bhelgaas-glaptop.roam.corp.google.com> From: Faiz Abbas Message-ID: <3692fbeb-bf8a-6de6-898b-551d899e9e55@ti.com> Date: Mon, 23 Oct 2017 15:59:49 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171020230952.GZ6332@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, On Saturday 21 October 2017 04:39 AM, Bjorn Helgaas wrote: > On Thu, Oct 19, 2017 at 06:13:29PM +0530, Faiz Abbas wrote: >> Enable support for printing the LTSSM link state for debugging PCI >> when link is down. >> >> Signed-off-by: Faiz Abbas >> --- >> v2: >> 1. Changed dev_err() to dev_dbg() >> 2. Changed static char array to static const char * const >> 3. format changes > > I'm not really sure how much debug help we want to carry around in the > mainline kernel. End users aren't going to use this; it seems like > more of a lab tool, and in situations like that you usually end up > carrying around some out-of-tree patches for a while anyway. But I > can probably be convinced either way. > It'll be easier to support customers if they can tell us what the state of the link is by just changing the log level. We won't have to send a debug patch to the customer to find that out. Thanks, Faiz From mboxrd@z Thu Jan 1 00:00:00 1970 From: Faiz Abbas Subject: Re: [PATCH v2] dwc: dra7xx: Print link state to console for debug Date: Mon, 23 Oct 2017 15:59:49 +0530 Message-ID: <3692fbeb-bf8a-6de6-898b-551d899e9e55@ti.com> References: <1508417009-30869-1-git-send-email-faiz_abbas@ti.com> <20171020230952.GZ6332@bhelgaas-glaptop.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171020230952.GZ6332@bhelgaas-glaptop.roam.corp.google.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Helgaas Cc: kishon@ti.com, bhelgaas@google.com, linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org Hi Bjorn, On Saturday 21 October 2017 04:39 AM, Bjorn Helgaas wrote: > On Thu, Oct 19, 2017 at 06:13:29PM +0530, Faiz Abbas wrote: >> Enable support for printing the LTSSM link state for debugging PCI >> when link is down. >> >> Signed-off-by: Faiz Abbas >> --- >> v2: >> 1. Changed dev_err() to dev_dbg() >> 2. Changed static char array to static const char * const >> 3. format changes > > I'm not really sure how much debug help we want to carry around in the > mainline kernel. End users aren't going to use this; it seems like > more of a lab tool, and in situations like that you usually end up > carrying around some out-of-tree patches for a while anyway. But I > can probably be convinced either way. > It'll be easier to support customers if they can tell us what the state of the link is by just changing the log level. We won't have to send a debug patch to the customer to find that out. Thanks, Faiz