From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Wed, 20 Aug 2014 23:01:43 +0000 Subject: Re: [PATCH 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit. Message-Id: <3694359.xqEjcGBlOG@avalon> List-Id: References: <1408452653-14067-1-git-send-email-mikhail.ulyanov@cogentembedded.com> <1408452653-14067-7-git-send-email-mikhail.ulyanov@cogentembedded.com> In-Reply-To: <1408452653-14067-7-git-send-email-mikhail.ulyanov@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mikhail Ulyanov Cc: m.chehab@samsung.com, horms@verge.net.au, magnus.damm@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, linux-sh@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org Hi Mikhail, Thank you for the patch. On Tuesday 19 August 2014 16:50:53 Mikhail Ulyanov wrote: > Signed-off-by: Mikhail Ulyanov > --- > .../devicetree/bindings/media/renesas,jpu.txt | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/renesas,jpu.txt > > diff --git a/Documentation/devicetree/bindings/media/renesas,jpu.txt > b/Documentation/devicetree/bindings/media/renesas,jpu.txt new file mode > 100644 > index 0000000..44b07df > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,jpu.txt > @@ -0,0 +1,23 @@ > +* Renesas VSP1 Video Processing Engine Copy & paste ? :-) > + > +The JPEG processing unit (JPU) incorporates the JPEG codec with an encoding > +and decoding function conforming to the JPEG baseline process, so that the > JPU > +can encode image data and decode JPEG data quickly. > +It can be found in the Renesas R-Car first and second generation SoCs. Is there a difference between the first and second generation JPUs ? > + > +Required properties: > + - compatible: should containg one of the following: > + - "renesas,jpu-r8a7790" for R-Car H2 > + - "renesas,jpu-r8a7791" for R-Car M2 How about adding a "renesas,jpu" generic compatible, and listing both the SoC- specific and the generic values (in that order) in the compatible property ? > + - reg: Base address and length of the registers block for the JPU. > + - interrupts: JPU interrupt specifier. > + - clocks: A phandle + clock-specifier pair for the JPU functional clock. > + > +Example: R8A7790 (R-Car H2) JPU node > + jpeg-codec@fe980000 { > + compatible = "renesas,jpu-r8a7790"; > + reg = <0 0xfe980000 0 0x10300>; > + interrupts = <0 272 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp1_clks R8A7790_CLK_JPU>; > + }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit. Date: Thu, 21 Aug 2014 01:01:43 +0200 Message-ID: <3694359.xqEjcGBlOG@avalon> References: <1408452653-14067-1-git-send-email-mikhail.ulyanov@cogentembedded.com> <1408452653-14067-7-git-send-email-mikhail.ulyanov@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1408452653-14067-7-git-send-email-mikhail.ulyanov@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org To: Mikhail Ulyanov Cc: m.chehab@samsung.com, horms@verge.net.au, magnus.damm@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, linux-sh@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Mikhail, Thank you for the patch. On Tuesday 19 August 2014 16:50:53 Mikhail Ulyanov wrote: > Signed-off-by: Mikhail Ulyanov > --- > .../devicetree/bindings/media/renesas,jpu.txt | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/renesas,jpu.txt > > diff --git a/Documentation/devicetree/bindings/media/renesas,jpu.txt > b/Documentation/devicetree/bindings/media/renesas,jpu.txt new file mode > 100644 > index 0000000..44b07df > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,jpu.txt > @@ -0,0 +1,23 @@ > +* Renesas VSP1 Video Processing Engine Copy & paste ? :-) > + > +The JPEG processing unit (JPU) incorporates the JPEG codec with an encoding > +and decoding function conforming to the JPEG baseline process, so that the > JPU > +can encode image data and decode JPEG data quickly. > +It can be found in the Renesas R-Car first and second generation SoCs. Is there a difference between the first and second generation JPUs ? > + > +Required properties: > + - compatible: should containg one of the following: > + - "renesas,jpu-r8a7790" for R-Car H2 > + - "renesas,jpu-r8a7791" for R-Car M2 How about adding a "renesas,jpu" generic compatible, and listing both the SoC- specific and the generic values (in that order) in the compatible property ? > + - reg: Base address and length of the registers block for the JPU. > + - interrupts: JPU interrupt specifier. > + - clocks: A phandle + clock-specifier pair for the JPU functional clock. > + > +Example: R8A7790 (R-Car H2) JPU node > + jpeg-codec@fe980000 { > + compatible = "renesas,jpu-r8a7790"; > + reg = <0 0xfe980000 0 0x10300>; > + interrupts = <0 272 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp1_clks R8A7790_CLK_JPU>; > + }; -- Regards, Laurent Pinchart