From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 823A5C433F5 for ; Thu, 21 Oct 2021 13:07:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6802760E8C for ; Thu, 21 Oct 2021 13:07:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6802760E8C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 12826834B5; Thu, 21 Oct 2021 15:07:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634821624; bh=7wadxIJ3YT7BgADBAbGIw5E3JXjDkDPvR30xGluvwi0=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XH30C6pRtpely88YP8n3Zk3pkhQolN11P33GgOCTC/opFTX6CRrXllctFj/jAiTbI hZ+f+/L+gAalfyk5eB1yS+CkBwuwAsJMqDNdRajSBcf3uY9fIKFUtZN+ym+O8E8Blh wanQqQJ8MeKsaTiC0IbVt2YxtQdDKQLVZDUlRMeh6yY7vn+qCX/mBanSTjJsnl0luu kWqnRMLl2z5jLw2bn9Im0yk0N44nVO+bPH0C3clY6k3JlH22aMSG9NLRTPjXjIs9SD bbqVfYSUZtKlcpPXUiohBsJJ2J+rqkHimCbdywmaA1ubz0mFx92uvGBORnk/h2vtNi 5gTvyBCMIW3Bg== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id F171983488 for ; Thu, 21 Oct 2021 15:07:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634821622; bh=7wadxIJ3YT7BgADBAbGIw5E3JXjDkDPvR30xGluvwi0=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=MoqqJgafX0boGNmTiIx95X2/GQOx/DU6q9aE3o+lWVXFndnAypOo5Xzi21eVZWVC+ 6pKSojJFa75lBQmixf+wbnv5xT7siXqq1hDdwlF6Bp82VUnySaodqYU9JQ3/aycr9e dPbcC1F9cRjKInNp6YCclIOJgKnAajIEDiu0Mlo4Suk3aZtq5iOIX6ICm8BYPEZ5C5 8rsJJQfMdq2yM9asrZceZDqC8u2KHvl7Y+BPhi0DP5uTPI5EEydMB4cMnWn4ukif8u fkGALjoU3CFMslJ6aKAShLkjTqZmeJGWsIq5k8xQQnCNM0TDPhQo45NwWwTTEDUoVA 3GNbbSQQRuAUg== Received: by janitor.denx.de (Postfix, from userid 108) id 6C502A021F; Thu, 21 Oct 2021 15:07:01 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 75CFCA009B; Thu, 21 Oct 2021 15:06:51 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 210ED1E0F1B; Thu, 21 Oct 2021 15:06:51 +0200 (CEST) To: Tom Rini cc: Simon Glass , U-Boot Mailing List , Marek =?iso-8859-1?Q?Beh=FAn?= , Rasmus Villemoes , Heinrich Schuchardt , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211021122325.GX7964@bill-the-cat> References: <20211019224422.1447059-1-sjg@chromium.org> <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3682215.1634809802@gemini.denx.de> <20211021122325.GX7964@bill-the-cat> Comments: In-reply-to Tom Rini message dated "Thu, 21 Oct 2021 08:23:25 -0400." Date: Thu, 21 Oct 2021 15:06:51 +0200 Message-ID: <3695947.1634821611@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Tom, In message <20211021122325.GX7964@bill-the-cat> you wrote: > > Do you have any other feedback on the entire rest of the series? I already wrote that I support the concept, and the few nit I saw have been fixed, I think. Except this unneeded breaking of backward compatibility. > Because I'm not sure the benefit of "we can still support '+' at the end > of a variable name, if anyone uses that" outweighs "we can more easily > append variables in constructing our environment without relying on > uncommon operators". We introduce a new feature here. Defining an append operator is a convenience thing. It could probably also solved using the preprocessor, likely in a more ugly way. In any case, the feature is new, and the operator is new. For the implementation it does not matter if we define this operator as "+=" or '=+" or "=." or something else. the only difference is that any ioperator starting with an equal sign is inherently backward compatible without need for arbitrary new restrictions. > To me "=+" as the append syntax is worse than "no > + at the end of your variables". In which way is it worse? For esthetic reasons? I confirm that '+=' looks better. But '+=" is technically broken. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Brain: an apparatus with which we think we think. - Ambrose Bierce