From: "Chen, Yu C" <yu.c.chen@intel.com>
To: "Zheng, Lv" <lv.zheng@intel.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zhang, Rui" <rui.zhang@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Brown, Len" <len.brown@intel.com>
Subject: RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle
Date: Fri, 9 Oct 2015 09:50:21 +0000 [thread overview]
Message-ID: <36DF59CE26D8EE47B0655C516E9CE6402865A448@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1AE640813FDE7649BE1B193DEA596E883BAC6884@SHSMSX101.ccr.corp.intel.com>
Hi, LV
> -----Original Message-----
> From: Zheng, Lv
> Sent: Friday, October 09, 2015 4:33 PM
> To: Chen, Yu C; rjw@rjwysocki.net; lenb@kernel.org
> Cc: linux-pm@vger.kernel.org; linux-acpi@vger.kernel.org; linux-
> kernel@vger.kernel.org; Zhang, Rui
> Subject: RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before
> suspend-to-idle
>
> Hi, Yu
>
> > From: Chen, Yu C
> > Sent: Friday, October 09, 2015 4:20 PM
> >
> >
> > acpi_status acpi_os_remove_interrupt_handler(u32 irq,
> > acpi_osd_handler handler)
>
> Why don't you rename irq here to gsi to improve the readability?
> The false naming and the wrong example written for this function are
> probably the root causes of all other bad code.
> So if we want to stop people making future mistakes, we need to cleanup
> ourselves.
>
OK, will rewrite in next version.
> Thanks and best regards
> -Lv
>
next prev parent reply other threads:[~2015-10-09 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 8:20 [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle Chen Yu
2015-10-09 8:32 ` Zheng, Lv
2015-10-09 9:50 ` Chen, Yu C [this message]
2015-10-10 2:28 ` Zheng, Lv
2015-10-12 20:20 ` Rafael J. Wysocki
2015-10-14 17:44 ` Chen, Yu C
2015-10-14 17:44 ` Chen, Yu C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36DF59CE26D8EE47B0655C516E9CE6402865A448@shsmsx102.ccr.corp.intel.com \
--to=yu.c.chen@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.