From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Yu C" Subject: RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support Date: Tue, 10 Nov 2015 13:56:49 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE640286728CF@shsmsx102.ccr.corp.intel.com> References: <36DF59CE26D8EE47B0655C516E9CE6402867258C@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com ([134.134.136.65]:65497 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbbKJN4y (ORCPT ); Tue, 10 Nov 2015 08:56:54 -0500 In-Reply-To: Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andy Shevchenko Cc: "Zheng, Lv" , Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Wysocki, Rafael J" , "Brown, Len" SGksIFNoZXZjaGVua28sDQpUaGFua3MgZm9yIHlvdSByZXZpZXcNCg0KPiAtLS0tLU9yaWdpbmFs IE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBBbmR5IFNoZXZjaGVua28gW21haWx0bzphbmR5LnNoZXZj aGVua29AZ21haWwuY29tXQ0KPiBTZW50OiBUdWVzZGF5LCBOb3ZlbWJlciAxMCwgMjAxNSA5OjA0 IFBNDQo+IFRvOiBDaGVuLCBZdSBDDQo+IENjOiBaaGVuZywgTHY7IEx2IFpoZW5nOyBsaW51eC1r ZXJuZWxAdmdlci5rZXJuZWwub3JnOyBsaW51eC0NCj4gYWNwaUB2Z2VyLmtlcm5lbC5vcmc7IFd5 c29ja2ksIFJhZmFlbCBKOyBCcm93biwgTGVuDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgNS83 XSBBQ1BJIC8geDg2OiBpbnRyb2R1Y2UgYWNwaV9vc19yZWFkYWJsZSgpIHN1cHBvcnQNCj4gDQo+ IE9uIFR1ZSwgTm92IDEwLCAyMDE1IGF0IDExOjQyIEFNLCBDaGVuLCBZdSBDIDx5dS5jLmNoZW5A aW50ZWwuY29tPiB3cm90ZToNCj4gPiBIaSwgTHYNCj4gPiBTb3JyeSBmb3IgbXkgbGF0ZSBmZWVk YmFjayBvbiB0aGUgcGF0Y2gsIG9uZSBtaW5vciBuaXQgYmVsb3c6DQo+IA0KPiA+PiArICAgICBz dGFydF9wZm4gPSBwYWdlX3RvX3Bmbih2aXJ0X3RvX3BhZ2UocG9pbnRlcikpOw0KPiA+PiArICAg ICBlbmRfcGZuID0gcGFnZV90b19wZm4odmlydF90b19wYWdlKHBvaW50ZXIgKyBsZW5ndGgpKTsN Cj4gPiBDb252ZXJ0IHBvaW50ZXIgdG8gY2hhciogZmlyc3Q/DQo+ID4gZW5kX3BmbiA9IHBhZ2Vf dG9fcGZuKHZpcnRfdG9fcGFnZSgoY2hhciopcG9pbnRlciArIGxlbmd0aCkpOw0KPiANCj4gV2h5 IGRvIHlvdSBuZWVkIHRoYXQ/DQo+IHZvaWQgKiArIHNpemVfdCA9IGNoYXIgKiArIHNpemVfdA0K PiANCkh1bSwgSSB3YXMgdW5kZXIgaW1wcmVzc2lvbiBpdCB3YXMgYSBwb2ludGVyLCBzbyBJIGNv bnZlcnRlZCBpdCB0byBjaGFyKiBmb3Igc2FmZXR5LA0KYnV0IGl0IHNlZW1zIGEgd3JvbmcgaW1w cmVzc2lvbixhbmQgSSd2ZSBqdXN0IHRlc3RlZCBpdCBvbiBnY2MsIGl0IGlzIE9LIHdpdGhvdXQN CmNoYXIqLg0KDQo+IC0tDQo+IFdpdGggQmVzdCBSZWdhcmRzLA0KPiBBbmR5IFNoZXZjaGVua28N Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753158AbbKJN44 (ORCPT ); Tue, 10 Nov 2015 08:56:56 -0500 Received: from mga03.intel.com ([134.134.136.65]:65497 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbbKJN4y (ORCPT ); Tue, 10 Nov 2015 08:56:54 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,270,1444719600"; d="scan'208";a="597559204" From: "Chen, Yu C" To: Andy Shevchenko CC: "Zheng, Lv" , Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Wysocki, Rafael J" , "Brown, Len" Subject: RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support Thread-Topic: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support Thread-Index: AQHRG5DvOI4Q/C8PFUC4WTh3lRAEKp6U80Wg///AJgCAAIakMA== Date: Tue, 10 Nov 2015 13:56:49 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE640286728CF@shsmsx102.ccr.corp.intel.com> References: <36DF59CE26D8EE47B0655C516E9CE6402867258C@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tAADv0IX002623 Hi, Shevchenko, Thanks for you review > -----Original Message----- > From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com] > Sent: Tuesday, November 10, 2015 9:04 PM > To: Chen, Yu C > Cc: Zheng, Lv; Lv Zheng; linux-kernel@vger.kernel.org; linux- > acpi@vger.kernel.org; Wysocki, Rafael J; Brown, Len > Subject: Re: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support > > On Tue, Nov 10, 2015 at 11:42 AM, Chen, Yu C wrote: > > Hi, Lv > > Sorry for my late feedback on the patch, one minor nit below: > > >> + start_pfn = page_to_pfn(virt_to_page(pointer)); > >> + end_pfn = page_to_pfn(virt_to_page(pointer + length)); > > Convert pointer to char* first? > > end_pfn = page_to_pfn(virt_to_page((char*)pointer + length)); > > Why do you need that? > void * + size_t = char * + size_t > Hum, I was under impression it was a pointer, so I converted it to char* for safety, but it seems a wrong impression,and I've just tested it on gcc, it is OK without char*. > -- > With Best Regards, > Andy Shevchenko {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I