From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Yu C" Subject: RE: [PATCH v4 7/7] ACPI / x86: introduce acpi_os_readable() support Date: Tue, 22 Dec 2015 01:03:43 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE640286886D1@shsmsx102.ccr.corp.intel.com> References: <36DF59CE26D8EE47B0655C516E9CE64028686D35@shsmsx102.ccr.corp.intel.com> <1AE640813FDE7649BE1B193DEA596E883BB08C24@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com ([192.55.52.88]:53546 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932109AbbLVBDs (ORCPT ); Mon, 21 Dec 2015 20:03:48 -0500 In-Reply-To: Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andy Lutomirski , "Zheng, Lv" Cc: "Moore, Robert" , "Wysocki, Rafael J" , "Brown, Len" , Andy Lutomirski , Lv Zheng , "linux-kernel@vger.kernel.org" , Linux ACPI , "H. Peter Anvin" , Borislav Petkov SGkgQW5keSwNCnRoYW5rcyBmb3IgeW91ciByZXZpZXcsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNz YWdlLS0tLS0NCj4gRnJvbTogQW5keSBMdXRvbWlyc2tpIFttYWlsdG86bHV0b0BhbWFjYXBpdGFs Lm5ldF0NCj4gU2VudDogRnJpZGF5LCBEZWNlbWJlciAxOCwgMjAxNSAxOjAwIEFNDQo+IFRvOiBa aGVuZywgTHYNCj4gQ2M6IENoZW4sIFl1IEM7IE1vb3JlLCBSb2JlcnQ7IFd5c29ja2ksIFJhZmFl bCBKOyBCcm93biwgTGVuOyBBbmR5DQo+IEx1dG9taXJza2k7IEx2IFpoZW5nOyBsaW51eC1rZXJu ZWxAdmdlci5rZXJuZWwub3JnOyBMaW51eCBBQ1BJOyBILiBQZXRlcg0KPiBBbnZpbjsgQm9yaXNs YXYgUGV0a292DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjQgNy83XSBBQ1BJIC8geDg2OiBpbnRy b2R1Y2UgYWNwaV9vc19yZWFkYWJsZSgpIHN1cHBvcnQNCj4gDQpbY3V0XQ0KPiANCj4gSSB0aGlu ayB0aGF0IGhwYSBvciBCb3Jpc2xhdiBbY2MnZF0gY291bGQgYWRkcmVzcyB0aGUgbWVtb3J5IG1h cCBkZXRhaWxzDQo+IGJldHRlciB0aGFuIEkgY291bGQuICBIb3dldmVyLCB0aGlzIGZ1bmN0aW9u YWxpdHkgc2VlbXMgc3RyYW5nZS4NCj4gDQo+IEFyZSB0aGVzZSBwaHlzaWNhbCBhZGRyZXNzZXMg b3IgdmlydHVhbCBhZGRyZXNzZXMgdGhhdCBhcmUgYmVpbmcgZHVtcGVkPyAgDQpbWXVdIFRoZXkg YXJlICB2aXJ0dWFsIGFkZHJlc3NlcyB0byBiZSBkdW1wZWQuDQo+IEluICBlaXRoZXIgY2FzZSwg SVNUTSB0aGF0IHVzaW5nIHNvbWV0aGluZyBpaWtlIHBhZ2VfaXNfcmFtIG1pZ2h0IGJlIGEgbG90 DQo+IHNpbXBsZXIuDQpbWXVdIGlmIGkgdW5kZXJzdGFuZCBjb3JyZWN0bHksIHRoaXMgQVBJIGlz IHVzZWQgdG8gY2hlY2sgaWYgdGhlIGFkZHJlc3MgaXMgYSB2YWxpZCANCidrbWFsbG9jJyBzdHls ZSBhZGRyZXNzLCBidXQgbm90ICdrbWFwJyBvciAndm1hbGxvYycgYWRkcmVzcywgYW5kIHBhZ2Vf aXNfcmFtDQptaWdodCB0cmVhdCB0aGUgbGF0dGVyIGFzIHZhbGlkIGFkZHJlc3M/DQoNCnRoYW5r cywNCll1DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932472AbbLVBDu (ORCPT ); Mon, 21 Dec 2015 20:03:50 -0500 Received: from mga01.intel.com ([192.55.52.88]:53546 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932109AbbLVBDs (ORCPT ); Mon, 21 Dec 2015 20:03:48 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,461,1444719600"; d="scan'208";a="712390684" From: "Chen, Yu C" To: Andy Lutomirski , "Zheng, Lv" CC: "Moore, Robert" , "Wysocki, Rafael J" , "Brown, Len" , "Andy Lutomirski" , Lv Zheng , "linux-kernel@vger.kernel.org" , Linux ACPI , "H. Peter Anvin" , "Borislav Petkov" Subject: RE: [PATCH v4 7/7] ACPI / x86: introduce acpi_os_readable() support Thread-Topic: [PATCH v4 7/7] ACPI / x86: introduce acpi_os_readable() support Thread-Index: AQHRLXRnRL/kuZhBvUWr+aZgefsuPJ7KrTWAgABxKICAAKu9UIABCo7ggAIi7ACAB1SzoA== Date: Tue, 22 Dec 2015 01:03:43 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE640286886D1@shsmsx102.ccr.corp.intel.com> References: <36DF59CE26D8EE47B0655C516E9CE64028686D35@shsmsx102.ccr.corp.intel.com> <1AE640813FDE7649BE1B193DEA596E883BB08C24@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTBhMTNhMzktYmY0Yi00OGQ1LWIzODUtMTBkZWFmMTk5MDg3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK0R5KzZOTWVJTkQ1VTZNK2kzNnZsTjlERk45YmRyZnFwYmZBWUpDY1wvMjA9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tBM13swT006992 Hi Andy, thanks for your review, > -----Original Message----- > From: Andy Lutomirski [mailto:luto@amacapital.net] > Sent: Friday, December 18, 2015 1:00 AM > To: Zheng, Lv > Cc: Chen, Yu C; Moore, Robert; Wysocki, Rafael J; Brown, Len; Andy > Lutomirski; Lv Zheng; linux-kernel@vger.kernel.org; Linux ACPI; H. Peter > Anvin; Borislav Petkov > Subject: Re: [PATCH v4 7/7] ACPI / x86: introduce acpi_os_readable() support > [cut] > > I think that hpa or Borislav [cc'd] could address the memory map details > better than I could. However, this functionality seems strange. > > Are these physical addresses or virtual addresses that are being dumped? [Yu] They are virtual addresses to be dumped. > In either case, ISTM that using something iike page_is_ram might be a lot > simpler. [Yu] if i understand correctly, this API is used to check if the address is a valid 'kmalloc' style address, but not 'kmap' or 'vmalloc' address, and page_is_ram might treat the latter as valid address? thanks, Yu {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I