From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938567AbcKXJy0 convert rfc822-to-8bit (ORCPT ); Thu, 24 Nov 2016 04:54:26 -0500 Received: from mga05.intel.com ([192.55.52.43]:8561 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932884AbcKXJyZ (ORCPT ); Thu, 24 Nov 2016 04:54:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,690,1473145200"; d="scan'208";a="35052300" From: "Chen, Yu C" To: Ingo Molnar , John Stultz CC: lkml , "Rafael J. Wysocki" , Xunlei Pang , Ingo Molnar , Len Brown , "H. Peter Anvin" , Pavel Machek , Thomas Gleixner , Prarit Bhargava , Richard Cochran Subject: RE: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace is enabled Thread-Topic: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace is enabled Thread-Index: AQHSQiC7f6imqm5yNUScq+I2ZxdeK6DilSeAgAVXvxA= Date: Thu, 24 Nov 2016 09:54:06 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE6405E63B123@shsmsx102.ccr.corp.intel.com> References: <1479531014-25264-1-git-send-email-john.stultz@linaro.org> <1479531014-25264-4-git-send-email-john.stultz@linaro.org> <20161121081755.GB14231@gmail.com> In-Reply-To: <20161121081755.GB14231@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjFkMGRmZTAtODNiYy00NDk0LWFmYWUtNDQ0YWZmNTlhY2I4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlwvNjltd0wrM3oxUDNZbm0yc3Z0d3IrVWpkWkRkNG1GN3E1Z3BvQUhmWWpJPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > -----Original Message----- > From: Ingo Molnar [mailto:mingo.kernel.org@gmail.com] On Behalf Of Ingo > Molnar > Sent: Monday, November 21, 2016 4:18 PM > To: John Stultz > Cc: lkml; Chen, Yu C; Rafael J. Wysocki; Xunlei Pang; Ingo Molnar; Len Brown; H. > Peter Anvin; Pavel Machek; Thomas Gleixner; Prarit Bhargava; Richard Cochran > Subject: Re: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace > is enabled > > > * John Stultz wrote: > > > +static int pm_trace_notify(struct notifier_block *nb, > > + unsigned long mode, void *_unused) { > > + switch (mode) { > > + case PM_POST_HIBERNATION: > > + case PM_POST_SUSPEND: > > + if (pm_trace_rtc_abused) { > > + pm_trace_rtc_abused = false; > > + pr_warn("Possible incorrect RTC due to pm_trace," > > + "please use ntp-date or rdate to reset.\n"); > > Please don't break user-visible strings just to pacify checkpatch! > > The bogus linebreak above hides a type in the user string: > > Possible incorrect RTC due to pm_trace,please use ntp-date or rdate to reset. > > (There's a missing space after the comma.) > > Best practice is to preserve the continuous nature of the user string in the code. > > In addition to that, please quote suggested command names, i.e. something like: > > Possible incorrect RTC due to pm_trace, please use 'ntp-date' or 'rdate' to > reset it. OK, will do. > > > --- a/drivers/rtc/rtc-cmos.c > > +++ b/drivers/rtc/rtc-cmos.c > > @@ -191,6 +191,13 @@ static inline void cmos_write_bank2(unsigned char > > val, unsigned char addr) > > > > static int cmos_read_time(struct device *dev, struct rtc_time *t) { > > + /* > > + * If pmtrace abused the RTC for storage tell the caller that it is > > + * unusable. > > + */ > > + if (!pm_trace_rtc_valid()) > > + return -EIO; > > Please standardize the spelling of 'pm_trace', as there's 3 variants present in > this patch alone: > > 'pm_trace' > 'pm trace' > 'pmtrace' OK, will do. > > (Not to mention pm-trace.h - but that's a pre-existing inconsistency unrelated > to your patch.) > > Thanks, > > Ingo Thanks!