From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755888AbcK1XqD (ORCPT ); Mon, 28 Nov 2016 18:46:03 -0500 Received: from mga02.intel.com ([134.134.136.20]:7616 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753647AbcK1Xp4 (ORCPT ); Mon, 28 Nov 2016 18:45:56 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,565,1473145200"; d="scan'208";a="1065407193" From: "Chen, Yu C" To: John Stultz CC: Ingo Molnar , lkml , "Rafael J. Wysocki" , Xunlei Pang , Ingo Molnar , Len Brown , "H. Peter Anvin" , Pavel Machek , Thomas Gleixner , Prarit Bhargava , Richard Cochran Subject: RE: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace is enabled Thread-Topic: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace is enabled Thread-Index: AQHSQiC7f6imqm5yNUScq+I2ZxdeK6DilSeAgAVXvxCABlY3AIAA2rOg Date: Mon, 28 Nov 2016 23:45:50 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE6405E63B6BD@shsmsx102.ccr.corp.intel.com> References: <1479531014-25264-1-git-send-email-john.stultz@linaro.org> <1479531014-25264-4-git-send-email-john.stultz@linaro.org> <20161121081755.GB14231@gmail.com> <36DF59CE26D8EE47B0655C516E9CE6405E63B123@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjcwNjljMjUtZWZkOS00MTNkLWJkZjYtN2YxNzEyMDFjNTNiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlE2RmxRWGI2eGc1RWFvTFJnQmhOZk94OUJJbUpSNFNsYzZob3hPVkRRZzA9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uASNk7Ab016116 > -----Original Message----- > From: John Stultz [mailto:john.stultz@linaro.org] > Sent: Tuesday, November 29, 2016 2:39 AM > To: Chen, Yu C > Cc: Ingo Molnar; lkml; Rafael J. Wysocki; Xunlei Pang; Ingo Molnar; Len Brown; > H. Peter Anvin; Pavel Machek; Thomas Gleixner; Prarit Bhargava; Richard > Cochran > Subject: Re: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace > is enabled > > On Thu, Nov 24, 2016 at 1:54 AM, Chen, Yu C wrote: > > Hi, > > > >> -----Original Message----- > >> From: Ingo Molnar [mailto:mingo.kernel.org@gmail.com] On Behalf Of > >> Ingo Molnar > >> Sent: Monday, November 21, 2016 4:18 PM > >> To: John Stultz > >> Cc: lkml; Chen, Yu C; Rafael J. Wysocki; Xunlei Pang; Ingo Molnar; Len Brown; > H. > >> Peter Anvin; Pavel Machek; Thomas Gleixner; Prarit Bhargava; Richard > >> Cochran > >> Subject: Re: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if > >> pm_trace is enabled > >> > >> > >> * John Stultz wrote: > >> > >> > +static int pm_trace_notify(struct notifier_block *nb, > >> > + unsigned long mode, void *_unused) { > >> > + switch (mode) { > >> > + case PM_POST_HIBERNATION: > >> > + case PM_POST_SUSPEND: > >> > + if (pm_trace_rtc_abused) { > >> > + pm_trace_rtc_abused = false; > >> > + pr_warn("Possible incorrect RTC due to pm_trace," > >> > + "please use ntp-date or rdate to > >> > +reset.\n"); > >> > >> Please don't break user-visible strings just to pacify checkpatch! > >> > >> The bogus linebreak above hides a type in the user string: > >> > >> Possible incorrect RTC due to pm_trace,please use ntp-date or rdate to > reset. > >> > >> (There's a missing space after the comma.) > >> > >> Best practice is to preserve the continuous nature of the user string in the > code. > >> > >> In addition to that, please quote suggested command names, i.e. something > like: > >> > >> Possible incorrect RTC due to pm_trace, please use 'ntp-date' or > >> 'rdate' to reset it. > > OK, will do. > > Just a heads up. I've already made these changes in my tree. > > thanks > -john OK, thanks very much! john. Yu