From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1988500-1520516101-2-8091379853129214763 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.249, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='com', MailFrom='org' X-Spam-charsets: to='UTF-8', cc='UTF-8', plain='utf-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1520516100; b=Eylz77GdPan1/RV333IGhCe6Dj9hsiHCLRepEA7dl7GFVsQ G+gEsZBJn3sLXKmzx7/mpRSvPSdlsbOFyGCU7NwsO8oTMBKJT1iiTmGoqzRVil95 VJ/0V7msm8jV0ETogMelbILzGIOW1g56LCdRUuW4TVDXDEw8geDgt2tIPAhG8L25 QE1eqCjofh5H67lQED0zaJDjX/0OUjFV7NAbQ4PcGUdkoBOlH25KYENZ2kOhvs4L MTLcteN8jqVh4zrc9bIVhMZ5/NXgJVs4FfUM3CK+RSBLZ7cPEPL1TdCDEBA8OIul ZxbwhInBATciUwTgO6xjFssYiSUhtd3JpoJa2+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:cc:references:from:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1520516100; bh=gEDusAy0b0R91kFHWlsarMLtm3VL/V/sfP2F+S53r4s=; b=g UkQLnhmdjiQ+DYuJxRUu5O+WI0MYL7MLw5gAAjymgIQJ9MY+obnjhTTLpeNeLNoZ OayRqIEv6tCDb+z0qArTCs8OG3dsfqVRvgCZm/i0CRVNLBWcylLrDLGbKrs4TKrE 4t7ka4q+VfuuEgL+Dmp4N9e7fJvjndxvC7zOMuZeNJDi5mMsCOaca/KYm2BcmETE r8DzjWN9Yw6HGavPbBJTHtPZCY4ir8oSUI78i/LfmMD/TPyxmyeXoIkpaOVY7Z6Q hvRUxtT3xbz81FjM+jJ6DKgXDF5NjyiQqwJOgfg4PNghT1kWUkhh8saHhSzdYsHV Vue7CgtWR45YvhFMIml2w== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=F8/S31OS x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=pass (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=BcTG8MB0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=F8/S31OS x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=pass (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=BcTG8MB0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755938AbeCHNea (ORCPT ); Thu, 8 Mar 2018 08:34:30 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:53077 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755936AbeCHNeC (ORCPT ); Thu, 8 Mar 2018 08:34:02 -0500 X-Google-Smtp-Source: AG47ELubRx/ztiMbpRUumXS2CEOEPCOkdaRfezsNPah4dbcqKeUHtm75HzKd2I/f4LRRZjbUiRg4Uw== Subject: Re: [PATCH 00/45] arm Spectre fix backport review for LTS 4.9 To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Pavel Machek Cc: Alex Shi , sre@kernel.org, linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com, clayton@craftyguy.net, martijn@brixit.nl, sakari.ailus@linux.intel.com, =?UTF-8?Q?Filip_Matijevi=c4=87?= , Marc Zyngier , Will Deacon , Ard Biesheuvel , Catalin Marinas , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1519908862-11425-1-git-send-email-alex.shi@linaro.org> <20180308122715.GB21514@amd> <20180308132139.apabmgw4magrp3d7@pali> From: Ivaylo Dimitrov Message-ID: <36c7b85a-dadb-6e05-6c19-58c6ff6ae728@gmail.com> Date: Thu, 8 Mar 2018 15:33:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180308132139.apabmgw4magrp3d7@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi, On 8.03.2018 15:21, Pali Rohár wrote: > On Thursday 08 March 2018 13:27:15 Pavel Machek wrote: >> Hi! >> >>> Resent without non-upstream patches. >>> >>> This backport patchset fixed the spectre issue, it's original branch: >>> https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=kpti >>> A few dependency or fixingpatches are also picked up, if they are necessary >>> and no functional changes. >>> >>> No bug found from kernelci.org and lkft testing. It also could be gotten from: >>> >>> git://git.linaro.org/kernel/linux-linaro-stable.git v4.9-spectre-upstream-only >>> >>> Comments are appreciated! >> >> Not entirely related to this patched, but... I have few older ARM >> boards here, and Nokia N9000 I really care about. >> >> AFAICT Meltdown is arm64 only? > > IIRC ARMv7 is not affected by meltdown. > >> Spectre affects the older boards, too, right? Was there any work done >> on that? cpuinfo says "ARMv7" for N900. > > I remember that I saw some spectre patches for ARMv7 on LKML. > > In general for ARMv7 it is problematic as mitigation needs to change IBE > bit which is not possible on OMAP HS devices. But for Nokia N900 there > is special code which do it via smc instruction (function > rx51_secure_update_aux_cr(), see also nokia_n900_legacy_init()). > I *think* N900 should be safe from spectre attack as a side effect of thumb2 errata (430973) workaround (BTB is flushed on every context switch), but don't quote me on that one, lets more knowledgeable than me to confirm first. Ivo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivaylo Dimitrov Subject: Re: [PATCH 00/45] arm Spectre fix backport review for LTS 4.9 Date: Thu, 8 Mar 2018 15:33:58 +0200 Message-ID: <36c7b85a-dadb-6e05-6c19-58c6ff6ae728@gmail.com> References: <1519908862-11425-1-git-send-email-alex.shi@linaro.org> <20180308122715.GB21514@amd> <20180308132139.apabmgw4magrp3d7@pali> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180308132139.apabmgw4magrp3d7@pali> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Pavel Machek Cc: abcloriens@gmail.com, aaro.koskinen@iki.fi, tony@atomide.com, Catalin Marinas , khilman@kernel.org, Will Deacon , sre@kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, martijn@brixit.nl, =?UTF-8?Q?Filip_Matijevi=c4=87?= , clayton@craftyguy.net, sakari.ailus@linux.intel.com, Marc Zyngier , Alex Shi , linux-omap@vger.kernel.org, Ard Biesheuvel , patrikbachan@gmail.com, linux-arm-kernel@lists.infradead.org, serge@hallyn.com List-Id: linux-omap@vger.kernel.org SGksCgpPbiAgOC4wMy4yMDE4IDE1OjIxLCBQYWxpIFJvaMOhciB3cm90ZToKPiBPbiBUaHVyc2Rh eSAwOCBNYXJjaCAyMDE4IDEzOjI3OjE1IFBhdmVsIE1hY2hlayB3cm90ZToKPj4gSGkhCj4+Cj4+ PiBSZXNlbnQgd2l0aG91dCBub24tdXBzdHJlYW0gcGF0Y2hlcy4KPj4+Cj4+PiBUaGlzIGJhY2tw b3J0IHBhdGNoc2V0IGZpeGVkIHRoZSBzcGVjdHJlIGlzc3VlLCBpdCdzIG9yaWdpbmFsIGJyYW5j aDoKPj4+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2Fy bTY0L2xpbnV4LmdpdC9sb2cvP2g9a3B0aQo+Pj4gQSBmZXcgZGVwZW5kZW5jeSBvciBmaXhpbmdw YXRjaGVzIGFyZSBhbHNvIHBpY2tlZCB1cCwgaWYgdGhleSBhcmUgbmVjZXNzYXJ5Cj4+PiAgIGFu ZCBubyBmdW5jdGlvbmFsIGNoYW5nZXMuCj4+Pgo+Pj4gTm8gYnVnIGZvdW5kIGZyb20ga2VybmVs Y2kub3JnIGFuZCBsa2Z0IHRlc3RpbmcuIEl0IGFsc28gY291bGQgYmUgZ290dGVuIGZyb206Cj4+ Pgo+Pj4gZ2l0Oi8vZ2l0LmxpbmFyby5vcmcva2VybmVsL2xpbnV4LWxpbmFyby1zdGFibGUuZ2l0 IHY0Ljktc3BlY3RyZS11cHN0cmVhbS1vbmx5Cj4+Pgo+Pj4gQ29tbWVudHMgYXJlIGFwcHJlY2lh dGVkIQo+Pgo+PiBOb3QgZW50aXJlbHkgcmVsYXRlZCB0byB0aGlzIHBhdGNoZWQsIGJ1dC4uLiBJ IGhhdmUgZmV3IG9sZGVyIEFSTQo+PiBib2FyZHMgaGVyZSwgYW5kIE5va2lhIE45MDAwIEkgcmVh bGx5IGNhcmUgYWJvdXQuCj4+Cj4+IEFGQUlDVCBNZWx0ZG93biBpcyBhcm02NCBvbmx5Pwo+IAo+ IElJUkMgQVJNdjcgaXMgbm90IGFmZmVjdGVkIGJ5IG1lbHRkb3duLgo+IAo+PiBTcGVjdHJlIGFm ZmVjdHMgdGhlIG9sZGVyIGJvYXJkcywgdG9vLCByaWdodD8gV2FzIHRoZXJlIGFueSB3b3JrIGRv bmUKPj4gb24gdGhhdD8gY3B1aW5mbyBzYXlzICJBUk12NyIgZm9yIE45MDAuCj4gCj4gSSByZW1l bWJlciB0aGF0IEkgc2F3IHNvbWUgc3BlY3RyZSBwYXRjaGVzIGZvciBBUk12NyBvbiBMS01MLgo+ IAo+IEluIGdlbmVyYWwgZm9yIEFSTXY3IGl0IGlzIHByb2JsZW1hdGljIGFzIG1pdGlnYXRpb24g bmVlZHMgdG8gY2hhbmdlIElCRQo+IGJpdCB3aGljaCBpcyBub3QgcG9zc2libGUgb24gT01BUCBI UyBkZXZpY2VzLiBCdXQgZm9yIE5va2lhIE45MDAgdGhlcmUKPiBpcyBzcGVjaWFsIGNvZGUgd2hp Y2ggZG8gaXQgdmlhIHNtYyBpbnN0cnVjdGlvbiAoZnVuY3Rpb24KPiByeDUxX3NlY3VyZV91cGRh dGVfYXV4X2NyKCksIHNlZSBhbHNvIG5va2lhX245MDBfbGVnYWN5X2luaXQoKSkuCj4gCgpJICp0 aGluayogTjkwMCBzaG91bGQgYmUgc2FmZSBmcm9tIHNwZWN0cmUgYXR0YWNrIGFzIGEgc2lkZSBl ZmZlY3Qgb2YgCnRodW1iMiBlcnJhdGEgKDQzMDk3Mykgd29ya2Fyb3VuZCAoQlRCIGlzIGZsdXNo ZWQgb24gZXZlcnkgY29udGV4dCAKc3dpdGNoKSwgYnV0IGRvbid0IHF1b3RlIG1lIG9uIHRoYXQg b25lLCBsZXRzIG1vcmUga25vd2xlZGdlYWJsZSB0aGFuIG1lIAp0byBjb25maXJtIGZpcnN0LgoK SXZvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ivo.g.dimitrov.75@gmail.com (Ivaylo Dimitrov) Date: Thu, 8 Mar 2018 15:33:58 +0200 Subject: [PATCH 00/45] arm Spectre fix backport review for LTS 4.9 In-Reply-To: <20180308132139.apabmgw4magrp3d7@pali> References: <1519908862-11425-1-git-send-email-alex.shi@linaro.org> <20180308122715.GB21514@amd> <20180308132139.apabmgw4magrp3d7@pali> Message-ID: <36c7b85a-dadb-6e05-6c19-58c6ff6ae728@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 8.03.2018 15:21, Pali Roh?r wrote: > On Thursday 08 March 2018 13:27:15 Pavel Machek wrote: >> Hi! >> >>> Resent without non-upstream patches. >>> >>> This backport patchset fixed the spectre issue, it's original branch: >>> https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=kpti >>> A few dependency or fixingpatches are also picked up, if they are necessary >>> and no functional changes. >>> >>> No bug found from kernelci.org and lkft testing. It also could be gotten from: >>> >>> git://git.linaro.org/kernel/linux-linaro-stable.git v4.9-spectre-upstream-only >>> >>> Comments are appreciated! >> >> Not entirely related to this patched, but... I have few older ARM >> boards here, and Nokia N9000 I really care about. >> >> AFAICT Meltdown is arm64 only? > > IIRC ARMv7 is not affected by meltdown. > >> Spectre affects the older boards, too, right? Was there any work done >> on that? cpuinfo says "ARMv7" for N900. > > I remember that I saw some spectre patches for ARMv7 on LKML. > > In general for ARMv7 it is problematic as mitigation needs to change IBE > bit which is not possible on OMAP HS devices. But for Nokia N900 there > is special code which do it via smc instruction (function > rx51_secure_update_aux_cr(), see also nokia_n900_legacy_init()). > I *think* N900 should be safe from spectre attack as a side effect of thumb2 errata (430973) workaround (BTB is flushed on every context switch), but don't quote me on that one, lets more knowledgeable than me to confirm first. Ivo