From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCFEC433EF for ; Thu, 16 Jun 2022 01:31:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354405AbiFPBbx (ORCPT ); Wed, 15 Jun 2022 21:31:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350881AbiFPBbv (ORCPT ); Wed, 15 Jun 2022 21:31:51 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63EFF5713F; Wed, 15 Jun 2022 18:31:50 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LNl1T5L7WzSh0h; Thu, 16 Jun 2022 09:28:29 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 16 Jun 2022 09:31:48 +0800 Received: from [10.67.111.205] (10.67.111.205) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 16 Jun 2022 09:31:47 +0800 Subject: Re: [RFC 06/13] perf kwork: Implement perf kwork report To: Namhyung Kim CC: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , linux-kernel , linux-perf-users References: <20220613094605.208401-1-yangjihong1@huawei.com> <20220613094605.208401-7-yangjihong1@huawei.com> <2953080a-a1bd-0a1c-8466-96c4b58de2e6@huawei.com> From: Yang Jihong Message-ID: <36cb15b2-a8e0-1beb-3462-16a79d41c40d@huawei.com> Date: Thu, 16 Jun 2022 09:31:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.205] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 2022/6/16 6:01, Namhyung Kim wrote: > On Tue, Jun 14, 2022 at 8:12 PM Yang Jihong wrote: >> >> Hello, >> >> On 2022/6/15 5:49, Namhyung Kim wrote: >>> On Mon, Jun 13, 2022 at 2:48 AM Yang Jihong wrote: >>>> >>>> Implements framework of perf kwork report, which is used to report time >>>> properties such as run time and frequency: >>>> >>>> test case: >>>> >>>> Kwork Name | Cpu | Avg delay | Frequency | Max delay | Max delay start | Max delay end | >>>> --------------------------------------------------------------------------------------------------------------------------- >>>> --------------------------------------------------------------------------------------------------------------------------- >>>> >>>> Since there are no report supported events, the output is empty. >>>> >>>> Briefly describe the data structure: >>>> 1. "class" indicates event type. For example, irq and softiq correspond >>>> to different types. >>>> 2. "cluster" refers to a specific event corresponding to a type. For >>>> example, RCU and TIMER in softirq correspond to different clusters, >>>> which contains three types of events: raise, entry, and exit. >>> >>> I'm not good at naming but how about calling it "work" instead? >>> It's all about kernel works anyway.. >>> >> How about calling it "work_atoms" ? >> Otherwise, "work" feels a little similar to kwork_class in the first step. > > Didn't you already have "atom"? I think we can have a hierarchy like > class (IRQ) - work (eth0) - atom. OK, I'll modify it in next version according to this hierarchy. Thanks, Jihong .