All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] user: Mark cpu_loop() with noreturn attribute
@ 2021-09-05  0:04 Philippe Mathieu-Daudé
  2021-09-05  8:28 ` Richard Henderson
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-05  0:04 UTC (permalink / raw)
  To: qemu-devel
  Cc: Kyle Evans, Richard Henderson, Laurent Vivier, Warner Losh,
	Philippe Mathieu-Daudé

cpu_loop() never exits, so mark it with QEMU_NORETURN.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 bsd-user/qemu.h   | 2 +-
 linux-user/qemu.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index c02e8a5ca1a..05bee7aefe5 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -155,7 +155,7 @@ abi_long do_openbsd_syscall(void *cpu_env, int num, abi_long arg1,
                             abi_long arg5, abi_long arg6);
 void gemu_log(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
 extern THREAD CPUState *thread_cpu;
-void cpu_loop(CPUArchState *env);
+void QEMU_NORETURN cpu_loop(CPUArchState *env);
 char *target_strerror(int err);
 int get_osversion(void);
 void fork_start(void);
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 3b0b6b75fe8..5b2c764ae78 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -236,7 +236,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
                     abi_long arg5, abi_long arg6, abi_long arg7,
                     abi_long arg8);
 extern __thread CPUState *thread_cpu;
-void cpu_loop(CPUArchState *env);
+void QEMU_NORETURN cpu_loop(CPUArchState *env);
 const char *target_strerror(int err);
 int get_osversion(void);
 void init_qemu_uname_release(void);
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] user: Mark cpu_loop() with noreturn attribute
  2021-09-05  0:04 [PATCH] user: Mark cpu_loop() with noreturn attribute Philippe Mathieu-Daudé
@ 2021-09-05  8:28 ` Richard Henderson
  2021-09-05 14:22 ` Warner Losh
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2021-09-05  8:28 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Kyle Evans, Laurent Vivier, Warner Losh

On 9/5/21 2:04 AM, Philippe Mathieu-Daudé wrote:
> cpu_loop() never exits, so mark it with QEMU_NORETURN.
> 
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   bsd-user/qemu.h   | 2 +-
>   linux-user/qemu.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] user: Mark cpu_loop() with noreturn attribute
  2021-09-05  0:04 [PATCH] user: Mark cpu_loop() with noreturn attribute Philippe Mathieu-Daudé
  2021-09-05  8:28 ` Richard Henderson
@ 2021-09-05 14:22 ` Warner Losh
  2021-09-05 16:02 ` Bin Meng
  2021-09-12 21:46 ` Richard Henderson
  3 siblings, 0 replies; 5+ messages in thread
From: Warner Losh @ 2021-09-05 14:22 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: Kyle Evans, Richard Henderson, QEMU Developers, Laurent Vivier

[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]

On Sat, Sep 4, 2021 at 6:04 PM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:

> cpu_loop() never exits, so mark it with QEMU_NORETURN.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  bsd-user/qemu.h   | 2 +-
>  linux-user/qemu.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-By: Warner Losh <imp@bsdimp.com>


diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
> index c02e8a5ca1a..05bee7aefe5 100644
> --- a/bsd-user/qemu.h
> +++ b/bsd-user/qemu.h
> @@ -155,7 +155,7 @@ abi_long do_openbsd_syscall(void *cpu_env, int num,
> abi_long arg1,
>                              abi_long arg5, abi_long arg6);
>  void gemu_log(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
>  extern THREAD CPUState *thread_cpu;
> -void cpu_loop(CPUArchState *env);
> +void QEMU_NORETURN cpu_loop(CPUArchState *env);
>  char *target_strerror(int err);
>  int get_osversion(void);
>  void fork_start(void);
> diff --git a/linux-user/qemu.h b/linux-user/qemu.h
> index 3b0b6b75fe8..5b2c764ae78 100644
> --- a/linux-user/qemu.h
> +++ b/linux-user/qemu.h
> @@ -236,7 +236,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
> arg1,
>                      abi_long arg5, abi_long arg6, abi_long arg7,
>                      abi_long arg8);
>  extern __thread CPUState *thread_cpu;
> -void cpu_loop(CPUArchState *env);
> +void QEMU_NORETURN cpu_loop(CPUArchState *env);
>  const char *target_strerror(int err);
>  int get_osversion(void);
>  void init_qemu_uname_release(void);
> --
> 2.31.1
>
>

[-- Attachment #2: Type: text/html, Size: 2258 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] user: Mark cpu_loop() with noreturn attribute
  2021-09-05  0:04 [PATCH] user: Mark cpu_loop() with noreturn attribute Philippe Mathieu-Daudé
  2021-09-05  8:28 ` Richard Henderson
  2021-09-05 14:22 ` Warner Losh
@ 2021-09-05 16:02 ` Bin Meng
  2021-09-12 21:46 ` Richard Henderson
  3 siblings, 0 replies; 5+ messages in thread
From: Bin Meng @ 2021-09-05 16:02 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: Kyle Evans, Richard Henderson, qemu-devel@nongnu.org Developers,
	Warner Losh, Laurent Vivier

On Sun, Sep 5, 2021 at 8:18 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> cpu_loop() never exits, so mark it with QEMU_NORETURN.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  bsd-user/qemu.h   | 2 +-
>  linux-user/qemu.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] user: Mark cpu_loop() with noreturn attribute
  2021-09-05  0:04 [PATCH] user: Mark cpu_loop() with noreturn attribute Philippe Mathieu-Daudé
                   ` (2 preceding siblings ...)
  2021-09-05 16:02 ` Bin Meng
@ 2021-09-12 21:46 ` Richard Henderson
  3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2021-09-12 21:46 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Kyle Evans, Laurent Vivier, Warner Losh

On 9/4/21 5:04 PM, Philippe Mathieu-Daudé wrote:
> cpu_loop() never exits, so mark it with QEMU_NORETURN.
> 
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   bsd-user/qemu.h   | 2 +-
>   linux-user/qemu.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

Queued, thanks.

r~


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-12 21:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-05  0:04 [PATCH] user: Mark cpu_loop() with noreturn attribute Philippe Mathieu-Daudé
2021-09-05  8:28 ` Richard Henderson
2021-09-05 14:22 ` Warner Losh
2021-09-05 16:02 ` Bin Meng
2021-09-12 21:46 ` Richard Henderson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.