All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, stefanb@linux.vnet.ibm.com,
	richard.henderson@linaro.org, f4bug@amsat.org,
	Kamil Rytarowski <kamil@netbsd.org>,
	cota@braap.org, Gerd Hoffmann <kraxel@redhat.com>,
	stefanha@redhat.com, marcandre.lureau@redhat.com,
	pbonzini@redhat.com, aurelien@aurel32.net
Subject: Re: [PATCH v1 3/6] tests/vm: use console_consume for netbsd
Date: Mon, 4 Nov 2019 19:46:17 +0100	[thread overview]
Message-ID: <36d0d305-01f8-3604-79df-24ec7cd1843c@redhat.com> (raw)
In-Reply-To: <20191104173654.30125-4-alex.bennee@linaro.org>

Hi Alex,

On 11/4/19 6:36 PM, Alex Bennée wrote:
> From: Gerd Hoffmann <kraxel@redhat.com>
> 
> Use new helper to read all pending console output,
> not just a single char.  Unblocks installer boot.

Again, why not use this by default for everything?

Anyway,
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Message-Id: <20191031085306.28888-4-kraxel@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/vm/netbsd | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
> index 5e04dcd9b16..d1bccccfd01 100755
> --- a/tests/vm/netbsd
> +++ b/tests/vm/netbsd
> @@ -93,7 +93,7 @@ class NetBSDVM(basevm.BaseVM):
>           for char in list("5consdev com0\n"):
>               time.sleep(0.2)
>               self.console_send(char)
> -            self.console_wait("")
> +            self.console_consume()
>           self.console_wait_send("> ", "boot\n")
>   
>           self.console_wait_send("Terminal type",            "xterm\n")
> 


  reply	other threads:[~2019-11-04 18:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 17:36 [PATCH v1 0/6] testing/next (netbsd stuff) Alex Bennée
2019-11-04 17:36 ` [PATCH v1 1/6] tests/vm: netbsd autoinstall, using serial console Alex Bennée
2019-11-04 18:44   ` Philippe Mathieu-Daudé
2019-11-04 18:57   ` Philippe Mathieu-Daudé
2019-11-11 14:20   ` Thomas Huth
2019-11-04 17:36 ` [PATCH v1 2/6] tests/vm: add console_consume helper Alex Bennée
2019-11-04 18:44   ` Philippe Mathieu-Daudé
2019-11-04 17:36 ` [PATCH v1 3/6] tests/vm: use console_consume for netbsd Alex Bennée
2019-11-04 18:46   ` Philippe Mathieu-Daudé [this message]
2019-11-04 19:43     ` Alex Bennée
2019-11-04 17:36 ` [PATCH v1 4/6] tests/vm: update netbsd to version 8.1 Alex Bennée
2019-11-04 18:45   ` Philippe Mathieu-Daudé
2019-11-04 17:36 ` [PATCH v1 5/6] tests: only run ipmi-bt-test if CONFIG_LINUX Alex Bennée
2019-11-04 18:36   ` Corey Minyard
2019-11-04 19:42     ` Alex Bennée
2019-11-04 17:36 ` [PATCH v1 6/6] tests/vm: support sites with sha512 checksums Alex Bennée
2019-11-04 18:50   ` Philippe Mathieu-Daudé
2019-11-07 17:46 ` [PATCH v1 0/6] testing/next (netbsd stuff) Peter Maydell
2019-11-07 17:53   ` Kamil Rytarowski
2019-11-07 17:58     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36d0d305-01f8-3604-79df-24ec7cd1843c@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=kamil@netbsd.org \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.