From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1CD1C433E2 for ; Thu, 17 Sep 2020 10:25:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8848E22205 for ; Thu, 17 Sep 2020 10:25:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YkdtHyyr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgIQKYz (ORCPT ); Thu, 17 Sep 2020 06:24:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbgIQKYF (ORCPT ); Thu, 17 Sep 2020 06:24:05 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC692C06174A; Thu, 17 Sep 2020 03:24:04 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id c18so1445938wrm.9; Thu, 17 Sep 2020 03:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=h2LFimxoyNonSX50+U9lgU4xGUhF6TvhEo2cl22/6to=; b=YkdtHyyrqsnArPN1o1wdZM04OLHAjusxeyiU05bk6yIvyztJndYBnXlLqhaJkmmzI7 /HRr0VoNUmuM3dqp0sXUcfRzfac1eYN3KRfsDoDNXnoAkhsHskyCtguu6p8fAsHDIk8r r8tvEcdgM5y8k+TdCPJf3KPtXjUmhPAMoyuemy+TiQG870NfHZRYZpudwP5UrVyy2rnH N4IZbg6ihAylKLrFoG4qTsXumf5hf8WfHh6g+bIzkwoBSEQzfduyF7R2oSs5lu3GePiY nEQzpABeCmyqJ+YgiGdu5yqQ+t9tizSBsQU0xMmK+bFe/jOXQ7fcaZ2R1vf+8W6lyCtP P0Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=h2LFimxoyNonSX50+U9lgU4xGUhF6TvhEo2cl22/6to=; b=aa1VDcoQg6/RU6RCxC9Xf5zjxjHW2suoLto7MRVRWIeQ7IrlO1pLDC9EXDMHCmZUy6 l1SneOpjqKGGuFjjx1LOPcjw0XVesiM25RRB8clq54cpZCgSmjysM4VxHuAHxrgdCfKN nxaB/5HUoW7qOzxEASrmYyZeX3S4OIjVsC9YcxropF+qFuXmrqrneQw8LlfZSRCFcm6G sAK364xM3gqitmNkJspEeFbsRCFKUeK7gkNHUUu0C7CLJxRD7aPYvJ48KM5wF8/LRq0C cTR+ySOGD16li+DcHf4UQ9A6JCAUX0ZPDeZ3Uc35mnB5oQ7BJv0q/rUBhSOur3Dx3WQh 6qag== X-Gm-Message-State: AOAM533zZ5JNTbTEukdjkswjdDtghYI7jPVBS4ODjZ4B0mIVfFgJy8Tl i0PqJoeGUouAUWpZ1HQy5bQ= X-Google-Smtp-Source: ABdhPJxk4RL8Vf6mAUx1Otx9e8fG7C/3c0n7sGBIWdI5eI4rHJ+K/A7mw1Ff+ox2J0agrbCPqo54Ig== X-Received: by 2002:adf:f14f:: with SMTP id y15mr30377971wro.69.1600338243397; Thu, 17 Sep 2020 03:24:03 -0700 (PDT) Received: from [192.168.1.211] ([2.29.208.34]) by smtp.gmail.com with ESMTPSA id l4sm10287901wme.43.2020.09.17.03.24.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2020 03:24:02 -0700 (PDT) Subject: Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms To: Dan Carpenter Cc: Greg KH , devel@driverdev.osuosl.org, robh@kernel.org, jorhand@linux.microsoft.com, linux-media@vger.kernel.org, kieran.bingham@ideasonboard.com, linux-kernel@vger.kernel.org, kitakar@gmail.com, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, mchehab@kernel.org, davem@davemloft.net, tian.shu.qiu@intel.com, yong.zhi@intel.com References: <20200916213618.8003-1-djrscally@gmail.com> <20200917075356.GA3333802@kroah.com> <20200917101538.GO4282@kadam> From: Dan Scally Message-ID: <36d3322a-3128-83b8-bd14-72da34b71e7c@gmail.com> Date: Thu, 17 Sep 2020 11:24:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200917101538.GO4282@kadam> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/09/2020 11:15, Dan Carpenter wrote: > On Thu, Sep 17, 2020 at 10:47:50AM +0100, Dan Scally wrote: >> Hi Greg - thanks for the comments, appreciate it (sorry there's so many, >> I'm new to both C and kernel work) > It's pretty impressive work if you're new to C... Thanks (and for your other reply too, haven't had time to go through it in depth yet). I've been using python for a while, but this is my first attempt at anything serious with C. >>>> + return; >>> No error value? >> The prototype for sync_state callbacks is to return void, so my >> understanding is it can't return an error value.  I guess a better thing >> to do might be call another function performing cleanup and unloading >> the driver before the return or something along those lines though. > Yeah. I suspect you should be using a different callback instead of > ->sync_state() but I don't know what... :/ Yeah, this is why I wanted to submit it now really; I too suspect I should really be using a different callback but I couldn't find a better option. > regards, > dan carpenter > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD8DC2BBD1 for ; Thu, 17 Sep 2020 10:24:08 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BE442083B for ; Thu, 17 Sep 2020 10:24:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YkdtHyyr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BE442083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id E55DD2E16E; Thu, 17 Sep 2020 10:24:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vuqkJzocbwJo; Thu, 17 Sep 2020 10:24:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 8A89F2E163; Thu, 17 Sep 2020 10:24:06 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 1761B1BF387 for ; Thu, 17 Sep 2020 10:24:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 074252040E for ; Thu, 17 Sep 2020 10:24:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 26DGGw56ZLNr for ; Thu, 17 Sep 2020 10:24:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by silver.osuosl.org (Postfix) with ESMTPS id EFD302E163 for ; Thu, 17 Sep 2020 10:24:04 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id a17so1458078wrn.6 for ; Thu, 17 Sep 2020 03:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=h2LFimxoyNonSX50+U9lgU4xGUhF6TvhEo2cl22/6to=; b=YkdtHyyrqsnArPN1o1wdZM04OLHAjusxeyiU05bk6yIvyztJndYBnXlLqhaJkmmzI7 /HRr0VoNUmuM3dqp0sXUcfRzfac1eYN3KRfsDoDNXnoAkhsHskyCtguu6p8fAsHDIk8r r8tvEcdgM5y8k+TdCPJf3KPtXjUmhPAMoyuemy+TiQG870NfHZRYZpudwP5UrVyy2rnH N4IZbg6ihAylKLrFoG4qTsXumf5hf8WfHh6g+bIzkwoBSEQzfduyF7R2oSs5lu3GePiY nEQzpABeCmyqJ+YgiGdu5yqQ+t9tizSBsQU0xMmK+bFe/jOXQ7fcaZ2R1vf+8W6lyCtP P0Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=h2LFimxoyNonSX50+U9lgU4xGUhF6TvhEo2cl22/6to=; b=U7LUy6qRPxaDjNzQffQYS52l/2z1364exJeKXm0H8K9Y3Ldc4MYYn+W+ep6cYstPU1 3wVk8S0gUsRyROSVkgTfBUSpc5NKaa7i29xXXe2+xcc2Y0hk3t+HKvSqS5UKDd83g32j QL1f1fi4cOvo/YEqmlNOihDWezGruAJww/lSATCpUAG0N8WQrNl8FC8XAlZTgmgS/vya kFnluHMbgv2eFXd8zRGRyViYFbrJYQnvVGUO+zHwttOCWoAtdsT5xbW8CQhJ8XMHXWfS gxjiIieUnv4sVAqa8XnfcRzTA1LCMG5ElhWqwlJ+Bj9pPymkxCSHxYPWt/vxcdIoT9Ji 51rg== X-Gm-Message-State: AOAM530nXfFahkmo528LgyE+K9TxngN/7Mhi7lmKZLDh5RcTNUbxeFOK Ap1sIWI01LIqU9AozVqLlAo= X-Google-Smtp-Source: ABdhPJxk4RL8Vf6mAUx1Otx9e8fG7C/3c0n7sGBIWdI5eI4rHJ+K/A7mw1Ff+ox2J0agrbCPqo54Ig== X-Received: by 2002:adf:f14f:: with SMTP id y15mr30377971wro.69.1600338243397; Thu, 17 Sep 2020 03:24:03 -0700 (PDT) Received: from [192.168.1.211] ([2.29.208.34]) by smtp.gmail.com with ESMTPSA id l4sm10287901wme.43.2020.09.17.03.24.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2020 03:24:02 -0700 (PDT) Subject: Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms To: Dan Carpenter References: <20200916213618.8003-1-djrscally@gmail.com> <20200917075356.GA3333802@kroah.com> <20200917101538.GO4282@kadam> From: Dan Scally Message-ID: <36d3322a-3128-83b8-bd14-72da34b71e7c@gmail.com> Date: Thu, 17 Sep 2020 11:24:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200917101538.GO4282@kadam> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, robh@kernel.org, mchehab@kernel.org, jorhand@linux.microsoft.com, Greg KH , kieran.bingham@ideasonboard.com, linux-kernel@vger.kernel.org, yong.zhi@intel.com, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, kitakar@gmail.com, davem@davemloft.net, tian.shu.qiu@intel.com, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gMTcvMDkvMjAyMCAxMToxNSwgRGFuIENhcnBlbnRlciB3cm90ZToKPiBPbiBUaHUsIFNlcCAx NywgMjAyMCBhdCAxMDo0Nzo1MEFNICswMTAwLCBEYW4gU2NhbGx5IHdyb3RlOgo+PiBIaSBHcmVn IC0gdGhhbmtzIGZvciB0aGUgY29tbWVudHMsIGFwcHJlY2lhdGUgaXQgKHNvcnJ5IHRoZXJlJ3Mg c28gbWFueSwKPj4gSSdtIG5ldyB0byBib3RoIEMgYW5kIGtlcm5lbCB3b3JrKQo+IEl0J3MgcHJl dHR5IGltcHJlc3NpdmUgd29yayBpZiB5b3UncmUgbmV3IHRvIEMuLi4KVGhhbmtzIChhbmQgZm9y IHlvdXIgb3RoZXIgcmVwbHkgdG9vLCBoYXZlbid0IGhhZCB0aW1lIHRvIGdvIHRocm91Z2ggaXQK aW4gZGVwdGggeWV0KS4gSSd2ZSBiZWVuIHVzaW5nIHB5dGhvbiBmb3IgYSB3aGlsZSwgYnV0IHRo aXMgaXMgbXkgZmlyc3QKYXR0ZW1wdCBhdCBhbnl0aGluZyBzZXJpb3VzIHdpdGggQy4KPj4+PiAr CQkJcmV0dXJuOwo+Pj4gTm8gZXJyb3IgdmFsdWU/Cj4+IFRoZSBwcm90b3R5cGUgZm9yIHN5bmNf c3RhdGUgY2FsbGJhY2tzIGlzIHRvIHJldHVybiB2b2lkLCBzbyBteQo+PiB1bmRlcnN0YW5kaW5n IGlzIGl0IGNhbid0IHJldHVybiBhbiBlcnJvciB2YWx1ZS7CoCBJIGd1ZXNzIGEgYmV0dGVyIHRo aW5nCj4+IHRvIGRvIG1pZ2h0IGJlIGNhbGwgYW5vdGhlciBmdW5jdGlvbiBwZXJmb3JtaW5nIGNs ZWFudXAgYW5kIHVubG9hZGluZwo+PiB0aGUgZHJpdmVyIGJlZm9yZSB0aGUgcmV0dXJuIG9yIHNv bWV0aGluZyBhbG9uZyB0aG9zZSBsaW5lcyB0aG91Z2guCj4gWWVhaC4gIEkgc3VzcGVjdCB5b3Ug c2hvdWxkIGJlIHVzaW5nIGEgZGlmZmVyZW50IGNhbGxiYWNrIGluc3RlYWQgb2YKPiAtPnN5bmNf c3RhdGUoKSBidXQgSSBkb24ndCBrbm93IHdoYXQuLi4gOi8KWWVhaCwgdGhpcyBpcyB3aHkgSSB3 YW50ZWQgdG8gc3VibWl0IGl0IG5vdyByZWFsbHk7IEkgdG9vIHN1c3BlY3QgSQpzaG91bGQgcmVh bGx5IGJlIHVzaW5nIGEgZGlmZmVyZW50IGNhbGxiYWNrIGJ1dCBJIGNvdWxkbid0IGZpbmQgYSBi ZXR0ZXIKb3B0aW9uLgo+IHJlZ2FyZHMsCj4gZGFuIGNhcnBlbnRlcgo+Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZl bEBsaW51eGRyaXZlcnByb2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9q ZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo=